-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport reattach testing to v1. #527
Conversation
Backport the reattach-based binary acceptance testing mode introduced in v2 to our v1 branch. It will only be enabled if TF_ACC_REATTACH is set to 1 _and_ binary acceptance testing is used.
In theory this should be a backwards-compatible change, but I'd love if reviewers evaluated with an eye to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this change is backwards compatible (emitting the extra debug log line if UseBinaryDriver
is called).
Need to release v2 of terraform-plugin-test before merging.
Also, as the test/vet failures indicate, the addition of |
Switch the %w for %v in fmt.Errorf.
I opted to keep 1.12 support for ease of upgrade, because the feature differentiation wasn't that important. Also, the Azure team helpfully verified that this works as expected in their test runs. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Backport the reattach-based binary acceptance testing mode introduced in
v2 to our v1 branch. It will only be enabled if TF_ACC_REATTACH is set
to 1 and binary acceptance testing is used.