Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport reattach testing to v1. #527

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Conversation

paddycarver
Copy link
Contributor

Backport the reattach-based binary acceptance testing mode introduced in
v2 to our v1 branch. It will only be enabled if TF_ACC_REATTACH is set
to 1 and binary acceptance testing is used.

Backport the reattach-based binary acceptance testing mode introduced in
v2 to our v1 branch. It will only be enabled if TF_ACC_REATTACH is set
to 1 _and_ binary acceptance testing is used.
@paddycarver paddycarver added the enhancement New feature or request label Aug 10, 2020
@paddycarver paddycarver requested a review from a team August 10, 2020 13:51
@paddycarver
Copy link
Contributor Author

In theory this should be a backwards-compatible change, but I'd love if reviewers evaluated with an eye to that.

Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this change is backwards compatible (emitting the extra debug log line if UseBinaryDriver is called).
Need to release v2 of terraform-plugin-test before merging.

@kmoe
Copy link
Member

kmoe commented Aug 10, 2020

Also, as the test/vet failures indicate, the addition of Errorf %w ends our support for Go 1.12. This is in accordance with our policy of supporting the last two Go versions (1.14 and 1.13), so you may want to update CircleCI to use a Go 1.13 container.

Switch the %w for %v in fmt.Errorf.
@paddycarver
Copy link
Contributor Author

I opted to keep 1.12 support for ease of upgrade, because the feature differentiation wasn't that important. Also, the Azure team helpfully verified that this works as expected in their test runs.

@paddycarver paddycarver merged commit 51d4883 into v1-maint Aug 19, 2020
@paddycarver paddycarver deleted the paddy_reattach_backport branch August 19, 2020 16:46
@ghost
Copy link

ghost commented Oct 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants