SNS HTTP subscription doesn't work with password containing the character "!"

[ghost]

This issue was originally opened by @fabbrimichele as hashicorp/terraform#23232. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Terraform Version

Terraform v0.12.12

Terraform Configuration Files

resource "aws_sns_topic_subscription" "batch_optimisation_http" {
  topic_arn = aws_sns_topic.topic1.arn
  endpoint = "https://user1:password1@service.domain.de/endpoint"
  protocol = "https"
  endpoint_auto_confirms = true
}

Debug Output

Crash Output

Expected Behavior

Terraform should find the subscription and complete the deploy.

Actual Behavior

Terraform can't find the subscription because of the "!" in the password and the deploy process fails.

Steps to Reproduce

1. terraform init
2. terraform apply

Additional Context

It seems the code that retrieves the subscriptions created for SNS is not working properly when the password contains an exclamation mark. Probably the regular expression used for finding subscriptions with user and password is not correct.

References

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[justinretzolk]

Hey @fabbrimichele 👋 Thank you for taking the time to file this issue! Given that there's been a number of AWS provider releases since you initially filed it, can you confirm whether you're still experiencing this behavior?