Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_launch_configuration: it will be good to have arn on terraform state file #10858

Closed
priguha93 opened this issue Nov 13, 2019 · 3 comments · Fixed by #11416
Closed

aws_launch_configuration: it will be good to have arn on terraform state file #10858

priguha93 opened this issue Nov 13, 2019 · 3 comments · Fixed by #11416
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Milestone

Comments

@priguha93
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

LaunchConfigurationARN isn't showing up on the terraform state file, although its returned by describe-launch-configurations call. It will be good to have it on the state file too.

New or Affected Resource(s)

  • aws_launch_configuration

Potential Terraform Configuration

resource "aws_launch_configuration" "foobar" {
  name_prefix         = "config"
  image_id      = "${aws_ami.example.id}"
  instance_type = "t2.micro"
  root_block_device {
    delete_on_termination = false
    encrypted = true
  }
}

resource "aws_ami" "example" {
  name                = "terraform-example"
  virtualization_type = "hvm"
  root_device_name    = "/dev/sda1"
  ena_support = true
  architecture = "x86_64"
  sriov_net_support  = "simple"
  ebs_block_device {
    device_name = "/dev/sda1"
    snapshot_id = "snap-097268252a2890bea"
    volume_size = 8
    volume_type = "io1"
    iops = 300
    delete_on_termination = true
  }
  ephemeral_block_device {
    device_name = "/dev/xvda"
    virtual_name = "ephemeral1"
  }
}

References

  • #0000
@priguha93 priguha93 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 13, 2019
@ghost ghost added service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. labels Nov 13, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 13, 2019
@gdavison gdavison added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. size/XS Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 13, 2019
@bflad bflad added this to the v2.44.0 milestone Jan 2, 2020
@bflad
Copy link
Contributor

bflad commented Jan 2, 2020

Support for the arn attribute in the aws_launch_configuration resource and data source has been merged and will release with version 2.44.0 of the Terraform AWS Provider, next Thursday. Thanks to @thatderek for the implementation. 👍

@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants