Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set Additional Settings while setting up a Kinesis trigger to Lambda using aws_lambda_event_source_mapping #11386

Closed
vidyakacquia opened this issue Dec 20, 2019 · 4 comments · Fixed by #11100
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Milestone

Comments

@vidyakacquia
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS provides the "Additional Settings" option while creating a Kinesis trigger to Lambda as below:
Screen Shot 2019-12-20 at 20 51 14

There are no documents available in Terraform, which describes the config to include the same. The goal is to include the option provided by AWS.

New or Affected Resource(s)

aws_lambda_event_source_mapping

Potential Terraform Configuration

resource "aws_cloudwatch_event_target" "event_target" {
  target_id  = var.target_id
  depends_on = [aws_lambda_function.Kinesislambdaprocess]
  rule       = aws_cloudwatch_event_rule.cw_event_rule.name
  arn        = aws_lambda_function.Kinesislambdaprocess.arn
 additional_settings {
    retry_attempts = 3
    maximum_age_of_record = 1000
 }
}

References

Could not find any.

@vidyakacquia vidyakacquia added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 20, 2019
@ghost ghost added service/cloudwatchevents service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/lambda Issues and PRs that pertain to the lambda service. labels Dec 20, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 20, 2019
@bflad
Copy link
Contributor

bflad commented Dec 20, 2019

It appears that while we do not have a feature request for this at the moment (this issue can serve as that), there is an open pull request that should cover this functionality here: #11100 👍

@bflad
Copy link
Contributor

bflad commented Feb 21, 2020

Support for the additional aws_lambda_event_source_mapping arguments has been merged and will release with version 2.51.0 of the Terraform AWS Provider, end of next week. Thanks to @kostas-theo for the implementation. 👍

@ghost
Copy link

ghost commented Feb 28, 2020

This has been released in version 2.51.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
2 participants