Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_amplify_domain_association #11938

Merged
merged 9 commits into from
Jun 3, 2021
Merged

New Resource: aws_amplify_domain_association #11938

merged 9 commits into from
Jun 3, 2021

Conversation

k24d
Copy link
Contributor

@k24d k24d commented Feb 6, 2020 •
edited by ewbankkit

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6917

AWS Amplify service client has been merged by #9874.
Before merging this PR, #11937 must be merged. After then, I'll run git rebase for this branch.

Release note for CHANGELOG:

New Resource: aws_amplify_domain_association

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyDomainAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyDomainAssociation -timeout 120m
=== RUN   TestAccAWSAmplifyDomainAssociation_basic
=== PAUSE TestAccAWSAmplifyDomainAssociation_basic
=== CONT  TestAccAWSAmplifyDomainAssociation_basic
--- PASS: TestAccAWSAmplifyDomainAssociation_basic (24.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.365s

@k24d k24d requested a review from a team February 6, 2020 16:29
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. service/amplify Issues and PRs that pertain to the amplify service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 6, 2020
This was referenced Feb 6, 2020
Merged
Closed
@teamterraform

This comment has been minimized.

Sign in to view
Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 3, 2021
@ewbankkit ewbankkit force-pushed the f-amplify-domain-association branch from 618d6af to c2d6be3 Compare June 3, 2021 13:20
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Jun 3, 2021
@ewbankkit ewbankkit self-assigned this Jun 3, 2021
@ewbankkit ewbankkit changed the title [WIP] New Resource: aws_amplify_domain_association New Resource: aws_amplify_domain_association Jun 3, 2021
@ewbankkit
Fix terrafmt error.
6dccac6
@ewbankkit
r/aws_amplify_domain_association: Avoid 'BadRequestException: Cannot …
459b930 
…update domain while the domain is in PENDING_VERIFICATION status.'.
ewbankkit
ewbankkit approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% AMPLIFY_DOMAIN_NAME=<domain name> make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/DomainAssociation/basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/DomainAssociation/basic -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/DomainAssociation
=== RUN   TestAccAWSAmplify_serial/DomainAssociation/basic
=== PAUSE TestAccAWSAmplify_serial/DomainAssociation/basic
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/basic
--- PASS: TestAccAWSAmplify_serial (66.59s)
    --- PASS: TestAccAWSAmplify_serial/DomainAssociation (0.00s)
        --- PASS: TestAccAWSAmplify_serial/DomainAssociation/basic (66.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.712s
% AMPLIFY_DOMAIN_NAME=<domain name> make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/DomainAssociation/disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/DomainAssociation/disappears -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/DomainAssociation
=== RUN   TestAccAWSAmplify_serial/DomainAssociation/disappears
=== PAUSE TestAccAWSAmplify_serial/DomainAssociation/disappears
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/disappears
--- PASS: TestAccAWSAmplify_serial (55.95s)
    --- PASS: TestAccAWSAmplify_serial/DomainAssociation (0.00s)
        --- PASS: TestAccAWSAmplify_serial/DomainAssociation/disappears (55.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.276s
% AMPLIFY_DOMAIN_NAME=<domain name> make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/DomainAssociation/update'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/DomainAssociation/update -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/DomainAssociation
=== RUN   TestAccAWSAmplify_serial/DomainAssociation/update
=== PAUSE TestAccAWSAmplify_serial/DomainAssociation/update
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/update
--- PASS: TestAccAWSAmplify_serial (260.33s)
    --- PASS: TestAccAWSAmplify_serial/DomainAssociation (0.00s)
        --- PASS: TestAccAWSAmplify_serial/DomainAssociation/update (260.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	263.696s
GovCloud
% AMPLIFY_DOMAIN_NAME=example.com make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/DomainAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/DomainAssociation -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/DomainAssociation
=== RUN   TestAccAWSAmplify_serial/DomainAssociation/basic
=== PAUSE TestAccAWSAmplify_serial/DomainAssociation/basic
=== RUN   TestAccAWSAmplify_serial/DomainAssociation/disappears
=== PAUSE TestAccAWSAmplify_serial/DomainAssociation/disappears
=== RUN   TestAccAWSAmplify_serial/DomainAssociation/update
=== PAUSE TestAccAWSAmplify_serial/DomainAssociation/update
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/basic
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/update
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/disappears
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/basic
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/update
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/DomainAssociation/disappears
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
--- PASS: TestAccAWSAmplify_serial (1.46s)
    --- PASS: TestAccAWSAmplify_serial/DomainAssociation (0.00s)
        --- SKIP: TestAccAWSAmplify_serial/DomainAssociation/basic (1.45s)
        --- SKIP: TestAccAWSAmplify_serial/DomainAssociation/update (1.45s)
        --- SKIP: TestAccAWSAmplify_serial/DomainAssociation/disappears (1.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.552s

@ewbankkit ewbankkit merged commit 6be9bc9 into hashicorp:main Jun 3, 2021
@github-actions github-actions bot added this to the v3.44.0 milestone Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/amplify Issues and PRs that pertain to the amplify service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.44.0
Development

Successfully merging this pull request may close these issues.

AWS Amplify Console Resources
3 participants
@k24d @teamterraform @ewbankkit