Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudfront_field_level_encryption_profile - new resource #12509

Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4098.
Closes #4097.
Closes #21493.
Closes #21397.
Closes #20594.
Closes #20589.
Closes #19780.
Closes #20870.

Release note for CHANGELOG:

resource_aws_cloudfront_field_level_encryption_profile: add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudfrontFieldLevelEncryptionProfile_'
--- PASS: TestAccAWSCloudfrontFieldLevelEncryptionProfile_disappears (35.31s)
--- PASS: TestAccAWSCloudfrontFieldLevelEncryptionProfile_basic (70.00s)

@DrFaust92 DrFaust92 requested a review from a team March 23, 2020 23:12
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 23, 2020
@DrFaust92 DrFaust92 changed the title [WIP]Support CloudFront Field Level Encryption Profile Support CloudFront Field Level Encryption Profile Mar 24, 2020
@DrFaust92 DrFaust92 changed the title Support CloudFront Field Level Encryption Profile [WIP]Support CloudFront Field Level Encryption Profile Mar 24, 2020
@DrFaust92 DrFaust92 changed the title [WIP]Support CloudFront Field Level Encryption Profile Support CloudFront Field Level Encryption Profile Mar 24, 2020
@DrFaust92
Copy link
Collaborator Author

@bflad , this seems to stuck in travis for weeks. is it possible to cancel and retry?

@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_profile branch from 11979ce to eb38052 Compare May 22, 2020 15:57
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label May 22, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2020
@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_profile branch from 39c1627 to 44b5eb7 Compare September 4, 2020 11:26
Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_profile branch from 1ef26aa to 42946b6 Compare March 27, 2021 19:12
@nomeelnoj
Copy link

Looks like its been a while since this has been worked on. Any chance we could get this through relatively soon?

@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_profile branch from c59f406 to c4ef607 Compare May 25, 2021 08:24
@DrFaust92 DrFaust92 changed the title Support CloudFront Field Level Encryption Profile r/aws_cloudfront_field_level_encryption_profile - new resource Sep 10, 2021
@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_profile branch from c4ef607 to d44be57 Compare September 10, 2021 16:53
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

r/aws_cloudfront_field_level_encryption_profile: Add sweeper.

Acceptance test output:

% make sweep SWEEPARGS=-sweep-run=aws_cloudfront_field_level_encryption_profile SWEEP=us-west-2
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_cloudfront_field_level_encryption_profile -timeout 60m
2021/11/09 13:42:54 [DEBUG] Running Sweepers for region (us-west-2):
2021/11/09 13:42:54 [DEBUG] Running Sweeper (aws_cloudfront_field_level_encryption_config) in region (us-west-2)
2021/11/09 13:42:54 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/09 13:42:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/09 13:42:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/09 13:42:55 [DEBUG] Waiting for state to become: [success]
2021/11/09 13:42:55 [DEBUG] Deleting CloudFront Field-level Encryption Config: (C18XZXTNY6SUCE)
2021/11/09 13:42:55 [DEBUG] Completed Sweeper (aws_cloudfront_field_level_encryption_config) in region (us-west-2) in 1.23013676s
2021/11/09 13:42:55 [DEBUG] Sweeper (aws_cloudfront_field_level_encryption_profile) has dependency (aws_cloudfront_field_level_encryption_config), running..
2021/11/09 13:42:55 [DEBUG] Sweeper (aws_cloudfront_field_level_encryption_config) already ran in region (us-west-2)
2021/11/09 13:42:55 [DEBUG] Running Sweeper (aws_cloudfront_field_level_encryption_profile) in region (us-west-2)
2021/11/09 13:42:56 [DEBUG] Waiting for state to become: [success]
2021/11/09 13:42:56 [DEBUG] Deleting CloudFront Field-level Encryption Profile: (P2F7AY3Y8EBJ5R)
2021/11/09 13:42:56 [DEBUG] Completed Sweeper (aws_cloudfront_field_level_encryption_profile) in region (us-west-2) in 331.21652ms
2021/11/09 13:42:56 Completed Sweepers for region (us-west-2) in 1.561689507s
2021/11/09 13:42:56 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_cloudfront_field_level_encryption_config
	- aws_cloudfront_field_level_encryption_profile
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	4.665s
Acceptance test output:

% make sweep SWEEPARGS=-sweep-run=aws_cloudfront_response_headers_policy SWEEP=us-west-2
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_cloudfront_response_headers_policy -timeout 60m
2021/11/09 13:58:10 [DEBUG] Running Sweepers for region (us-west-2):
2021/11/09 13:58:10 [DEBUG] Running Sweeper (aws_cloudfront_response_headers_policy) in region (us-west-2)
2021/11/09 13:58:10 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/09 13:58:10 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/09 13:58:11 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/09 13:58:12 [DEBUG] Waiting for state to become: [success]
2021/11/09 13:58:12 [DEBUG] Waiting for state to become: [success]
2021/11/09 13:58:12 [DEBUG] Waiting for state to become: [success]
2021/11/09 13:58:12 [DEBUG] Deleting CloudFront Response Headers Policy: (824aa9de-447a-446b-a641-d38e5a5ae606)
2021/11/09 13:58:12 [DEBUG] Deleting CloudFront Response Headers Policy: (6d417b5d-913d-48cb-87aa-73b56e9c58b8)
2021/11/09 13:58:12 [DEBUG] Deleting CloudFront Response Headers Policy: (95fca78d-d257-4207-9e19-abae89465a4b)
2021/11/09 13:58:12 [DEBUG] Completed Sweeper (aws_cloudfront_response_headers_policy) in region (us-west-2) in 1.508706063s
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontCachePolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontCachePolicy_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicy_basic
=== PAUSE TestAccCloudFrontCachePolicy_basic
=== RUN   TestAccCloudFrontCachePolicy_update
=== PAUSE TestAccCloudFrontCachePolicy_update
=== RUN   TestAccCloudFrontCachePolicy_noneBehavior
=== PAUSE TestAccCloudFrontCachePolicy_noneBehavior
=== CONT  TestAccCloudFrontCachePolicy_basic
=== CONT  TestAccCloudFrontCachePolicy_noneBehavior
=== CONT  TestAccCloudFrontCachePolicy_update
--- PASS: TestAccCloudFrontCachePolicy_noneBehavior (14.04s)
--- PASS: TestAccCloudFrontCachePolicy_basic (14.13s)
--- PASS: TestAccCloudFrontCachePolicy_update (22.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	25.588s
…iguration function names

Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontResponseHeadersPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontResponseHeadersPolicy_ -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
--- PASS: TestAccCloudFrontResponseHeadersPolicy_disappears (10.50s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig (13.90s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (21.05s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CorsConfig (21.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	25.076s
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontCachePolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontCachePolicy_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicy_basic
=== PAUSE TestAccCloudFrontCachePolicy_basic
=== RUN   TestAccCloudFrontCachePolicy_update
=== PAUSE TestAccCloudFrontCachePolicy_update
=== RUN   TestAccCloudFrontCachePolicy_noneBehavior
=== PAUSE TestAccCloudFrontCachePolicy_noneBehavior
=== CONT  TestAccCloudFrontCachePolicy_basic
=== CONT  TestAccCloudFrontCachePolicy_noneBehavior
=== CONT  TestAccCloudFrontCachePolicy_update
--- PASS: TestAccCloudFrontCachePolicy_noneBehavior (12.64s)
--- PASS: TestAccCloudFrontCachePolicy_basic (12.73s)
--- PASS: TestAccCloudFrontCachePolicy_update (20.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	24.125s
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontCachePolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontCachePolicy_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicy_basic
=== PAUSE TestAccCloudFrontCachePolicy_basic
=== RUN   TestAccCloudFrontCachePolicy_disappears
=== PAUSE TestAccCloudFrontCachePolicy_disappears
=== RUN   TestAccCloudFrontCachePolicy_Items
=== PAUSE TestAccCloudFrontCachePolicy_Items
=== CONT  TestAccCloudFrontCachePolicy_basic
=== CONT  TestAccCloudFrontCachePolicy_Items
=== CONT  TestAccCloudFrontCachePolicy_disappears
--- PASS: TestAccCloudFrontCachePolicy_disappears (9.76s)
--- PASS: TestAccCloudFrontCachePolicy_basic (12.65s)
--- PASS: TestAccCloudFrontCachePolicy_Items (20.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	24.098s
…iciesPages'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontResponseHeadersPolicyDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontResponseHeadersPolicyDataSource_ -timeout 180m
=== RUN   TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== PAUSE TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicyDataSource_basic
--- PASS: TestAccCloudFrontResponseHeadersPolicyDataSource_basic (10.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	14.427s
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontCachePolicyDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontCachePolicyDataSource_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicyDataSource_basic
=== PAUSE TestAccCloudFrontCachePolicyDataSource_basic
=== CONT  TestAccCloudFrontCachePolicyDataSource_basic
--- PASS: TestAccCloudFrontCachePolicyDataSource_basic (13.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	16.879s
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Nov 9, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Nov 9, 2021
…yID'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontOriginRequestPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontOriginRequestPolicy_ -timeout 180m
=== RUN   TestAccCloudFrontOriginRequestPolicy_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicy_basic
=== RUN   TestAccCloudFrontOriginRequestPolicy_update
=== PAUSE TestAccCloudFrontOriginRequestPolicy_update
=== RUN   TestAccCloudFrontOriginRequestPolicy_noneBehavior
=== PAUSE TestAccCloudFrontOriginRequestPolicy_noneBehavior
=== CONT  TestAccCloudFrontOriginRequestPolicy_basic
=== CONT  TestAccCloudFrontOriginRequestPolicy_noneBehavior
=== CONT  TestAccCloudFrontOriginRequestPolicy_update
--- PASS: TestAccCloudFrontOriginRequestPolicy_noneBehavior (15.62s)
--- PASS: TestAccCloudFrontOriginRequestPolicy_basic (15.94s)
--- PASS: TestAccCloudFrontOriginRequestPolicy_update (22.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	26.110s
Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontOriginRequestPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontOriginRequestPolicy_ -timeout 180m
=== RUN   TestAccCloudFrontOriginRequestPolicy_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicy_basic
=== RUN   TestAccCloudFrontOriginRequestPolicy_disappears
=== PAUSE TestAccCloudFrontOriginRequestPolicy_disappears
=== RUN   TestAccCloudFrontOriginRequestPolicy_Items
=== PAUSE TestAccCloudFrontOriginRequestPolicy_Items
=== CONT  TestAccCloudFrontOriginRequestPolicy_basic
=== CONT  TestAccCloudFrontOriginRequestPolicy_Items
=== CONT  TestAccCloudFrontOriginRequestPolicy_disappears
--- PASS: TestAccCloudFrontOriginRequestPolicy_disappears (9.78s)
--- PASS: TestAccCloudFrontOriginRequestPolicy_basic (12.87s)
--- PASS: TestAccCloudFrontOriginRequestPolicy_Items (20.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	23.939s
…sPages'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontOriginRequestPolicyDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontOriginRequestPolicyDataSource_ -timeout 180m
=== RUN   TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== CONT  TestAccCloudFrontOriginRequestPolicyDataSource_basic
--- PASS: TestAccCloudFrontOriginRequestPolicyDataSource_basic (11.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	14.494s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontMonitoringSubscription_\|TestAccCloudFrontRealtimeLogConfig_\|TestAccCloudFrontFieldLevelEncryptionProfile_\|TestAccCloudFrontFieldLevelEncryptionConfig_\|TestAccCloudFrontCachePolicy_\|TestAccCloudFrontResponseHeadersPolicyDataSource_\|TestAccCloudFrontCachePolicyDataSource_\|TestAccCloudFrontOriginRequestPolicy_\|TestAccCloudFrontOriginRequestPolicyDataSource_\|TestAccCloudFrontResponseHeadersPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontMonitoringSubscription_\|TestAccCloudFrontRealtimeLogConfig_\|TestAccCloudFrontFieldLevelEncryptionProfile_\|TestAccCloudFrontFieldLevelEncryptionConfig_\|TestAccCloudFrontCachePolicy_\|TestAccCloudFrontResponseHeadersPolicyDataSource_\|TestAccCloudFrontCachePolicyDataSource_\|TestAccCloudFrontOriginRequestPolicy_\|TestAccCloudFrontOriginRequestPolicyDataSource_\|TestAccCloudFrontResponseHeadersPolicy_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicyDataSource_basic
=== PAUSE TestAccCloudFrontCachePolicyDataSource_basic
=== RUN   TestAccCloudFrontCachePolicy_basic
=== PAUSE TestAccCloudFrontCachePolicy_basic
=== RUN   TestAccCloudFrontCachePolicy_disappears
=== PAUSE TestAccCloudFrontCachePolicy_disappears
=== RUN   TestAccCloudFrontCachePolicy_Items
=== PAUSE TestAccCloudFrontCachePolicy_Items
=== RUN   TestAccCloudFrontFieldLevelEncryptionConfig_basic
=== PAUSE TestAccCloudFrontFieldLevelEncryptionConfig_basic
=== RUN   TestAccCloudFrontFieldLevelEncryptionConfig_disappears
=== PAUSE TestAccCloudFrontFieldLevelEncryptionConfig_disappears
=== RUN   TestAccCloudFrontFieldLevelEncryptionProfile_basic
=== PAUSE TestAccCloudFrontFieldLevelEncryptionProfile_basic
=== RUN   TestAccCloudFrontFieldLevelEncryptionProfile_disappears
=== PAUSE TestAccCloudFrontFieldLevelEncryptionProfile_disappears
=== RUN   TestAccCloudFrontMonitoringSubscription_basic
=== PAUSE TestAccCloudFrontMonitoringSubscription_basic
=== RUN   TestAccCloudFrontMonitoringSubscription_disappears
=== PAUSE TestAccCloudFrontMonitoringSubscription_disappears
=== RUN   TestAccCloudFrontMonitoringSubscription_update
=== PAUSE TestAccCloudFrontMonitoringSubscription_update
=== RUN   TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== RUN   TestAccCloudFrontOriginRequestPolicy_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicy_basic
=== RUN   TestAccCloudFrontOriginRequestPolicy_disappears
=== PAUSE TestAccCloudFrontOriginRequestPolicy_disappears
=== RUN   TestAccCloudFrontOriginRequestPolicy_Items
=== PAUSE TestAccCloudFrontOriginRequestPolicy_Items
=== RUN   TestAccCloudFrontRealtimeLogConfig_basic
=== PAUSE TestAccCloudFrontRealtimeLogConfig_basic
=== RUN   TestAccCloudFrontRealtimeLogConfig_disappears
=== PAUSE TestAccCloudFrontRealtimeLogConfig_disappears
=== RUN   TestAccCloudFrontRealtimeLogConfig_updates
=== PAUSE TestAccCloudFrontRealtimeLogConfig_updates
=== RUN   TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== PAUSE TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontCachePolicyDataSource_basic
=== CONT  TestAccCloudFrontOriginRequestPolicy_basic
=== CONT  TestAccCloudFrontFieldLevelEncryptionConfig_basic
=== CONT  TestAccCloudFrontFieldLevelEncryptionProfile_basic
=== CONT  TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== CONT  TestAccCloudFrontMonitoringSubscription_update
=== CONT  TestAccCloudFrontMonitoringSubscription_disappears
=== CONT  TestAccCloudFrontMonitoringSubscription_basic
=== CONT  TestAccCloudFrontFieldLevelEncryptionProfile_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== CONT  TestAccCloudFrontCachePolicy_Items
=== CONT  TestAccCloudFrontFieldLevelEncryptionConfig_disappears
=== CONT  TestAccCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== CONT  TestAccCloudFrontRealtimeLogConfig_disappears
=== CONT  TestAccCloudFrontRealtimeLogConfig_basic
=== CONT  TestAccCloudFrontCachePolicy_disappears
--- PASS: TestAccCloudFrontOriginRequestPolicy_basic (28.53s)
=== CONT  TestAccCloudFrontOriginRequestPolicy_Items
--- PASS: TestAccCloudFrontCachePolicyDataSource_basic (28.97s)
=== CONT  TestAccCloudFrontCachePolicy_basic
--- PASS: TestAccCloudFrontOriginRequestPolicyDataSource_basic (29.29s)
=== CONT  TestAccCloudFrontOriginRequestPolicy_disappears
--- PASS: TestAccCloudFrontCachePolicy_disappears (30.31s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_disappears (33.13s)
--- PASS: TestAccCloudFrontFieldLevelEncryptionProfile_disappears (34.64s)
--- PASS: TestAccCloudFrontFieldLevelEncryptionConfig_disappears (35.20s)
--- PASS: TestAccCloudFrontResponseHeadersPolicyDataSource_basic (35.99s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig (37.93s)
--- PASS: TestAccCloudFrontOriginRequestPolicy_disappears (15.42s)
--- PASS: TestAccCloudFrontCachePolicy_Items (46.72s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (48.64s)
--- PASS: TestAccCloudFrontResponseHeadersPolicy_CorsConfig (48.83s)
--- PASS: TestAccCloudFrontCachePolicy_basic (20.02s)
--- PASS: TestAccCloudFrontFieldLevelEncryptionProfile_basic (50.13s)
--- PASS: TestAccCloudFrontFieldLevelEncryptionConfig_basic (52.68s)
--- PASS: TestAccCloudFrontOriginRequestPolicy_Items (29.60s)
--- PASS: TestAccCloudFrontRealtimeLogConfig_disappears (66.57s)
--- PASS: TestAccCloudFrontRealtimeLogConfig_basic (68.42s)
--- PASS: TestAccCloudFrontRealtimeLogConfig_updates (115.59s)
--- PASS: TestAccCloudFrontMonitoringSubscription_disappears (320.06s)
--- PASS: TestAccCloudFrontMonitoringSubscription_basic (329.14s)
--- PASS: TestAccCloudFrontMonitoringSubscription_update (335.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	338.549s
GovCloud
% make testacc PKG_NAME=internal/service/cloudfront TESTARGS='-run=TestAccCloudFrontMonitoringSubscription_\|TestAccCloudFrontRealtimeLogConfig_\|TestAccCloudFrontFieldLevelEncryptionProfile_\|TestAccCloudFrontFieldLevelEncryptionConfig_\|TestAccCloudFrontCachePolicy_\|TestAccCloudFrontResponseHeadersPolicyDataSource_\|TestAccCloudFrontCachePolicyDataSource_\|TestAccCloudFrontOriginRequestPolicy_\|TestAccCloudFrontOriginRequestPolicyDataSource_\|TestAccCloudFrontResponseHeadersPolicy_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontMonitoringSubscription_\|TestAccCloudFrontRealtimeLogConfig_\|TestAccCloudFrontFieldLevelEncryptionProfile_\|TestAccCloudFrontFieldLevelEncryptionConfig_\|TestAccCloudFrontCachePolicy_\|TestAccCloudFrontResponseHeadersPolicyDataSource_\|TestAccCloudFrontCachePolicyDataSource_\|TestAccCloudFrontOriginRequestPolicy_\|TestAccCloudFrontOriginRequestPolicyDataSource_\|TestAccCloudFrontResponseHeadersPolicy_ -timeout 180m
=== RUN   TestAccCloudFrontCachePolicyDataSource_basic
=== PAUSE TestAccCloudFrontCachePolicyDataSource_basic
=== RUN   TestAccCloudFrontCachePolicy_basic
=== PAUSE TestAccCloudFrontCachePolicy_basic
=== RUN   TestAccCloudFrontCachePolicy_disappears
=== PAUSE TestAccCloudFrontCachePolicy_disappears
=== RUN   TestAccCloudFrontCachePolicy_Items
=== PAUSE TestAccCloudFrontCachePolicy_Items
=== RUN   TestAccCloudFrontFieldLevelEncryptionConfig_basic
=== PAUSE TestAccCloudFrontFieldLevelEncryptionConfig_basic
=== RUN   TestAccCloudFrontFieldLevelEncryptionConfig_disappears
=== PAUSE TestAccCloudFrontFieldLevelEncryptionConfig_disappears
=== RUN   TestAccCloudFrontFieldLevelEncryptionProfile_basic
=== PAUSE TestAccCloudFrontFieldLevelEncryptionProfile_basic
=== RUN   TestAccCloudFrontFieldLevelEncryptionProfile_disappears
=== PAUSE TestAccCloudFrontFieldLevelEncryptionProfile_disappears
=== RUN   TestAccCloudFrontMonitoringSubscription_basic
=== PAUSE TestAccCloudFrontMonitoringSubscription_basic
=== RUN   TestAccCloudFrontMonitoringSubscription_disappears
=== PAUSE TestAccCloudFrontMonitoringSubscription_disappears
=== RUN   TestAccCloudFrontMonitoringSubscription_update
=== PAUSE TestAccCloudFrontMonitoringSubscription_update
=== RUN   TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== RUN   TestAccCloudFrontOriginRequestPolicy_basic
=== PAUSE TestAccCloudFrontOriginRequestPolicy_basic
=== RUN   TestAccCloudFrontOriginRequestPolicy_disappears
=== PAUSE TestAccCloudFrontOriginRequestPolicy_disappears
=== RUN   TestAccCloudFrontOriginRequestPolicy_Items
=== PAUSE TestAccCloudFrontOriginRequestPolicy_Items
=== RUN   TestAccCloudFrontRealtimeLogConfig_basic
=== PAUSE TestAccCloudFrontRealtimeLogConfig_basic
=== RUN   TestAccCloudFrontRealtimeLogConfig_disappears
=== PAUSE TestAccCloudFrontRealtimeLogConfig_disappears
=== RUN   TestAccCloudFrontRealtimeLogConfig_updates
=== PAUSE TestAccCloudFrontRealtimeLogConfig_updates
=== RUN   TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== PAUSE TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== RUN   TestAccCloudFrontResponseHeadersPolicy_disappears
=== PAUSE TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontCachePolicyDataSource_basic
=== CONT  TestAccCloudFrontOriginRequestPolicy_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicyDataSource_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CorsConfig
=== CONT  TestAccCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccCloudFrontRealtimeLogConfig_disappears
=== CONT  TestAccCloudFrontRealtimeLogConfig_basic
=== CONT  TestAccCloudFrontOriginRequestPolicy_Items
=== CONT  TestAccCloudFrontFieldLevelEncryptionProfile_basic
=== CONT  TestAccCloudFrontOriginRequestPolicyDataSource_basic
=== CONT  TestAccCloudFrontMonitoringSubscription_update
=== CONT  TestAccCloudFrontMonitoringSubscription_disappears
=== CONT  TestAccCloudFrontMonitoringSubscription_basic
=== CONT  TestAccCloudFrontOriginRequestPolicy_disappears
=== CONT  TestAccCloudFrontCachePolicy_Items
=== CONT  TestAccCloudFrontFieldLevelEncryptionConfig_disappears
=== CONT  TestAccCloudFrontFieldLevelEncryptionProfile_disappears
=== CONT  TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
=== CONT  TestAccCloudFrontFieldLevelEncryptionConfig_basic
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
=== CONT  TestAccCloudFrontCachePolicyDataSource_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontOriginRequestPolicy_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontOriginRequestPolicy_basic (1.44s)
=== CONT  TestAccCloudFrontCachePolicy_basic
--- SKIP: TestAccCloudFrontCachePolicyDataSource_basic (1.44s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CorsConfig
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontResponseHeadersPolicy_CorsConfig (1.44s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
=== CONT  TestAccCloudFrontOriginRequestPolicy_Items
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontOriginRequestPolicy_Items (1.44s)
=== CONT  TestAccCloudFrontCachePolicy_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontCachePolicy_basic (0.00s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontResponseHeadersPolicy_CustomHeadersConfig (0.00s)
=== CONT  TestAccCloudFrontCachePolicy_disappears
=== CONT  TestAccCloudFrontRealtimeLogConfig_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
=== CONT  TestAccCloudFrontOriginRequestPolicyDataSource_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontRealtimeLogConfig_basic (1.44s)
--- SKIP: TestAccCloudFrontOriginRequestPolicyDataSource_basic (1.44s)
=== CONT  TestAccCloudFrontFieldLevelEncryptionProfile_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontFieldLevelEncryptionProfile_basic (1.44s)
=== CONT  TestAccCloudFrontMonitoringSubscription_update
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontMonitoringSubscription_update (1.44s)
=== CONT  TestAccCloudFrontResponseHeadersPolicyDataSource_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontResponseHeadersPolicyDataSource_basic (1.44s)
=== CONT  TestAccCloudFrontRealtimeLogConfig_updates
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontRealtimeLogConfig_updates (1.44s)
=== CONT  TestAccCloudFrontRealtimeLogConfig_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontRealtimeLogConfig_disappears (1.44s)
=== CONT  TestAccCloudFrontMonitoringSubscription_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontMonitoringSubscription_disappears (1.44s)
=== CONT  TestAccCloudFrontCachePolicy_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontCachePolicy_disappears (0.00s)
=== CONT  TestAccCloudFrontMonitoringSubscription_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontMonitoringSubscription_basic (1.44s)
=== CONT  TestAccCloudFrontOriginRequestPolicy_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontOriginRequestPolicy_disappears (1.44s)
=== CONT  TestAccCloudFrontFieldLevelEncryptionProfile_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontFieldLevelEncryptionProfile_disappears (1.44s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontResponseHeadersPolicy_SecurityHeadersConfig (1.44s)
=== CONT  TestAccCloudFrontCachePolicy_Items
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontCachePolicy_Items (1.44s)
=== CONT  TestAccCloudFrontResponseHeadersPolicy_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontResponseHeadersPolicy_disappears (1.44s)
=== CONT  TestAccCloudFrontFieldLevelEncryptionConfig_basic
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontFieldLevelEncryptionConfig_basic (1.44s)
=== CONT  TestAccCloudFrontFieldLevelEncryptionConfig_disappears
    acctest.go:593: skipping tests; partition aws-us-gov does not support cloudfront service
--- SKIP: TestAccCloudFrontFieldLevelEncryptionConfig_disappears (1.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	4.582s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f9171da into hashicorp:main Nov 10, 2021
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 10, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/cloudfront_field_level_encryption_profile branch November 11, 2021 23:40
@theherk
Copy link
Contributor

theherk commented Nov 16, 2021

@DrFaust92 and @ewbankkit: I'm thinking #21788 may be related to this, but I am not sure. Does this seem possible to you?

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
5 participants