r/sns_topic_policy - add disappears + refactor tests

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13826

Release note for CHANGELOG:

resource_aws_sns_topic_policy: add `owner` attribute
resource_aws_sns_topic_policy: add plan time validation to `arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSNSTopicPolicy_'
--- PASS: TestAccAWSSNSTopicPolicy_basic (50.74s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (73.65s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (30.39s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (41.43s)

[DrFaust92]

rebased

--- PASS: TestAccAWSSNSTopicPolicy_updated (87.13s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (36.46s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (45.35s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (87.13s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopicPolicy_'                                                                                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicPolicy_ -timeout 180m
=== RUN   TestAccAWSSNSTopicPolicy_basic
=== PAUSE TestAccAWSSNSTopicPolicy_basic
=== RUN   TestAccAWSSNSTopicPolicy_updated
=== PAUSE TestAccAWSSNSTopicPolicy_updated
=== RUN   TestAccAWSSNSTopicPolicy_disappears_topic
=== PAUSE TestAccAWSSNSTopicPolicy_disappears_topic
=== RUN   TestAccAWSSNSTopicPolicy_disappears
=== PAUSE TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_basic
=== CONT  TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_disappears_topic
=== CONT  TestAccAWSSNSTopicPolicy_updated
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (11.83s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (14.92s)
--- PASS: TestAccAWSSNSTopicPolicy_basic (16.74s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (26.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.334s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopicPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicPolicy_ -timeout 180m
=== RUN   TestAccAWSSNSTopicPolicy_basic
=== PAUSE TestAccAWSSNSTopicPolicy_basic
=== RUN   TestAccAWSSNSTopicPolicy_updated
=== PAUSE TestAccAWSSNSTopicPolicy_updated
=== RUN   TestAccAWSSNSTopicPolicy_disappears_topic
=== PAUSE TestAccAWSSNSTopicPolicy_disappears_topic
=== RUN   TestAccAWSSNSTopicPolicy_disappears
=== PAUSE TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_basic
=== CONT  TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_disappears_topic
=== CONT  TestAccAWSSNSTopicPolicy_updated
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (15.99s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (19.11s)
--- PASS: TestAccAWSSNSTopicPolicy_basic (20.55s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (34.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.339s

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.