Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/config_configuration_aggregator -remove toLower call when setting ID + disappears test #14247

Merged
merged 5 commits into from
Mar 25, 2021
Merged

r/config_configuration_aggregator -remove toLower call when setting ID + disappears test #14247

merged 5 commits into from
Mar 25, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 20, 2020 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11769
Closes #8432
Related #13826

Release note for CHANGELOG:

resource_aws_config_configuration_aggregator: allow name to have uppercase characters

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSConfigConfigurationAggregator_'

--- PASS: TestAccAWSConfigConfigurationAggregator_tags (111.49s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (43.38s)
--- PASS: TestAccAWSConfigConfigurationAggregator_disappears (36.07s)

    TestAccAWSConfigConfigurationAggregator_organization: provider_test.go:532: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (3.00s)
Test ignored.
    TestAccAWSConfigConfigurationAggregator_switch: provider_test.go:532: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (3.59s)
Test ignored.

Can't test org features

@DrFaust92 DrFaust92 requested a review from a team July 20, 2020 06:19
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 20, 2020
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Aug 27, 2020
@DrFaust92 DrFaust92 force-pushed the r/config_configuration_aggregator_lower branch from 400456f to 933d8a5 Compare August 27, 2020 20:22
@DrFaust92
Copy link
Collaborator Author

rebased:

--- PASS: TestAccAWSConfigConfigurationAggregator_tags (199.31s)
--- PASS: TestAccAWSConfigConfigurationAggregator_disappears (52.46s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (102.47s)

ewbankkit
ewbankkit approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

--- PASS: TestAccAWSConfigConfigurationAggregator_disappears (19.75s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (23.59s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (52.20s)

@DrFaust92 DrFaust92 force-pushed the r/config_configuration_aggregator_lower branch from 8f94f80 to f33fb2e Compare September 30, 2020 07:26
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@DrFaust92
fix setting id
512cbf7 
some refactor to tests and resource
added disappears test
remove hardcoded region from tests
@DrFaust92
upper case test
786addd
@DrFaust92
add comment
5cf57bd
@DrFaust92
lint
9c179d1
@DrFaust92
changelog
8be2d07
@DrFaust92 DrFaust92 force-pushed the r/config_configuration_aggregator_lower branch from ac859ae to 8be2d07 Compare February 12, 2021 07:57
@gdavison gdavison self-assigned this Mar 25, 2021
gdavison
gdavison approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (1.06s)
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (1.08s)
--- PASS: TestAccAWSConfigConfigurationAggregator_disappears (16.98s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (18.94s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (41.26s)

gdavison
gdavison approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (1.06s)
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (1.08s)
--- PASS: TestAccAWSConfigConfigurationAggregator_disappears (16.98s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (18.94s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (41.26s)

@gdavison gdavison merged commit f3e15b5 into hashicorp:main Mar 25, 2021
@github-actions github-actions bot added this to the v3.34.0 milestone Mar 25, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/config_configuration_aggregator_lower branch April 15, 2021 10:43
@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@gdavison gdavison

Labels
bug Addresses a defect in current functionality. service/configservice Issues and PRs that pertain to the configservice service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.34.0
3 participants
@DrFaust92 @gdavison @ewbankkit