Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter for onPremisesTagSet to codedeploy_deployment_group #14920

Open
stekern opened this issue Aug 31, 2020 · 0 comments 路 May be fixed by #22601
Open

Add parameter for onPremisesTagSet to codedeploy_deployment_group #14920

stekern opened this issue Aug 31, 2020 · 0 comments 路 May be fixed by #22601
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/deploy Issues and PRs that pertain to the deploy service.

Comments

@stekern
Copy link

stekern commented Aug 31, 2020

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_codedeploy_deployment_group resource does not currently have a parameter that corresponds to what the AWS API calls onPremisesTagSet (https://docs.aws.amazon.com/codedeploy/latest/APIReference/API_CreateDeploymentGroup.html#CodeDeploy-CreateDeploymentGroup-request-onPremisesTagSet).

From what I can tell, the this parameter is equivalent to ec2TagSet, which is already implemented in the resource, so it should not be that hard to adapt the existing code to also support this new parameter.

New or Affected Resource(s)

  • aws_codedeploy_deployment_group
@stekern stekern added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 31, 2020
@ghost ghost added the service/codedeploy label Aug 31, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 31, 2020
@gdavison gdavison added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2020
@nikhil-goenka nikhil-goenka mentioned this issue Sep 5, 2020
Closed
@ewbankkit ewbankkit added the service/deploy Issues and PRs that pertain to the deploy service. label Aug 4, 2022
This was referenced Aug 4, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/deploy Issues and PRs that pertain to the deploy service.
Projects
None yet
Milestone
No milestone
4 participants
@gdavison @ewbankkit @stekern @hc-github-team-terraform-aws