Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_amplify_app resource #15966

Merged
merged 30 commits into from
May 21, 2021
Merged

Add aws_amplify_app resource #15966

merged 30 commits into from
May 21, 2021

Conversation

ashishmohite
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6917 and #11928

AWS Amplify service client has been merged by #9874.

Release note for CHANGELOG:

New Resource: aws_amplify_app

Output from acceptance testing:

$ ╭─ashishmohite@Ashishs-MacBook-Pro ~/development/terraform-providers/terraform-provider-aws  ‹f-amplify-app*›
╰─$ export AWS_PROFILE=my-profile &&  make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSAmplifyApp -timeout 120m
=== RUN   TestAccAWSAmplifyApp_basic
=== PAUSE TestAccAWSAmplifyApp_basic
=== RUN   TestAccAWSAmplifyApp_rename
=== PAUSE TestAccAWSAmplifyApp_rename
=== RUN   TestAccAWSAmplifyApp_description
=== PAUSE TestAccAWSAmplifyApp_description
=== RUN   TestAccAWSAmplifyApp_repository
=== PAUSE TestAccAWSAmplifyApp_repository
=== RUN   TestAccAWSAmplifyApp_buildSpec
=== PAUSE TestAccAWSAmplifyApp_buildSpec
=== RUN   TestAccAWSAmplifyApp_customRules
=== PAUSE TestAccAWSAmplifyApp_customRules
=== RUN   TestAccAWSAmplifyApp_environmentVariables
=== PAUSE TestAccAWSAmplifyApp_environmentVariables
=== RUN   TestAccAWSAmplifyApp_autoBranchCreationConfig
=== PAUSE TestAccAWSAmplifyApp_autoBranchCreationConfig
=== RUN   TestAccAWSAmplifyApp_basicAuthConfig
=== PAUSE TestAccAWSAmplifyApp_basicAuthConfig
=== RUN   TestAccAWSAmplifyApp_enableBranchAutoBuild
=== PAUSE TestAccAWSAmplifyApp_enableBranchAutoBuild
=== RUN   TestAccAWSAmplifyApp_iamServiceRoleArn
=== PAUSE TestAccAWSAmplifyApp_iamServiceRoleArn
=== RUN   TestAccAWSAmplifyApp_tags
=== PAUSE TestAccAWSAmplifyApp_tags
=== CONT  TestAccAWSAmplifyApp_basic
--- PASS: TestAccAWSAmplifyApp_basic (65.94s)
=== CONT  TestAccAWSAmplifyApp_autoBranchCreationConfig
--- PASS: TestAccAWSAmplifyApp_autoBranchCreationConfig (252.12s)
=== CONT  TestAccAWSAmplifyApp_buildSpec
--- PASS: TestAccAWSAmplifyApp_buildSpec (130.53s)
=== CONT  TestAccAWSAmplifyApp_environmentVariables
--- PASS: TestAccAWSAmplifyApp_environmentVariables (165.49s)
=== CONT  TestAccAWSAmplifyApp_customRules
--- PASS: TestAccAWSAmplifyApp_customRules (107.23s)
=== CONT  TestAccAWSAmplifyApp_tags
--- PASS: TestAccAWSAmplifyApp_tags (195.11s)
=== CONT  TestAccAWSAmplifyApp_iamServiceRoleArn
--- PASS: TestAccAWSAmplifyApp_iamServiceRoleArn (151.35s)
=== CONT  TestAccAWSAmplifyApp_enableBranchAutoBuild
--- PASS: TestAccAWSAmplifyApp_enableBranchAutoBuild (116.87s)
=== CONT  TestAccAWSAmplifyApp_basicAuthConfig
--- PASS: TestAccAWSAmplifyApp_basicAuthConfig (155.08s)
=== CONT  TestAccAWSAmplifyApp_description
--- PASS: TestAccAWSAmplifyApp_description (115.52s)
=== CONT  TestAccAWSAmplifyApp_repository
--- PASS: TestAccAWSAmplifyApp_repository (69.54s)
=== CONT  TestAccAWSAmplifyApp_rename
--- PASS: TestAccAWSAmplifyApp_rename (124.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1650.676s

...

@ashishmohite ashishmohite requested a review from a team November 2, 2020 08:14
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/amplify Issues and PRs that pertain to the amplify service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Nov 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 2, 2020
@ashishmohite ashishmohite marked this pull request as draft November 4, 2020 03:25
@ghost ghost added the service/firehose Issues and PRs that pertain to the firehose service. label Nov 7, 2020
@ashishmohite ashishmohite marked this pull request as ready for review November 7, 2020 07:09
@ashishmohite ashishmohite requested a review from a team as a code owner November 7, 2020 07:09
@ashishmohite ashishmohite mentioned this pull request Nov 7, 2020
Closed
@ashishmohite
Copy link
Contributor Author

@ewbankkit who can review this PR? I need to raise subsequent PRs for various Amplify resources but those will need aws_amplify_app resource to be present in the core

@ewbankkit ewbankkit mentioned this pull request Nov 15, 2020
Closed
2 tasks
@smorimoto
Copy link

Sorry for the sudden mention, could you review this? @DrFaust92 @bflad

@Gowiem
Copy link

Gowiem commented Jan 14, 2021

@ewbankkit sorry to do it, but any chance this can get reviewed / on the roadmap? The original code for Amplify support is approaching 1 year old at this point. Appreciate taking a look! 🙏

Base automatically changed from master to main January 23, 2021 00:59
@kierancrown
Copy link

Is anything happening with this?

@ewbankkit
Copy link
Contributor

@kierancrown See #19187.

@ewbankkit ewbankkit self-assigned this May 13, 2021
@mihaiplesa
Copy link

Looking forward to this getting in!

@ewbankkit
r/aws_amplify_app: Standard 'name' and 'tags' handling.
5754c4a
@ewbankkit
r/aws_amplify_app: Standard attribute handling.
4f7eda0
@ewbankkit
r/aws_amplify_app: Get simple tests working.
bcec1a5 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_Name\|TestAccAWSAmplifyApp_basic\|TestAccAWSAmplifyApp_disappears\|TestAccAWSAmplifyApp_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_Name\|TestAccAWSAmplifyApp_basic\|TestAccAWSAmplifyApp_disappears\|TestAccAWSAmplifyApp_Tags -timeout 180m
=== RUN   TestAccAWSAmplifyApp_basic
=== PAUSE TestAccAWSAmplifyApp_basic
=== RUN   TestAccAWSAmplifyApp_Name_Generated
=== PAUSE TestAccAWSAmplifyApp_Name_Generated
=== RUN   TestAccAWSAmplifyApp_NamePrefix
=== PAUSE TestAccAWSAmplifyApp_NamePrefix
=== RUN   TestAccAWSAmplifyApp_Tags
=== PAUSE TestAccAWSAmplifyApp_Tags
=== CONT  TestAccAWSAmplifyApp_basic
=== CONT  TestAccAWSAmplifyApp_Tags
=== CONT  TestAccAWSAmplifyApp_Name_Generated
=== CONT  TestAccAWSAmplifyApp_NamePrefix
--- PASS: TestAccAWSAmplifyApp_Name_Generated (14.40s)
--- PASS: TestAccAWSAmplifyApp_NamePrefix (14.90s)
--- PASS: TestAccAWSAmplifyApp_basic (19.53s)
--- PASS: TestAccAWSAmplifyApp_Tags (30.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.242s
@ewbankkit
Suppress diff for 'basic_auth_credentials' if basic auth isn't enabled.
e638796
@ewbankkit
r/aws_amplify_app: Remove 'name_prefix' as it's not compatible with n…
335160c 
…ame updating.

Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_Name\|TestAccAWSAmplifyApp_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_Name\|TestAccAWSAmplifyApp_basic -timeout 180m
=== RUN   TestAccAWSAmplifyApp_basic
=== PAUSE TestAccAWSAmplifyApp_basic
=== RUN   TestAccAWSAmplifyApp_Name
=== PAUSE TestAccAWSAmplifyApp_Name
=== CONT  TestAccAWSAmplifyApp_basic
=== CONT  TestAccAWSAmplifyApp_Name
--- PASS: TestAccAWSAmplifyApp_basic (13.33s)
--- PASS: TestAccAWSAmplifyApp_Name (22.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.372s
@ewbankkit
r/aws_amplify_app: ForceNew if 'description' changes to "".
94a9d17 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_Description'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_Description -timeout 180m
=== RUN   TestAccAWSAmplifyApp_Description
=== PAUSE TestAccAWSAmplifyApp_Description
=== CONT  TestAccAWSAmplifyApp_Description
--- PASS: TestAccAWSAmplifyApp_Description (33.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.482s
@ewbankkit
r/aws_amplify_app: ForceNew if 'build_spec' changes to "".
407f9fe 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_BuildSpec'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_BuildSpec -timeout 180m
=== RUN   TestAccAWSAmplifyApp_BuildSpec
=== PAUSE TestAccAWSAmplifyApp_BuildSpec
=== CONT  TestAccAWSAmplifyApp_BuildSpec
--- PASS: TestAccAWSAmplifyApp_BuildSpec (33.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.005s
@ewbankkit
r/aws_amplify_app: Add test sweeper.
6bc6406 
Acceptance test output:

% TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_amplify_app make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2 -sweep-run=aws_amplify_app -timeout 60m
2021/05/20 11:13:49 [DEBUG] Running Sweepers for region (us-west-2):
2021/05/20 11:13:49 [DEBUG] Running Sweeper (aws_amplify_app) in region (us-west-2)
2021/05/20 11:13:49 [INFO] AWS Auth provider used: "EnvProvider"
2021/05/20 11:13:49 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/05/20 11:13:50 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/05/20 11:13:50 [DEBUG] Deleting Amplify App (d3e2rpqo82owxg)
2021/05/20 11:13:51 Sweeper Tests ran successfully:
	- aws_amplify_app
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.452s
@ewbankkit
r/aws_amplify_app: Add '_disappears' test (hashicorp#15945).
9b05180 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_disappears -timeout 180m
=== RUN   TestAccAWSAmplifyApp_disappears
=== PAUSE TestAccAWSAmplifyApp_disappears
=== CONT  TestAccAWSAmplifyApp_disappears
--- PASS: TestAccAWSAmplifyApp_disappears (10.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.084s
@ewbankkit
r/aws_amplify_app: Send empty array to clear 'custom_rule'.
f3f3ac0 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_CustomRules'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_CustomRules -timeout 180m
=== RUN   TestAccAWSAmplifyApp_CustomRules
=== PAUSE TestAccAWSAmplifyApp_CustomRules
=== CONT  TestAccAWSAmplifyApp_CustomRules
--- PASS: TestAccAWSAmplifyApp_CustomRules (30.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.169s
@ewbankkit
r/aws_amplify_app: Send map with empty key and value to clear 'enviro…
4b781c8 
…nment_variables'.

Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_EnvironmentVariables'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_EnvironmentVariables -timeout 180m
=== RUN   TestAccAWSAmplifyApp_EnvironmentVariables
=== PAUSE TestAccAWSAmplifyApp_EnvironmentVariables
=== CONT  TestAccAWSAmplifyApp_EnvironmentVariables
--- PASS: TestAccAWSAmplifyApp_EnvironmentVariables (29.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.543s
@ewbankkit
r/aws_amplify_app: Get branch auto-creation working.
b418fe7 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_AutoBranchCreationConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_AutoBranchCreationConfig -timeout 180m
=== RUN   TestAccAWSAmplifyApp_AutoBranchCreationConfig
=== PAUSE TestAccAWSAmplifyApp_AutoBranchCreationConfig
=== CONT  TestAccAWSAmplifyApp_AutoBranchCreationConfig
--- PASS: TestAccAWSAmplifyApp_AutoBranchCreationConfig (35.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.286s
@ewbankkit
r/aws_amplify_app: ForceNew if 'iam_service_role_arn' changes to "".
76e401e 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_IamServiceRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_IamServiceRole -timeout 180m
=== RUN   TestAccAWSAmplifyApp_IamServiceRole
=== PAUSE TestAccAWSAmplifyApp_IamServiceRole
=== CONT  TestAccAWSAmplifyApp_IamServiceRole
--- PASS: TestAccAWSAmplifyApp_IamServiceRole (32.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.813s
@ewbankkit
r/aws_amplify_app: Remove 'custom_headers' - Not amenable to IaC.
f88c0fd
@ewbankkit
r/aws_amplify_app: Environment variables for 'TestAccAWSAmplifyApp_Re…
96f76cb 
…pository'.

Acceptance test output:

AMPLIFY_GITHUB_ACCESS_TOKEN="..." AMPLIFY_GITHUB_REPOSITORY="https://github.com/ewbankkit/terraform-aws-provider-testing" make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyApp_Repository'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyApp_Repository -timeout 180m
=== RUN   TestAccAWSAmplifyApp_Repository
=== PAUSE TestAccAWSAmplifyApp_Repository
=== CONT  TestAccAWSAmplifyApp_Repository
--- PASS: TestAccAWSAmplifyApp_Repository (15.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.557s
@ewbankkit
r/aws_amplify_app: Get all acceptance tests passing.
b964ecf
@ewbankkit
r/aws_amplify_app: Serialize acceptance tests to limit API rate-limit…
1643971 
… exceeded errors.
@ewbankkit
r/aws_amplify_app: Update documentation.
dc8b24e
@ewbankkit
Add 'resource_aws_amplify_test.go'.
769b5ce
ewbankkit
ewbankkit approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% AMPLIFY_GITHUB_ACCESS_TOKEN="..." AMPLIFY_GITHUB_REPOSITORY="https://github.com/ewbankkit/terraform-aws-provider-testing" make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_'                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_ -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/App
=== RUN   TestAccAWSAmplify_serial/App/Tags
=== PAUSE TestAccAWSAmplify_serial/App/Tags
=== RUN   TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== PAUSE TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== RUN   TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== RUN   TestAccAWSAmplify_serial/App/Name
=== PAUSE TestAccAWSAmplify_serial/App/Name
=== RUN   TestAccAWSAmplify_serial/App/Repository
=== PAUSE TestAccAWSAmplify_serial/App/Repository
=== RUN   TestAccAWSAmplify_serial/App/disappears
=== PAUSE TestAccAWSAmplify_serial/App/disappears
=== RUN   TestAccAWSAmplify_serial/App/BuildSpec
=== PAUSE TestAccAWSAmplify_serial/App/BuildSpec
=== RUN   TestAccAWSAmplify_serial/App/CustomRules
=== PAUSE TestAccAWSAmplify_serial/App/CustomRules
=== RUN   TestAccAWSAmplify_serial/App/Description
=== PAUSE TestAccAWSAmplify_serial/App/Description
=== RUN   TestAccAWSAmplify_serial/App/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/App/EnvironmentVariables
=== RUN   TestAccAWSAmplify_serial/App/IamServiceRole
=== PAUSE TestAccAWSAmplify_serial/App/IamServiceRole
=== RUN   TestAccAWSAmplify_serial/App/basic
=== PAUSE TestAccAWSAmplify_serial/App/basic
=== CONT  TestAccAWSAmplify_serial/App/Tags
=== CONT  TestAccAWSAmplify_serial/App/IamServiceRole
=== CONT  TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== CONT  TestAccAWSAmplify_serial/App/BuildSpec
=== CONT  TestAccAWSAmplify_serial/App/Description
=== CONT  TestAccAWSAmplify_serial/App/EnvironmentVariables
=== CONT  TestAccAWSAmplify_serial/App/basic
=== CONT  TestAccAWSAmplify_serial/App/CustomRules
=== CONT  TestAccAWSAmplify_serial/App/Name
=== CONT  TestAccAWSAmplify_serial/App/disappears
=== CONT  TestAccAWSAmplify_serial/App/Repository
=== CONT  TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
--- PASS: TestAccAWSAmplify_serial (57.63s)
    --- PASS: TestAccAWSAmplify_serial/App (0.00s)
        --- PASS: TestAccAWSAmplify_serial/App/disappears (22.83s)
        --- PASS: TestAccAWSAmplify_serial/App/Repository (32.26s)
        --- PASS: TestAccAWSAmplify_serial/App/Name (39.13s)
        --- PASS: TestAccAWSAmplify_serial/App/Tags (48.31s)
        --- PASS: TestAccAWSAmplify_serial/App/CustomRules (49.94s)
        --- PASS: TestAccAWSAmplify_serial/App/basic (51.08s)
        --- PASS: TestAccAWSAmplify_serial/App/BuildSpec (53.59s)
        --- PASS: TestAccAWSAmplify_serial/App/IamServiceRole (53.79s)
        --- PASS: TestAccAWSAmplify_serial/App/EnvironmentVariables (56.12s)
        --- PASS: TestAccAWSAmplify_serial/App/Description (56.80s)
        --- PASS: TestAccAWSAmplify_serial/App/BasicAuthCredentials (57.00s)
        --- PASS: TestAccAWSAmplify_serial/App/AutoBranchCreationConfig (57.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.642s
GovCloud
% AMPLIFY_GITHUB_ACCESS_TOKEN="..." AMPLIFY_GITHUB_REPOSITORY="https://github.com/ewbankkit/terraform-aws-provider-testing" make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_'
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/App
=== RUN   TestAccAWSAmplify_serial/App/basic
=== PAUSE TestAccAWSAmplify_serial/App/basic
=== RUN   TestAccAWSAmplify_serial/App/disappears
=== PAUSE TestAccAWSAmplify_serial/App/disappears
=== RUN   TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== PAUSE TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== RUN   TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== RUN   TestAccAWSAmplify_serial/App/IamServiceRole
=== PAUSE TestAccAWSAmplify_serial/App/IamServiceRole
=== RUN   TestAccAWSAmplify_serial/App/Tags
=== PAUSE TestAccAWSAmplify_serial/App/Tags
=== RUN   TestAccAWSAmplify_serial/App/BuildSpec
=== PAUSE TestAccAWSAmplify_serial/App/BuildSpec
=== RUN   TestAccAWSAmplify_serial/App/CustomRules
=== PAUSE TestAccAWSAmplify_serial/App/CustomRules
=== RUN   TestAccAWSAmplify_serial/App/Description
=== PAUSE TestAccAWSAmplify_serial/App/Description
=== RUN   TestAccAWSAmplify_serial/App/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/App/EnvironmentVariables
=== RUN   TestAccAWSAmplify_serial/App/Name
=== PAUSE TestAccAWSAmplify_serial/App/Name
=== RUN   TestAccAWSAmplify_serial/App/Repository
=== PAUSE TestAccAWSAmplify_serial/App/Repository
=== CONT  TestAccAWSAmplify_serial/App/basic
=== CONT  TestAccAWSAmplify_serial/App/BuildSpec
=== CONT  TestAccAWSAmplify_serial/App/Description
=== CONT  TestAccAWSAmplify_serial/App/EnvironmentVariables
=== CONT  TestAccAWSAmplify_serial/App/Repository
=== CONT  TestAccAWSAmplify_serial/App/Name
=== CONT  TestAccAWSAmplify_serial/App/CustomRules
=== CONT  TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== CONT  TestAccAWSAmplify_serial/App/Tags
=== CONT  TestAccAWSAmplify_serial/App/IamServiceRole
=== CONT  TestAccAWSAmplify_serial/App/disappears
=== CONT  TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== CONT  TestAccAWSAmplify_serial/App/basic
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/BuildSpec
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/EnvironmentVariables
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/CustomRules
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/Description
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/Name
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/Repository
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/Tags
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/IamServiceRole
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/BasicAuthCredentials
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/disappears
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
--- PASS: TestAccAWSAmplify_serial (1.37s)
    --- PASS: TestAccAWSAmplify_serial/App (0.00s)
        --- SKIP: TestAccAWSAmplify_serial/App/basic (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/BuildSpec (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/CustomRules (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/EnvironmentVariables (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/Description (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/Name (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/Repository (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/Tags (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/IamServiceRole (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/BasicAuthCredentials (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/disappears (1.37s)
        --- SKIP: TestAccAWSAmplify_serial/App/AutoBranchCreationConfig (1.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.367s

@ewbankkit
Copy link
Contributor

@ashishmohite @k24d Thanks for the contribution 👏.
In general everything was in great shape.
I made a few modifications to get this merged quicker:

  • Made tests run serially so as not to hit API rate-limiting errors
  • Modified some of the arguments to better match the AWS API structure - the main change here was removing the basic_auth_config block and flattening to basic_auth_enabled and basic_auth_credentials. Documentation updated

@ewbankkit ewbankkit merged commit ead8c65 into hashicorp:main May 21, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 21, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/amplify Issues and PRs that pertain to the amplify service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.43.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ashishmohite @smorimoto @Gowiem @kierancrown @ewbankkit @mihaiplesa @k24d