Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Backup Region Settings #16114

Merged
merged 8 commits into from Nov 24, 2020
Merged

Support Backup Region Settings #16114

merged 8 commits into from Nov 24, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13449

Release note for CHANGELOG:

resource_aws_backup_region_settings - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAwsBackupRegionSettings_basic (79.48s)
...

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 10, 2020 12:19
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 10, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Nov 10, 2020
ewbankkit
ewbankkit approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupRegionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupRegionSettings_ -timeout 120m
=== RUN   TestAccAwsBackupRegionSettings_basic
=== PAUSE TestAccAwsBackupRegionSettings_basic
=== CONT  TestAccAwsBackupRegionSettings_basic
--- PASS: TestAccAwsBackupRegionSettings_basic (29.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.352s

breathingdust
breathingdust reviewed Nov 13, 2020
View reviewed changes
aws/resource_aws_backup_region_settings_test.go
)

func TestAccAwsBackupRegionSettings_basic(t *testing.T) {
var settings backup.DescribeRegionSettingsOutput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing in GovCloud as FSx is not available there, can we use describeRegionSettings to populate the list to check? cc: @YakDriver

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api allows for partial update (but describe actually return all services) so I can add computed to the map to reduce service keys in tests to something simple like RDS. I just wanted it to prevent any state drift issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below

@DrFaust92 @YakDriver
Update aws/resource_aws_backup_region_settings_test.go
d9daae3 
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
DrFaust92 and others added 2 commits November 24, 2020 08:59
@DrFaust92 @YakDriver
Update aws/resource_aws_backup_region_settings_test.go
1dd519d 
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
@DrFaust92
fmt
2419075
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupRegionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupRegionSettings_ -timeout 120m
=== RUN   TestAccAwsBackupRegionSettings_basic
=== PAUSE TestAccAwsBackupRegionSettings_basic
=== CONT  TestAccAwsBackupRegionSettings_basic
--- PASS: TestAccAwsBackupRegionSettings_basic (31.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.801s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupRegionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupRegionSettings_ -timeout 120m
=== RUN   TestAccAwsBackupRegionSettings_basic
=== PAUSE TestAccAwsBackupRegionSettings_basic
=== CONT  TestAccAwsBackupRegionSettings_basic
    provider_test.go:626: skipping tests; partition aws-us-gov does not support fsx service
--- SKIP: TestAccAwsBackupRegionSettings_basic (0.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.942s

@breathingdust breathingdust merged commit 23a6c91 into hashicorp:master Nov 24, 2020
breathingdust added a commit that referenced this pull request Nov 24, 2020
@breathingdust
Update CHANGELOG.md for #16114
ee67a6f
@breathingdust breathingdust added this to the v3.18.0 milestone Nov 24, 2020
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 25, 2020
@DrFaust92 DrFaust92 deleted the r/backup_region_settings branch April 15, 2021 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust left review comments

@YakDriver YakDriver YakDriver left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.18.0
Development

Successfully merging this pull request may close these issues.

Support Backup Region Settings
4 participants
@DrFaust92 @breathingdust @ewbankkit @YakDriver