Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/internet_gateway_attachment - new resource #16386

Merged
merged 7 commits into from Feb 23, 2022
Merged

r/internet_gateway_attachment - new resource #16386

merged 7 commits into from Feb 23, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 23, 2020 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16151
Closes #13742
Closes #9101

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2InternetGatewayAttachment_ PKG=ec2
--- PASS: TestAccEC2InternetGatewayAttachment_disappears (34.04s)
--- PASS: TestAccEC2InternetGatewayAttachment_basic (63.16s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 23, 2020 21:19
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 23, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Nov 23, 2020
@bflad bflad added the proposal Proposes new design or functionality. label Nov 23, 2020
@DrFaust92 DrFaust92 marked this pull request as draft November 24, 2020 19:24
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/databasemigrationservice service/directconnect Issues and PRs that pertain to the directconnect service. service/docdb Issues and PRs that pertain to the docdb service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ecs Issues and PRs that pertain to the ecs service. and removed size/XL Managed by automation to categorize the size of a PR. labels Nov 24, 2020
@DrFaust92 DrFaust92 added size/XXL Managed by automation to categorize the size of a PR. and removed service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/lambda Issues and PRs that pertain to the lambda service. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XL Managed by automation to categorize the size of a PR. labels Nov 24, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Nov 24, 2020
@DrFaust92 DrFaust92 added the service/ec2 Issues and PRs that pertain to the ec2 service. label Nov 24, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review November 24, 2020 20:10
@DrFaust92
Copy link
Collaborator Author

Thanks @ewbankkit, Addressed comments!

Base automatically changed from master to main January 23, 2021 00:59
@DrFaust92 DrFaust92 force-pushed the r/internet_gateway_attachment branch from 3f3e21e to 64ae9c3 Compare July 4, 2021 06:28
@DrFaust92
Copy link
Collaborator Author

rebased

--- PASS: TestAccAWSInternetGatewayAttachment_disappears (66.59s)
--- PASS: TestAccAWSInternetGatewayAttachment_basic (101.28s)

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

DrFaust92 and others added 4 commits February 21, 2022 23:40
@DrFaust92
fmt
e7ae971
@ewbankkit
Add note about 'aws_internet_gateway.vpc_id' to CHANGELOG.
46d34ed
@ewbankkit
r/aws_internet_gateway_attachment: Tweak resource ID creation and par…
895761c 
…sing.

Acceptance test output:

% make testacc TESTS=TestAccEC2InternetGatewayAttachment_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InternetGatewayAttachment_'  -timeout 180m
=== RUN   TestAccEC2InternetGatewayAttachment_basic
=== PAUSE TestAccEC2InternetGatewayAttachment_basic
=== RUN   TestAccEC2InternetGatewayAttachment_disappears
=== PAUSE TestAccEC2InternetGatewayAttachment_disappears
=== CONT  TestAccEC2InternetGatewayAttachment_basic
=== CONT  TestAccEC2InternetGatewayAttachment_disappears
--- PASS: TestAccEC2InternetGatewayAttachment_disappears (19.35s)
--- PASS: TestAccEC2InternetGatewayAttachment_basic (35.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	42.869s
@ewbankkit
r/aws_internet_gateway_attachment: Change 'vpc_id' to ForceNew.
8cb7cb2 
Acceptance test output:

% make testacc TESTS=TestAccEC2InternetGatewayAttachment_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InternetGatewayAttachment_'  -timeout 180m
=== RUN   TestAccEC2InternetGatewayAttachment_basic
=== PAUSE TestAccEC2InternetGatewayAttachment_basic
=== RUN   TestAccEC2InternetGatewayAttachment_disappears
=== PAUSE TestAccEC2InternetGatewayAttachment_disappears
=== CONT  TestAccEC2InternetGatewayAttachment_basic
=== CONT  TestAccEC2InternetGatewayAttachment_disappears
--- PASS: TestAccEC2InternetGatewayAttachment_disappears (17.48s)
--- PASS: TestAccEC2InternetGatewayAttachment_basic (19.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	23.881s
@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.
I changed the vpc_id argument to ForceNew: true to match the aws_vpn_gateway_attachment resource and other similar resources.
This simplified both the resource implementation (no Update required) and acceptance tests.

@ewbankkit ewbankkit merged commit b2715d5 into hashicorp:main Feb 23, 2022
@github-actions github-actions bot added this to the v4.3.0 milestone Feb 23, 2022
@DrFaust92 DrFaust92 deleted the r/internet_gateway_attachment branch February 23, 2022 17:43
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@b-diggity b-diggity mentioned this pull request Mar 5, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.3.0
4 participants
@DrFaust92 @zhelding @ewbankkit @bflad