Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_spot_fleet_request: gp3 Volume Type Failures #16722

Closed
bflad opened this issue Dec 11, 2020 · 2 comments
Closed

tests/resource/aws_spot_fleet_request: gp3 Volume Type Failures #16722

bflad opened this issue Dec 11, 2020 · 2 comments
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@bflad
Copy link
Contributor

bflad commented Dec 11, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The recently announced gp3 volume type, while supported in "all regions", does not appear to work correctly with EC2 Spot Fleet Requests yet in all regions as found by new acceptance testing that passes in AWS Commercial but not AWS GovCloud (US):

=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
    resource_aws_spot_fleet_request_test.go:953: Step 1/2 error: Error running apply:
        Error: Error requesting spot fleet: InvalidSpotFleetRequestConfig:
          status code: 400, request id: af58b8ad-a9bb-49cc-a19a-9fa4cd605df2

=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
    resource_aws_spot_fleet_request_test.go:986: Step 1/2 error: Error running apply:
        Error: Error requesting spot fleet: InvalidSpotFleetRequestConfig:
          status code: 400, request id: aade31cb-4dcc-4d75-9bb2-f94a349a8c41

Introducing the new Terraform resource handling does not introduce any regressions, so this functionality will be merged in so practitioners can benefit in AWS Commercial, but the tests will either need ErrorCheck handling for the (admittedly very generic) error and/or a support case raised.

Affected Resource

  • aws_spot_fleet_request

References

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Dec 11, 2020
@ewbankkit
Copy link
Contributor

This is now passing:

--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (135.77s)

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

No branches or pull requests

2 participants