Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for CloudWatch event bus name #16815

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

kromol
Copy link

@kromol kromol commented Dec 17, 2020

Now validation matches the pattern described in AWS docs. Slash
in names allows to create event buses associated with partner event
sources (where names might contain slashes), since both names should match.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16431

Release note for CHANGELOG:

fix allowed pattern for EventBridge event bus name

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Now validation matches the pattern described in [AWS docs][1]. Slash
in names allows to create event buses associated with partner event
sources (where names might contain slashes), since both names should match.

[1]: https://docs.aws.amazon.com/eventbridge/latest/APIReference
@kromol kromol requested a review from a team as a code owner December 17, 2020 13:29
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Dec 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 17, 2020
Base automatically changed from master to main January 23, 2021 01:00
@X010617
Copy link

X010617 commented Feb 11, 2021

I'd really like to see this get merged. The issue this fixes prevents any terraform integration with Event Bridge since the name of the event bus must match the name of the partner event source.

@guycushion
Copy link

this issue has just brought our TF upgrade to a halt, any chance this PR could get merged

@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for EventBridge partner event bus
5 participants