Add Fargate support to Batch compute environments #16819

gmazelier · 2020-12-17T17:37:40Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16592
Closes #12543
Requires #16850 to be fully usable

Release note for CHANGELOG:

resource/aws_batch_compute_environment: add Fargate support (#16819)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSBatchComputeEnvironment_' ACCTEST_PARALLELISM=4 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_ -timeout 120m
=== RUN   TestAccAWSBatchComputeEnvironment_disappears
=== PAUSE TestAccAWSBatchComputeEnvironment_disappears
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2
=== RUN   TestAccAWSBatchComputeEnvironment_createWithNamePrefix
=== PAUSE TestAccAWSBatchComputeEnvironment_createWithNamePrefix
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithTags
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithTags
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanaged
=== PAUSE TestAccAWSBatchComputeEnvironment_createUnmanaged
=== RUN   TestAccAWSBatchComputeEnvironment_createFargate
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargate
=== RUN   TestAccAWSBatchComputeEnvironment_createFargateSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargateSpot
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_DesiredVcpus_Computed
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_DesiredVcpus_Computed
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_updateInstanceType
=== PAUSE TestAccAWSBatchComputeEnvironment_updateInstanceType
=== RUN   TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName
=== PAUSE TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_launchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy
=== RUN   TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage
=== RUN   TestAccAWSBatchComputeEnvironment_updateState
=== PAUSE TestAccAWSBatchComputeEnvironment_updateState
=== RUN   TestAccAWSBatchComputeEnvironment_Tags
=== PAUSE TestAccAWSBatchComputeEnvironment_Tags
=== CONT  TestAccAWSBatchComputeEnvironment_disappears
=== CONT  TestAccAWSBatchComputeEnvironment_updateInstanceType
=== CONT  TestAccAWSBatchComputeEnvironment_createFargate
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
--- PASS: TestAccAWSBatchComputeEnvironment_disappears (75.10s)
=== CONT  TestAccAWSBatchComputeEnvironment_createFargateSpot
--- PASS: TestAccAWSBatchComputeEnvironment_createFargate (79.64s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2WithTags
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (142.82s)
=== CONT  TestAccAWSBatchComputeEnvironment_createUnmanaged
--- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (76.93s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (82.89s)
=== CONT  TestAccAWSBatchComputeEnvironment_createWithNamePrefix
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (175.14s)
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (67.66s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (71.32s)
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_DesiredVcpus_Computed
--- PASS: TestAccAWSBatchComputeEnvironment_createWithNamePrefix (70.78s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (71.76s)
=== CONT  TestAccAWSBatchComputeEnvironment_Tags
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy (71.32s)
=== CONT  TestAccAWSBatchComputeEnvironment_updateState
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (124.86s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage
--- PASS: TestAccAWSBatchComputeEnvironment_Tags (150.78s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (34.25s)
=== CONT  TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (32.97s)
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (308.59s)
=== CONT  TestAccAWSBatchComputeEnvironment_launchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_DesiredVcpus_Computed (326.23s)
=== CONT  TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (81.37s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (132.80s)
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (132.74s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (64.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       616.239s

Skybound1 · 2021-03-01T21:20:37Z

Hi, gave this a test run locally and noticed an issue when updating the max vcpus parameter. The update command issued to AWS includes both max and min vcpus, and AWS responds with a minvCpus is not applicable for Fargate error message.

A hacky fix I quickly tried out on line 456 of resource_aws_batch_compute_environment.go that seemed to fix the issue was:

if computeResource["type"] != "FARGATE" {
	input.ComputeResources.MinvCpus = aws.Int64(int64(computeResource["min_vcpus"].(int)))
}

gmazelier · 2021-03-05T15:15:57Z

@Skybound1 thanks for your feedback!

If I understand well to reproduce what you describe and add some test case. You have an existing Terraform configuration with Batch resources and you want to reconfigure the compute environment to use Fargate, correct? Have you removed min_vcpus from your configuration (is it explicitly defined)?

Skybound1 · 2021-03-05T15:21:10Z

Yup this was migrating existing Batch to Fargate, and I had removed the min_vcpus definition from my terraform. I intercepted the API requests to AWS and noticed it was still sending the parameter with the value of 0. Skimming through the code, I saw that both MinvCpus and MaxvCpus were being sent in the update command.

Edit: I should also note that I only saw this issue when I was modifying the value of max vCpu as well

gmazelier · 2021-03-12T22:08:51Z

Hi @Skybound1. Thank you, just made an updated with your suggested fix. Also try to create a test case for this issue but was unable to reproduce your error. When switch from EC2 to Margate type in my tests, I find that the compute environment was deleted and created again, not updated. Can you have a look at ef9e6d8?

…atchComputeEnvironment_createEc2'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_createEc2' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_createEc2 -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_createEc2 === PAUSE TestAccAWSBatchComputeEnvironment_createEc2 === RUN TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources === PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources === CONT TestAccAWSBatchComputeEnvironment_createEc2 === CONT TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources --- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (15.93s) --- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (41.39s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 44.466s

…atchComputeEnvironment_createFargate'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_createFargate' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_createFargate -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_createFargate === PAUSE TestAccAWSBatchComputeEnvironment_createFargate === RUN TestAccAWSBatchComputeEnvironment_createFargateSpot === PAUSE TestAccAWSBatchComputeEnvironment_createFargateSpot === CONT TestAccAWSBatchComputeEnvironment_createFargate === CONT TestAccAWSBatchComputeEnvironment_createFargateSpot --- PASS: TestAccAWSBatchComputeEnvironment_createFargate (37.82s) --- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (37.89s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 41.373s

…atchComputeEnvironment_createSpot'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_createSpot' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_createSpot -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_createSpot === PAUSE TestAccAWSBatchComputeEnvironment_createSpot === RUN TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy === PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy === RUN TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage === PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage === CONT TestAccAWSBatchComputeEnvironment_createSpot === CONT TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage === CONT TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy --- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (16.19s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithAllocationStrategy (39.25s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpot (451.34s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 454.712s

…nt_createEc2_DesiredVcpus_ComputeResourcesTags'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_ComputeResourcesTags' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_ComputeResourcesTags -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_ComputeResourcesTags === PAUSE TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_ComputeResourcesTags === CONT TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_ComputeResourcesTags --- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_ComputeResourcesTags (72.85s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 75.936s

…nt_updateServiceRole'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_updateServiceRole' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_updateServiceRole -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_updateServiceRole === PAUSE TestAccAWSBatchComputeEnvironment_updateServiceRole === CONT TestAccAWSBatchComputeEnvironment_updateServiceRole --- PASS: TestAccAWSBatchComputeEnvironment_updateServiceRole (64.70s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 67.804s

…nment_createEc2_DesiredVcpus_ComputeResourcesTags' to 'TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags === PAUSE TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags === CONT TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags --- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags (126.28s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 129.281s

…us_Computed'.

…atchComputeEnvironment_ComputeResources_MaxVcpus' and 'TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_ComputeResources_' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_ComputeResources_ -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus === PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus === RUN TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus === PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus === CONT TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus === CONT TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus --- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (83.56s) --- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (219.32s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 222.771s

…atchComputeEnvironment_launchTemplate'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_launchTemplate' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_launchTemplate -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_launchTemplate === PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate === CONT TestAccAWSBatchComputeEnvironment_launchTemplate --- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (39.96s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 43.510s

…atchComputeEnvironment_UpdateLaunchTemplate'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate === PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate === CONT TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate --- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (61.35s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 66.500s

…atchComputeEnvironment_createUnmanagedWithComputeResources'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources === PAUSE TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources === CONT TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources --- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (36.32s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 39.467s

Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_disappears\|TestAccAWSBatchJobDefinition_disappears' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_disappears\|TestAccAWSBatchJobDefinition_disappears -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_disappears === PAUSE TestAccAWSBatchComputeEnvironment_disappears === RUN TestAccAWSBatchJobDefinition_disappears === PAUSE TestAccAWSBatchJobDefinition_disappears === CONT TestAccAWSBatchComputeEnvironment_disappears === CONT TestAccAWSBatchJobDefinition_disappears --- PASS: TestAccAWSBatchJobDefinition_disappears (9.66s) --- PASS: TestAccAWSBatchComputeEnvironment_disappears (46.07s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 49.143s

…e updated for Fargate compute resources. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_ -timeout 180m === RUN TestAccAWSBatchComputeEnvironment_basic === PAUSE TestAccAWSBatchComputeEnvironment_basic === RUN TestAccAWSBatchComputeEnvironment_disappears === PAUSE TestAccAWSBatchComputeEnvironment_disappears === RUN TestAccAWSBatchComputeEnvironment_NameGenerated === PAUSE TestAccAWSBatchComputeEnvironment_NameGenerated === RUN TestAccAWSBatchComputeEnvironment_NamePrefix === PAUSE TestAccAWSBatchComputeEnvironment_NamePrefix === RUN TestAccAWSBatchComputeEnvironment_createEc2 === PAUSE TestAccAWSBatchComputeEnvironment_createEc2 === RUN TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags === PAUSE TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags === RUN TestAccAWSBatchComputeEnvironment_createSpot === PAUSE TestAccAWSBatchComputeEnvironment_createSpot === RUN TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage === PAUSE TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage === RUN TestAccAWSBatchComputeEnvironment_createFargate === PAUSE TestAccAWSBatchComputeEnvironment_createFargate === RUN TestAccAWSBatchComputeEnvironment_createFargateSpot === PAUSE TestAccAWSBatchComputeEnvironment_createFargateSpot === RUN TestAccAWSBatchComputeEnvironment_updateState === PAUSE TestAccAWSBatchComputeEnvironment_updateState === RUN TestAccAWSBatchComputeEnvironment_updateServiceRole === PAUSE TestAccAWSBatchComputeEnvironment_updateServiceRole === RUN TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus === PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus === RUN TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus === PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus === RUN TestAccAWSBatchComputeEnvironment_launchTemplate === PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate === RUN TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate === PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate === RUN TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate === PAUSE TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate === RUN TestAccAWSBatchComputeEnvironment_Tags === PAUSE TestAccAWSBatchComputeEnvironment_Tags === RUN TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources === PAUSE TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources === RUN TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources === PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources === RUN TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole === PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole === CONT TestAccAWSBatchComputeEnvironment_basic === CONT TestAccAWSBatchComputeEnvironment_Tags === CONT TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole === CONT TestAccAWSBatchComputeEnvironment_createFargateSpot --- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole (17.63s) === CONT TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources --- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (14.25s) === CONT TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources --- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (40.50s) === CONT TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags --- PASS: TestAccAWSBatchComputeEnvironment_basic (46.63s) === CONT TestAccAWSBatchComputeEnvironment_createFargate --- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (31.85s) === CONT TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage --- PASS: TestAccAWSBatchComputeEnvironment_createFargate (35.11s) === CONT TestAccAWSBatchComputeEnvironment_createSpot --- PASS: TestAccAWSBatchComputeEnvironment_Tags (82.20s) === CONT TestAccAWSBatchComputeEnvironment_NamePrefix --- PASS: TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage (36.36s) === CONT TestAccAWSBatchComputeEnvironment_createEc2 --- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (34.87s) === CONT TestAccAWSBatchComputeEnvironment_NameGenerated --- PASS: TestAccAWSBatchComputeEnvironment_NamePrefix (64.30s) === CONT TestAccAWSBatchComputeEnvironment_disappears --- PASS: TestAccAWSBatchComputeEnvironment_NameGenerated (45.19s) === CONT TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus --- PASS: TestAccAWSBatchComputeEnvironment_disappears (35.02s) === CONT TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate --- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags (149.31s) === CONT TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate --- PASS: TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate (55.25s) === CONT TestAccAWSBatchComputeEnvironment_launchTemplate --- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (60.60s) === CONT TestAccAWSBatchComputeEnvironment_updateServiceRole --- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (71.12s) === CONT TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus --- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (36.67s) === CONT TestAccAWSBatchComputeEnvironment_updateState --- PASS: TestAccAWSBatchComputeEnvironment_updateServiceRole (63.10s) --- PASS: TestAccAWSBatchComputeEnvironment_updateState (51.28s) --- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (194.12s) --- PASS: TestAccAWSBatchComputeEnvironment_createSpot (459.77s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 544.574s

…D environment.

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_' ACCTEST_PARALLELISM=4 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_ -timeout 180m
=== RUN   TestAccAWSBatchComputeEnvironment_basic
=== PAUSE TestAccAWSBatchComputeEnvironment_basic
=== RUN   TestAccAWSBatchComputeEnvironment_disappears
=== PAUSE TestAccAWSBatchComputeEnvironment_disappears
=== RUN   TestAccAWSBatchComputeEnvironment_NameGenerated
=== PAUSE TestAccAWSBatchComputeEnvironment_NameGenerated
=== RUN   TestAccAWSBatchComputeEnvironment_NamePrefix
=== PAUSE TestAccAWSBatchComputeEnvironment_NamePrefix
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== RUN   TestAccAWSBatchComputeEnvironment_createFargate
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargate
=== RUN   TestAccAWSBatchComputeEnvironment_createFargateSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargateSpot
=== RUN   TestAccAWSBatchComputeEnvironment_updateState
=== PAUSE TestAccAWSBatchComputeEnvironment_updateState
=== RUN   TestAccAWSBatchComputeEnvironment_updateServiceRole
=== PAUSE TestAccAWSBatchComputeEnvironment_updateServiceRole
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_launchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== RUN   TestAccAWSBatchComputeEnvironment_Tags
=== PAUSE TestAccAWSBatchComputeEnvironment_Tags
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== CONT  TestAccAWSBatchComputeEnvironment_basic
=== CONT  TestAccAWSBatchComputeEnvironment_Tags
=== CONT  TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== CONT  TestAccAWSBatchComputeEnvironment_createFargateSpot
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole (17.63s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (14.25s)
=== CONT  TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (40.50s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
--- PASS: TestAccAWSBatchComputeEnvironment_basic (46.63s)
=== CONT  TestAccAWSBatchComputeEnvironment_createFargate
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (31.85s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
--- PASS: TestAccAWSBatchComputeEnvironment_createFargate (35.11s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot
--- PASS: TestAccAWSBatchComputeEnvironment_Tags (82.20s)
=== CONT  TestAccAWSBatchComputeEnvironment_NamePrefix
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage (36.36s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (34.87s)
=== CONT  TestAccAWSBatchComputeEnvironment_NameGenerated
--- PASS: TestAccAWSBatchComputeEnvironment_NamePrefix (64.30s)
=== CONT  TestAccAWSBatchComputeEnvironment_disappears
--- PASS: TestAccAWSBatchComputeEnvironment_NameGenerated (45.19s)
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
--- PASS: TestAccAWSBatchComputeEnvironment_disappears (35.02s)
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags (149.31s)
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate (55.25s)
=== CONT  TestAccAWSBatchComputeEnvironment_launchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (60.60s)
=== CONT  TestAccAWSBatchComputeEnvironment_updateServiceRole
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (71.12s)
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (36.67s)
=== CONT  TestAccAWSBatchComputeEnvironment_updateState
--- PASS: TestAccAWSBatchComputeEnvironment_updateServiceRole (63.10s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (51.28s)
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (194.12s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (459.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	544.574s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchComputeEnvironment_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSBatchComputeEnvironment_ -timeout 180m
=== RUN   TestAccAWSBatchComputeEnvironment_basic
=== PAUSE TestAccAWSBatchComputeEnvironment_basic
=== RUN   TestAccAWSBatchComputeEnvironment_disappears
=== PAUSE TestAccAWSBatchComputeEnvironment_disappears
=== RUN   TestAccAWSBatchComputeEnvironment_NameGenerated
=== PAUSE TestAccAWSBatchComputeEnvironment_NameGenerated
=== RUN   TestAccAWSBatchComputeEnvironment_NamePrefix
=== PAUSE TestAccAWSBatchComputeEnvironment_NamePrefix
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot
=== RUN   TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
=== RUN   TestAccAWSBatchComputeEnvironment_createFargate
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargate
=== RUN   TestAccAWSBatchComputeEnvironment_createFargateSpot
=== PAUSE TestAccAWSBatchComputeEnvironment_createFargateSpot
=== RUN   TestAccAWSBatchComputeEnvironment_updateState
=== PAUSE TestAccAWSBatchComputeEnvironment_updateState
=== RUN   TestAccAWSBatchComputeEnvironment_updateServiceRole
=== PAUSE TestAccAWSBatchComputeEnvironment_updateServiceRole
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== PAUSE TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
=== RUN   TestAccAWSBatchComputeEnvironment_launchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_launchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
=== RUN   TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== PAUSE TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
=== RUN   TestAccAWSBatchComputeEnvironment_Tags
=== PAUSE TestAccAWSBatchComputeEnvironment_Tags
=== RUN   TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== PAUSE TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
=== RUN   TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== PAUSE TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== CONT  TestAccAWSBatchComputeEnvironment_basic
=== CONT  TestAccAWSBatchComputeEnvironment_updateServiceRole
=== CONT  TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (18.81s)
=== CONT  TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutIamFleetRole (19.08s)
=== CONT  TestAccAWSBatchComputeEnvironment_Tags
--- PASS: TestAccAWSBatchComputeEnvironment_basic (35.98s)
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (33.86s)
=== CONT  TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_updateServiceRole (59.89s)
=== CONT  TestAccAWSBatchComputeEnvironment_launchTemplate
--- PASS: TestAccAWSBatchComputeEnvironment_Tags (76.47s)
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (38.28s)
=== CONT  TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_Fargate (63.88s)
=== CONT  TestAccAWSBatchComputeEnvironment_NamePrefix
--- PASS: TestAccAWSBatchComputeEnvironment_UpdateLaunchTemplate (66.99s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags
--- PASS: TestAccAWSBatchComputeEnvironment_NamePrefix (38.53s)
=== CONT  TestAccAWSBatchComputeEnvironment_createEc2
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (38.38s)
=== CONT  TestAccAWSBatchComputeEnvironment_createFargateSpot
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MaxVcpus (83.60s)
=== CONT  TestAccAWSBatchComputeEnvironment_updateState
--- PASS: TestAccAWSBatchComputeEnvironment_createFargateSpot (35.86s)
=== CONT  TestAccAWSBatchComputeEnvironment_NameGenerated
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (55.68s)
=== CONT  TestAccAWSBatchComputeEnvironment_createFargate
--- PASS: TestAccAWSBatchComputeEnvironment_NameGenerated (35.91s)
=== CONT  TestAccAWSBatchComputeEnvironment_disappears
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2_DesiredVcpus_Ec2KeyPair_ImageId_ComputeResourcesTags (139.26s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage
--- PASS: TestAccAWSBatchComputeEnvironment_createFargate (37.36s)
=== CONT  TestAccAWSBatchComputeEnvironment_createSpot
--- PASS: TestAccAWSBatchComputeEnvironment_disappears (34.12s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot_AllocationStrategy_BidPercentage (39.18s)
--- PASS: TestAccAWSBatchComputeEnvironment_ComputeResources_MinVcpus (200.75s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (455.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	730.891s

ewbankkit · 2021-04-23T13:23:48Z

@gmazelier Thanks for the contribution 👏.
I went ahead and pushed some changes to your fork to get this released sooner.
The only practitioner-noticeable addition is that security_group_ids and subnets can be updated for Fargate compute resources without requiring a destruction and creation of the compute environment.

ghost · 2021-04-30T15:25:40Z

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions · 2021-05-31T02:48:28Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

gmazelier requested a review from a team as a code owner December 17, 2020 17:37

ghost added size/XS Managed by automation to categorize the size of a PR. service/batch Issues and PRs that pertain to the batch service. labels Dec 17, 2020

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 17, 2020

gmazelier changed the title ~~Add FARGATE and FARGATE_SPOT types~~ [WIP] Add FARGATE and FARGATE_SPOT types Dec 17, 2020

gmazelier marked this pull request as draft December 17, 2020 17:38

gmazelier changed the title ~~[WIP] Add FARGATE and FARGATE_SPOT types~~ [WIP] Add Fargate support to Batch compute environments Dec 17, 2020

gmazelier changed the title ~~[WIP] Add Fargate support to Batch compute environments~~ Add Fargate support to Batch compute environments Dec 20, 2020

gmazelier marked this pull request as ready for review December 20, 2020 17:25

gmazelier force-pushed the r/batch_fargate_compute_environment branch from 3646f1d to 6e9b7cf Compare January 6, 2021 10:01

Base automatically changed from master to main January 23, 2021 01:00

ewbankkit self-assigned this Apr 19, 2021

ewbankkit force-pushed the r/batch_fargate_compute_environment branch from b7f552f to 15284f2 Compare April 20, 2021 21:31

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 20, 2021

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 21, 2021

gmazelier added 3 commits April 21, 2021 17:06

Add FARGATE and FARGATE_SPOT types

a49c404

instance_type is now optional

aa363ff

instance_role is now optional

015d97e

ewbankkit added 11 commits April 21, 2021 17:08

Remove 'TestAccAWSBatchComputeEnvironment_ComputeResources_DesiredVcp…

56a2351

…us_Computed'.

ewbankkit force-pushed the r/batch_fargate_compute_environment branch from 373c4c4 to a880e91 Compare April 21, 2021 21:22

ewbankkit added 8 commits April 21, 2021 17:31

Fix terrafmt errors.

200f312

r/aws_batch_compute_environment: Mark 'compute_resources' as 'ForceNew'.

0fa2c89

r/aws_batch_compute_environment: Simplify flatten and expand.

7a3b1a6

Fix terrafmt errors.

88bfc1a

CHANGELOG additions.

f91de7c

r/aws_batch_compute_environment: Correctly handle disabling an INVALI…

bd79808

…D environment.

ewbankkit approved these changes Apr 23, 2021

View reviewed changes

ewbankkit merged commit a2dd47d into hashicorp:main Apr 23, 2021

github-actions bot added this to the v3.38.0 milestone Apr 23, 2021

ewbankkit mentioned this pull request Apr 23, 2021

r/aws_batch_compute_environment: Enforce no compute_resources block for UNMANAGED compute environments #19087

Closed

This was referenced Apr 30, 2021

service_role is required in aws_batch_compute_environment but optional in AWS.Batch.CreateComputeEnvironment #19178

Closed

Fargate compute environment is being modified on every apply, even if the state does not change, and the modification fails #19177

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Fargate support to Batch compute environments #16819

Add Fargate support to Batch compute environments #16819

gmazelier commented Dec 17, 2020 •

edited by ewbankkit

Skybound1 commented Mar 1, 2021

gmazelier commented Mar 5, 2021

Skybound1 commented Mar 5, 2021 •

edited

gmazelier commented Mar 12, 2021

ewbankkit left a comment •

edited

ewbankkit commented Apr 23, 2021

ghost commented Apr 30, 2021

github-actions bot commented May 31, 2021

Add Fargate support to Batch compute environments #16819

Add Fargate support to Batch compute environments #16819

Conversation

gmazelier commented Dec 17, 2020 • edited by ewbankkit

Community Note

Skybound1 commented Mar 1, 2021

gmazelier commented Mar 5, 2021

Skybound1 commented Mar 5, 2021 • edited

gmazelier commented Mar 12, 2021

ewbankkit left a comment • edited

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Apr 23, 2021

ghost commented Apr 30, 2021

github-actions bot commented May 31, 2021

gmazelier commented Dec 17, 2020 •

edited by ewbankkit

Skybound1 commented Mar 5, 2021 •

edited

ewbankkit left a comment •

edited