resource/aws_ram: Fix eventual consistency problems

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13494
Closes #15187
Closes #16578
Closes #17658
Closes #18332

Release note for CHANGELOG:

* resource/aws_ram_resource_share_accepter: Fix eventual consistency problems

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsRamResourceShareAccepter_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRamResourceShareAccepter_* -timeout 120m
=== RUN   TestAccAwsRamResourceShareAccepter_basic
=== PAUSE TestAccAwsRamResourceShareAccepter_basic
=== CONT  TestAccAwsRamResourceShareAccepter_basic
--- PASS: TestAccAwsRamResourceShareAccepter_basic (79.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	81.162s

$ make testacc TESTARGS='-run=TestAccAwsRamResourceShare_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRamResourceShare_* -timeout 120m
=== RUN   TestAccAwsRamResourceShareAccepter_basic
=== PAUSE TestAccAwsRamResourceShareAccepter_basic
=== RUN   TestAccAwsRamResourceShare_basic
=== PAUSE TestAccAwsRamResourceShare_basic
=== RUN   TestAccAwsRamResourceShare_AllowExternalPrincipals
=== PAUSE TestAccAwsRamResourceShare_AllowExternalPrincipals
=== RUN   TestAccAwsRamResourceShare_Name
=== PAUSE TestAccAwsRamResourceShare_Name
=== RUN   TestAccAwsRamResourceShare_Tags
=== PAUSE TestAccAwsRamResourceShare_Tags
=== CONT  TestAccAwsRamResourceShareAccepter_basic
=== CONT  TestAccAwsRamResourceShare_Name
=== CONT  TestAccAwsRamResourceShare_AllowExternalPrincipals
=== CONT  TestAccAwsRamResourceShare_Tags
=== CONT  TestAccAwsRamResourceShare_basic
--- PASS: TestAccAwsRamResourceShare_basic (42.74s)
--- PASS: TestAccAwsRamResourceShare_Name (69.01s)
--- PASS: TestAccAwsRamResourceShare_AllowExternalPrincipals (69.10s)
--- PASS: TestAccAwsRamResourceShareAccepter_basic (90.10s)
--- PASS: TestAccAwsRamResourceShare_Tags (92.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.688s

Thank you for your review! 👍

[dthvt]

Not a golang expert, but is there a reason i is used here and then immediately assigned to invitation instead of just using invitation, err := ?

[shuheiktgw]

No, actually you cannot substitute the returned output for the outer invitation using :=...

[dthvt]

Ah, TIL. Thanks!

[pkleanthous]

Hey guys,

Can you please merge this PR?

[datacenter-dylan]

Any estimate on when we can expect this to be merged?

[lorengordon]

This PR might also fix the race condition I reported here: #18332

[lorengordon]

@YakDriver I built the aws provider using this branch and can confirm it does appear to also address the race condition I reported in #18332 (and probably #17658 and #15187, as well as the two linked in the PR description #13494 and #16578). At least, I looped over 100 builds without encountering the failure...

[YakDriver]

@shuheiktgw My friend, thank you for this excellent PR. Unfortunately, I believe due to account settings changes on our side, I cannot currently test this properly. Rather than wait for us to straighten out our account problems, if you (and @lorengordon) can help test/fix my new changes, that would be very helpful! Make sure to pull my latest changes to your branch. Please let me know if you have any questions.

What I'm currently getting from the acceptance tests (GovCloud):

--- FAIL: TestAccAwsRamResourceAssociation_basic (18.17s)        // failure predates this PR (Hashi test account settings?)
--- FAIL: TestAccAwsRamResourceAssociation_disappears (17.97s)   // failure predates this PR (Hashi test account settings?)
--- FAIL: TestAccAwsRamResourceShareAccepter_basic (14.37s)      // failure predates this PR (Hashi test account settings?)
--- FAIL: TestAccAwsRamResourceShareAccepter_disappears (14.72s) // new test (Hashi test account settings?)
--- PASS: TestAccAwsRamPrincipalAssociation_basic (25.72s)
--- PASS: TestAccAwsRamPrincipalAssociation_disappears (22.62s)
--- PASS: TestAccAwsRamResourceShare_AllowExternalPrincipals (36.17s)
--- PASS: TestAccAwsRamResourceShare_basic (22.94s)
--- PASS: TestAccAwsRamResourceShare_Name (36.05s)
--- PASS: TestAccAwsRamResourceShare_Tags (48.68s)

Output from acceptance tests on commercial (us-west-2):

--- FAIL: TestAccAwsRamResourceAssociation_basic (15.42s)         // failure predates this PR (Hashi test account settings?)
--- FAIL: TestAccAwsRamResourceAssociation_disappears (15.35s)    // failure predates this PR (Hashi test account settings?)
--- FAIL: TestAccAwsRamResourceShareAccepter_basic (11.42s)       // failure predates this PR (Hashi test account settings?)
--- FAIL: TestAccAwsRamResourceShareAccepter_disappears (130.89s) // new test (Hashi test account settings?)
--- PASS: TestAccAwsRamPrincipalAssociation_basic (20.38s)
--- PASS: TestAccAwsRamPrincipalAssociation_disappears (14.36s)   // sometimes fails
--- PASS: TestAccAwsRamResourceShare_AllowExternalPrincipals (26.88s)
--- PASS: TestAccAwsRamResourceShare_basic (17.45s)
--- PASS: TestAccAwsRamResourceShare_Name (27.91s)
--- PASS: TestAccAwsRamResourceShare_Tags (35.73s)

[lorengordon]

@YakDriver running my test now, the loop takes a long time, so probably will report back tomorrow.

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[lorengordon]

fwiw, closing the loop, finally made it through my looped tests for the race condition. didn't encounter it even once in 100 executions of the test config, so 🤞 i'm pretty sure this is solid!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.