Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_s3_bucket_inventory: Prevent crashes with empty destination, filter, and schedule configuration blocks #17055

Merged
merged 1 commit into from Jan 12, 2021

Conversation

bflad
Copy link
Member

@bflad bflad commented Jan 12, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16952
Reference: #16953
Reference: https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/data-handling-and-conversion.md#root-typelist-of-resource-and-aws-structure

Release note for CHANGELOG:

resource/aws_s3_bucket_inventory: Prevent crashes with empty destination, filter, and schedule configuration blocks

Output from acceptance testing:

--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (26.70s)
--- PASS: TestAccAWSS3BucketInventory_basic (26.73s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (27.01s)

…ion, filter, and schedule configuration blocks

Reference: #16952
Reference: #16953

Output from acceptance testing:

```
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (26.70s)
--- PASS: TestAccAWSS3BucketInventory_basic (26.73s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (27.01s)
```
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jan 12, 2021
@bflad bflad requested a review from a team as a code owner January 12, 2021 01:40
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. labels Jan 12, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@bflad bflad merged commit e6cc362 into master Jan 12, 2021
@bflad bflad deleted the b-aws_s3_bucket_inventory-prevent-panics branch January 12, 2021 03:03
@github-actions github-actions bot added this to the v3.24.0 milestone Jan 12, 2021
bflad added a commit that referenced this pull request Jan 12, 2021
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crashes on trying to apply s3 bucket inventory configs
2 participants