Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Launch AWS Marketplace produccts (AMIs, containers) in linked AWS accounts #17146

Closed
gjoshevski opened this issue Jan 16, 2021 · 8 comments · Fixed by #29741
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/licensemanager Issues and PRs that pertain to the licensemanager service.
Milestone

Comments

@gjoshevski
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently if you want to use AMIs or Containers from AWS Marketplace in any of your AWS accounts members of the same AWS Organization you have to go to the web UI and subscribe to the products manually.

You can now manage entitlements for product in AWS Marketplace within AWS License Manager, meaning if you have subscribed to the product in one of you AWS accounts, now you can share the entitlement and the same AMI or container product can be launched in any AWS Account member of the org that has received the grant.

References

https://docs.aws.amazon.com/license-manager/latest/userguide/granted-licenses.html

@gjoshevski gjoshevski added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 16, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 16, 2021
@breathingdust breathingdust added service/licensemanager Issues and PRs that pertain to the licensemanager service. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@YakDriver
Copy link
Member

This looks like maybe 4-5 resources, after a quick look. AWS SDK for Go v1 operations:

A (aws_licensemanager_grant?)

B (aws_licensemanager_license_grants data source)

C (aws_licensemanager_grant_version?)

D (aws_licensemanager_grant_accepter?)

@Jamie-Leon
Copy link

Any updates on when this will be made available?

@brittandeyoung
Copy link
Collaborator

@YakDriver I have openned up a pull request for the aws_licensemanager_grant resource. From looking at the API, it looked like the CreateGrantVersion API was really just used for updating the name or allowed_operations for a grant. Because of that, I did not write a seperate grant_version resource. I Would like to make sure that this aligns with your thoughts on this resource.

@brittandeyoung
Copy link
Collaborator

I also added the aws_licenasemanager_grant_accepter to the same PR

@brittandeyoung
Copy link
Collaborator

brittandeyoung commented Mar 8, 2023

@gjoshevski and @YakDriver I have updated the PR with the following:

New Resources:

  • aws_licensemanager_grant - Allow sharing a license with another account.
  • aws_licensemanager_grant_accepter - Accepting a shared license in the target account.

New Datasources:

  • aws_licensemanager_received_license - A data source to get detailed data about an accepted AWS License from the market place.
  • aws_licensemanager_received_licenses - A data source to get a list of ARNs for accepted AWS market place licenses that match a filter.
  • aws_licensemanager_grants - A data source to get a list of grant ARNs for the account matching a filter.

I believe that these combination of resources and data sources completes what is being requested in this issue. Please let me know if that is not that case.

@github-actions github-actions bot added this to the v4.58.0 milestone Mar 9, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/licensemanager Issues and PRs that pertain to the licensemanager service.
Projects
None yet
5 participants