Fix change detection relating to vpc_config #17610

grahamhar · 2021-02-14T11:34:21Z

As reported in #17385 a change is detected in vpc_config when there are no changes, this is caused by an issue in hashicorp/terraform-plugin-sdk#617. The PR to provide a fix is not getting any traction.

On further debuging the issue is caused by the nested elements within the vpc_config stuct being of
type set which needs the use of Equal rather than reflect.DeepEqual to
test for differences.

We can work around this bug by testing for changes in the two fields
within vpc_config struct independantly as when the item passed to HasChanges is
a Set it is tested correctly.

I couldn't find a quick way to add tests for this, so I will work on this while the PR is in draft state

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

grahamhar · 2021-02-14T11:36:47Z

@gdavison I'd appreciate some feedback on this to see if it is an appropriate approach to work around the issue in the dependant package and also some advice on the approach to adding some unit tests for this.

I just noticed there is a PR already open trying to do the exact same thing. Is there any chance either of them could be reviewed/merged as the related issue is quite impacting

grahamhar · 2021-02-15T07:09:24Z

@gdavison I'd appreciate some feedback on this to see if it is an appropriate approach to work around the issue in the dependant package and also some advice on the approach to adding some unit tests for this.

I just noticed there is a PR already open trying to do the exact same thing. Is there any chance either of them could be reviewed/merged as the related issue is quite impacting

I've added acceptance tests to cover this as I couldn't work out how to add unit tests for it. However, the tests fail as the plan shows the qualified_arn and version fields will be computed (See below). If I add ExpectNonEmptyPlan: true then the test does correctly show a new version is not published as expected.

=== PAUSE TestAccAWSLambdaFunction_VPC_publish_No_Changes
=== CONT  TestAccAWSLambdaFunction_VPC_publish_No_Changes
    resource_aws_lambda_function_test.go:1297: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_lambda_function.test will be updated in-place
          ~ resource "aws_lambda_function" "test" {
                arn                            = "arn:aws:lambda:eu-central-1:838300751538:function:tf_acc_lambda_func_vpc_w_invc_a1cp1usw"
                filename                       = "test-fixtures/lambdatest.zip"
                function_name                  = "tf_acc_lambda_func_vpc_w_invc_a1cp1usw"
                handler                        = "exports.example"
                id                             = "tf_acc_lambda_func_vpc_w_invc_a1cp1usw"
                invoke_arn                     = "arn:aws:apigateway:eu-central-1:lambda:path/2015-03-31/functions/arn:aws:lambda:eu-central-1:838300751538:function:tf_acc_lambda_func_vpc_w_invc_a1cp1usw/invocations"
                last_modified                  = "2021-02-15T06:37:19.457+0000"
                memory_size                    = 128
                package_type                   = "Zip"
                publish                        = true
              ~ qualified_arn                  = "arn:aws:lambda:eu-central-1:838300751538:function:tf_acc_lambda_func_vpc_w_invc_a1cp1usw:1" -> (known after apply)
                reserved_concurrent_executions = -1
                role                           = "arn:aws:iam::838300751538:role/tf_acc_role_lambda_func_vpc_w_invc_a1cp1usw"
                runtime                        = "nodejs12.x"
                source_code_hash               = "Ux/n9CP8l+7Ht0tICw0QPs0yLdC1b+1nJ9K5MZR9ENw="
                source_code_size               = 342
                timeout                        = 3
              ~ version                        = "1" -> (known after apply)
        
                tracing_config {
                    mode = "PassThrough"
                }
        
                vpc_config {
                    security_group_ids = [
                        "sg-0c44ffd0d2d8971af",
                    ]
                    subnet_ids         = [
                        "subnet-02aefd3f3b98ad6ce",
                    ]
                    vpc_id             = "vpc-08ee64c9927d6c6fa"
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSLambdaFunction_VPC_publish_No_Changes (192.06s)

As reported in #17385 a change i detected in vpc_config when there are no changes, this is caused by an issue in hashicorp/terraform-plugin-sdk#617 The PR to provide a fix is not getting any traction. On further debuging the issue is caused by the nested elements being of type set which needs the use of Equal rather than reflect.DeepEqual to test for differences. We can work around this bug by testing for changes in the two fields within vpc_config independantly as when the item passed to HasChanges is a Set it is tested correctly.

github-actions · 2021-03-27T10:12:28Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

github-actions · 2021-03-27T10:12:28Z

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

grahamhar · 2021-03-27T13:50:33Z

This is now working but there is a failure in the acceptence test I added that makes sure a new version is published when the vpc config changes. The failure in the test seems to be due to the fact one of the two ENI's never get released so the associated security group can't delete. My assumption is this is related to the previously published version not being deleted correctly or that this doesn't break the association to the ENI (See below). I'm unsure how I can proceed with this now

=== RUN   TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== CONT  TestAccAWSLambdaFunction_VPC_publish_Has_Changes
    testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Lambda ENIs using Security Group (sg-0335701dabaee2ea8): error waiting for Lambda V2N ENI (eni-04c5843db2295bf6f) to become available for detachment: timeout while waiting for state to become 'available' (last state: 'in-use', timeout: 45m0s)
        
        
        
        Error: error deleting Lambda ENIs using subnet (subnet-069361f4f22c26791): error waiting for Lambda V2N ENI (eni-04c5843db2295bf6f) to become available for detachment: timeout while waiting for state to become 'available' (last state: 'in-use', timeout: 45m0s)
        
        
--- FAIL: TestAccAWSLambdaFunction_VPC_publish_Has_Changes (2971.59s)

grahamhar · 2021-03-27T14:22:55Z

This is now working but there is a failure in the acceptence test I added that makes sure a new version is published when the vpc config changes. The failure in the test seems to be due to the fact one of the two ENI's never get released so the associated security group can't delete. My assumption is this is related to the previously published version not being deleted correctly or that this doesn't break the association to the ENI (See below). I'm unsure how I can proceed with this now
=== RUN   TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== CONT  TestAccAWSLambdaFunction_VPC_publish_Has_Changes
    testing_new.go:63: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Lambda ENIs using Security Group (sg-0335701dabaee2ea8): error waiting for Lambda V2N ENI (eni-04c5843db2295bf6f) to become available for detachment: timeout while waiting for state to become 'available' (last state: 'in-use', timeout: 45m0s)
        
        
        
        Error: error deleting Lambda ENIs using subnet (subnet-069361f4f22c26791): error waiting for Lambda V2N ENI (eni-04c5843db2295bf6f) to become available for detachment: timeout while waiting for state to become 'available' (last state: 'in-use', timeout: 45m0s)
        
        
--- FAIL: TestAccAWSLambdaFunction_VPC_publish_Has_Changes (2971.59s)
 

Refactoring the test to remove the vpc config works around the above issue

=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_basic
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_basic
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_basic
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (107.67s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (45.75s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (54.37s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (83.99s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (83.38s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (67.65s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (71.40s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (155.67s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn (55.84s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (80.88s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (90.33s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (51.36s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (47.56s)
=== RUN TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest
=== PAUSE TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest
=== CONT TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (153.17s)
=== RUN TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== CONT TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (68.65s)
=== RUN TestAccAWSLambdaFunction_UnpublishedCodeUpdate
=== PAUSE TestAccAWSLambdaFunction_UnpublishedCodeUpdate
=== CONT TestAccAWSLambdaFunction_UnpublishedCodeUpdate
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (83.86s)
=== RUN TestAccAWSLambdaFunction_disappears
=== PAUSE TestAccAWSLambdaFunction_disappears
=== CONT TestAccAWSLambdaFunction_disappears
--- PASS: TestAccAWSLambdaFunction_disappears (49.68s)
=== RUN TestAccAWSLambdaFunction_codeSigningConfig
=== PAUSE TestAccAWSLambdaFunction_codeSigningConfig
=== CONT TestAccAWSLambdaFunction_codeSigningConfig
resource_aws_signer_signing_profile_test.go:185: skipping acceptance testing: Signing Platform (AWSLambda-SHA384-ECDSA) not found
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.47s)

Test ignored.
=== RUN TestAccAWSLambdaFunction_concurrency
=== PAUSE TestAccAWSLambdaFunction_concurrency
=== CONT TestAccAWSLambdaFunction_concurrency
--- PASS: TestAccAWSLambdaFunction_concurrency (177.90s)
=== RUN TestAccAWSLambdaFunction_concurrencyCycle
=== PAUSE TestAccAWSLambdaFunction_concurrencyCycle
=== CONT TestAccAWSLambdaFunction_concurrencyCycle
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (198.30s)
=== RUN TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
=== CONT TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (22.80s)
=== RUN TestAccAWSLambdaFunction_envVariables
=== PAUSE TestAccAWSLambdaFunction_envVariables
=== CONT TestAccAWSLambdaFunction_envVariables
--- PASS: TestAccAWSLambdaFunction_envVariables (152.19s)
=== RUN TestAccAWSLambdaFunction_Environment_Variables_NoValue
=== PAUSE TestAccAWSLambdaFunction_Environment_Variables_NoValue
=== CONT TestAccAWSLambdaFunction_Environment_Variables_NoValue
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (48.01s)
=== RUN TestAccAWSLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccAWSLambdaFunction_encryptedEnvVariables
=== CONT TestAccAWSLambdaFunction_encryptedEnvVariables
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (68.35s)
=== RUN TestAccAWSLambdaFunction_versioned
=== PAUSE TestAccAWSLambdaFunction_versioned
=== CONT TestAccAWSLambdaFunction_versioned
--- PASS: TestAccAWSLambdaFunction_versioned (64.83s)
=== RUN TestAccAWSLambdaFunction_versionedUpdate
=== PAUSE TestAccAWSLambdaFunction_versionedUpdate
=== CONT TestAccAWSLambdaFunction_versionedUpdate
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (122.21s)
=== RUN TestAccAWSLambdaFunction_enablePublish
=== PAUSE TestAccAWSLambdaFunction_enablePublish
=== CONT TestAccAWSLambdaFunction_enablePublish
--- PASS: TestAccAWSLambdaFunction_enablePublish (197.70s)
=== RUN TestAccAWSLambdaFunction_disablePublish
=== PAUSE TestAccAWSLambdaFunction_disablePublish
=== CONT TestAccAWSLambdaFunction_disablePublish
--- PASS: TestAccAWSLambdaFunction_disablePublish (132.21s)
=== RUN TestAccAWSLambdaFunction_DeadLetterConfig
=== PAUSE TestAccAWSLambdaFunction_DeadLetterConfig
=== CONT TestAccAWSLambdaFunction_DeadLetterConfig
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (562.07s)
=== RUN TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== PAUSE TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== CONT TestAccAWSLambdaFunction_DeadLetterConfigUpdated
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (677.48s)
=== RUN TestAccAWSLambdaFunction_nilDeadLetterConfig
=== PAUSE TestAccAWSLambdaFunction_nilDeadLetterConfig
=== CONT TestAccAWSLambdaFunction_nilDeadLetterConfig
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (643.13s)
=== RUN TestAccAWSLambdaFunction_FileSystemConfig
=== PAUSE TestAccAWSLambdaFunction_FileSystemConfig
=== CONT TestAccAWSLambdaFunction_FileSystemConfig
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (2403.05s)
=== RUN TestAccAWSLambdaFunction_imageConfig
=== PAUSE TestAccAWSLambdaFunction_imageConfig
=== CONT TestAccAWSLambdaFunction_imageConfig
resource_aws_lambda_function_test.go:914: AWS_LAMBDA_IMAGE_LATEST_ID, AWS_LAMBDA_IMAGE_V1_ID and AWS_LAMBDA_IMAGE_V2_ID env vars must be set for Lambda Container Image Support acceptance tests.
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.00s)

Test ignored.
=== RUN TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== CONT TestAccAWSLambdaFunction_tracingConfig
--- PASS: TestAccAWSLambdaFunction_tracingConfig (809.68s)
=== RUN TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables
=== PAUSE TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables
=== CONT TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (812.92s)
=== RUN TestAccAWSLambdaFunction_Layers
=== PAUSE TestAccAWSLambdaFunction_Layers
=== CONT TestAccAWSLambdaFunction_Layers
--- PASS: TestAccAWSLambdaFunction_Layers (897.75s)
=== RUN TestAccAWSLambdaFunction_LayersUpdate
=== PAUSE TestAccAWSLambdaFunction_LayersUpdate
=== CONT TestAccAWSLambdaFunction_LayersUpdate
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (922.13s)
=== RUN TestAccAWSLambdaFunction_VPC
=== PAUSE TestAccAWSLambdaFunction_VPC
=== CONT TestAccAWSLambdaFunction_VPC
--- PASS: TestAccAWSLambdaFunction_VPC (1094.41s)
=== RUN TestAccAWSLambdaFunction_VPCRemoval
=== PAUSE TestAccAWSLambdaFunction_VPCRemoval
=== CONT TestAccAWSLambdaFunction_VPCRemoval
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1098.85s)
=== RUN TestAccAWSLambdaFunction_VPCUpdate
=== PAUSE TestAccAWSLambdaFunction_VPCUpdate
=== CONT TestAccAWSLambdaFunction_VPCUpdate
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1131.33s)
=== RUN TestAccAWSLambdaFunction_VPC_withInvocation
=== PAUSE TestAccAWSLambdaFunction_VPC_withInvocation
=== CONT TestAccAWSLambdaFunction_VPC_withInvocation
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (564.09s)
=== RUN TestAccAWSLambdaFunction_VPC_publish_No_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_No_Changes
=== CONT TestAccAWSLambdaFunction_VPC_publish_No_Changes
--- PASS: TestAccAWSLambdaFunction_VPC_publish_No_Changes (459.47s)
=== RUN TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== CONT TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== CONT TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== RUN TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== CONT TestAccAWSLambdaFunction_VPC_publish_Has_Changes
--- PASS: TestAccAWSLambdaFunction_VPC_publish_Has_Changes (610.49s)
=== RUN TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies
=== PAUSE TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies
=== CONT TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (208.06s)
=== RUN TestAccAWSLambdaFunction_EmptyVpcConfig
=== PAUSE TestAccAWSLambdaFunction_EmptyVpcConfig
=== CONT TestAccAWSLambdaFunction_EmptyVpcConfig
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (75.87s)
=== RUN TestAccAWSLambdaFunction_s3
=== PAUSE TestAccAWSLambdaFunction_s3
=== CONT TestAccAWSLambdaFunction_s3
--- PASS: TestAccAWSLambdaFunction_s3 (83.59s)
=== RUN TestAccAWSLambdaFunction_localUpdate
=== PAUSE TestAccAWSLambdaFunction_localUpdate
=== CONT TestAccAWSLambdaFunction_localUpdate
--- PASS: TestAccAWSLambdaFunction_localUpdate (244.58s)
=== RUN TestAccAWSLambdaFunction_localUpdate_nameOnly
=== PAUSE TestAccAWSLambdaFunction_localUpdate_nameOnly
=== CONT TestAccAWSLambdaFunction_localUpdate_nameOnly
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (376.39s)
=== RUN TestAccAWSLambdaFunction_s3Update_basic
=== PAUSE TestAccAWSLambdaFunction_s3Update_basic
=== CONT TestAccAWSLambdaFunction_s3Update_basic
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (99.39s)
=== RUN TestAccAWSLambdaFunction_s3Update_unversioned
=== PAUSE TestAccAWSLambdaFunction_s3Update_unversioned
=== CONT TestAccAWSLambdaFunction_s3Update_unversioned
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (104.63s)
=== RUN TestAccAWSLambdaFunction_tags
=== PAUSE TestAccAWSLambdaFunction_tags
=== CONT TestAccAWSLambdaFunction_tags
--- PASS: TestAccAWSLambdaFunction_tags (142.71s)
=== RUN TestAccAWSLambdaFunction_runtimes
=== PAUSE TestAccAWSLambdaFunction_runtimes
=== CONT TestAccAWSLambdaFunction_runtimes
--- PASS: TestAccAWSLambdaFunction_runtimes (409.64s)
PASS

Removing the VPC config is still a valid vpc config change and works around the ENI deltion issue.

joscha · 2021-05-27T03:04:20Z

any chance to get this in?

gdavison

Looks good 🚀

--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (59.65s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (66.23s)
--- PASS: TestAccAWSLambdaFunction_basic (68.01s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (74.47s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (87.93s)
--- PASS: TestAccAWSLambdaFunction_disappears (94.90s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (99.10s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (40.51s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (102.81s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionName_Arn (103.54s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (104.25s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (33.89s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (144.65s)
--- PASS: TestAccAWSLambdaFunction_concurrency (145.29s)
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.89s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (148.40s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (149.49s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (149.77s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (92.51s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (163.70s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (173.54s)
--- PASS: TestAccAWSLambdaFunction_versioned (92.87s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (194.46s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (194.58s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (199.96s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (135.93s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (125.24s)
--- PASS: TestAccAWSLambdaFunction_Layers (78.37s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (126.09s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (127.94s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (85.17s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (147.22s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (157.89s)
--- PASS: TestFlattenLambdaImageConfigShouldNotFailWithEmptyImageConfig (0.00s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (108.73s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (58.25s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (108.42s)
--- PASS: TestAccAWSLambdaFunction_s3 (51.81s)
--- PASS: TestAccAWSLambdaFunction_envVariables (197.77s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (57.60s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (64.50s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (66.21s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (62.70s)
--- PASS: TestAccAWSLambdaFunction_tags (73.68s)
--- PASS: TestAccAWSLambdaFunction_VPC (266.70s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (257.83s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (268.26s)
--- PASS: TestAccAWSLambdaFunction_runtimes (327.80s)
--- PASS: TestAccAWSLambdaFunction_VPC_publish_No_Changes (441.95s)
--- PASS: TestAccAWSLambdaFunction_VPC_publish_Has_Changes (519.38s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (1603.57s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1795.10s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (1953.35s)

github-actions · 2021-06-11T12:24:04Z

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-07-12T02:06:44Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ghost added size/XS Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. labels Feb 14, 2021

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 14, 2021

ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 15, 2021

kitos9112 mentioned this pull request Feb 17, 2021

Missing Module idempotency when re-applying to non-changing Lambda within VPC terraform-aws-modules/terraform-aws-lambda#104

Closed

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 27, 2021

grahamhar changed the base branch from master to main March 27, 2021 10:18

Add acceptance tests

ee8fb45

ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 27, 2021

grahamhar marked this pull request as ready for review March 27, 2021 13:50

grahamhar requested a review from a team as a code owner March 27, 2021 13:50

Refactor test to work around ENI deletion issue

622a2f4

Removing the VPC config is still a valid vpc config change and works around the ENI deltion issue.

grahamhar mentioned this pull request Apr 21, 2021

Fix change detection hashicorp/terraform-plugin-sdk#643

Closed

This was referenced Apr 28, 2021

[REGRESSION] v3.13.0 causes perpetual diff of resources containing lambda version number #15952

Closed

aws_lambda_function always updates even with no changes #9786

Closed

ewbankkit mentioned this pull request May 7, 2021

Workaround attempt for perpetual diff in lambda with vpc_config #16124

Closed

gdavison self-assigned this Jun 4, 2021

gdavison approved these changes Jun 4, 2021

View reviewed changes

gdavison added a commit that referenced this pull request Jun 4, 2021

Merge pull request #17610 from grahamhar/master

8beaad3

gdavison merged commit 622a2f4 into hashicorp:main Jun 4, 2021

github-actions bot added this to the v3.45.0 milestone Jun 4, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021

breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix change detection relating to vpc_config #17610

Fix change detection relating to vpc_config #17610

grahamhar commented Feb 14, 2021

grahamhar commented Feb 14, 2021 •

edited

grahamhar commented Feb 15, 2021

github-actions bot commented Mar 27, 2021

github-actions bot commented Mar 27, 2021

grahamhar commented Mar 27, 2021 •

edited

grahamhar commented Mar 27, 2021

joscha commented May 27, 2021

gdavison left a comment

github-actions bot commented Jun 11, 2021

github-actions bot commented Jul 12, 2021

Fix change detection relating to vpc_config #17610

Fix change detection relating to vpc_config #17610

Conversation

grahamhar commented Feb 14, 2021

Community Note

grahamhar commented Feb 14, 2021 • edited

grahamhar commented Feb 15, 2021

github-actions bot commented Mar 27, 2021

github-actions bot commented Mar 27, 2021

grahamhar commented Mar 27, 2021 • edited

grahamhar commented Mar 27, 2021

joscha commented May 27, 2021

gdavison left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 11, 2021

github-actions bot commented Jul 12, 2021

grahamhar commented Feb 14, 2021 •

edited

grahamhar commented Mar 27, 2021 •

edited