Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RDS instances created from Snapshots cannot be updated anymore #17722

Closed
konstl000 opened this issue Feb 19, 2021 · 3 comments · Fixed by #17755
Closed

The RDS instances created from Snapshots cannot be updated anymore #17722

konstl000 opened this issue Feb 19, 2021 · 3 comments · Fixed by #17755
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@konstl000
Copy link

konstl000 commented Feb 19, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.14.7
+ provider registry.terraform.io/hashicorp/aws v3.29.0

Affected Resource(s)

  • aws_db_instance

Terraform Configuration Files

resource "aws_db_instance" "db" {
  allocated_storage       = 100
  storage_type            = "gp2"
  engine                  = "postgres"
  engine_version          = "11.5"
  instance_class          = "db.t3.micro"
  vpc_security_group_ids  = ["sg-EXISTING_SG"]
  db_subnet_group_name    = aws_db_subnet_group.db_sg.name
  parameter_group_name    = "default.postgres11"
  deletion_protection     = false
  skip_final_snapshot     = true
  snapshot_identifier     = "EXISTING_SNAPSHOT"
  tags                    = {
    "foo" = "bar"
  }
  identifier              = "bugcatcher"
  maintenance_window      = "Sun:00:00-Sun:08:00"
}
resource "aws_db_subnet_group" "db_sg" {
  name                    = "bugcatcher"
  subnet_ids              = ["EXISTING_SUBNETS"]
  tags                    = {
    "foo" = "bar"
  }
}

Debug Output

https://gist.github.com/konstl000/3261f63f77c4c3587b6872282ede667b

Panic Output

Expected Behavior

On the first run, terraform successfully creates a DB instance from the snapshot provided. After this, terraform plan should return the "Infrastructure is up to date" message.

Actual Behavior

On the first run, terraform successfully creates a DB instance from the snapshot provided. After this, terraform plan exits with a following error message:

Error: 1 error occurred:
        * name attribute is not supported with snapshot_identifier when engine is postgres



  on bug.tf line 1, in resource "aws_db_instance" "db":
   1: resource "aws_db_instance" "db" {

Steps to Reproduce

  1. terraform apply

  2. terraform plan -out plan

References

@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Feb 19, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2021
@ewbankkit
Copy link
Contributor

@konstl000 Thanks for raising this issue.
It has already been noticed in #17712. I'm going to close this one as a duplicate so that we can concentrate discussion in the linked issue.
Please add any additional comments there.

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 20, 2021
@YakDriver YakDriver reopened this Feb 23, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 23, 2021
@anGie44 anGie44 modified the milestones: v3.30.0, v3.29.1 Feb 23, 2021
@ghost
Copy link

ghost commented Feb 23, 2021

This has been released in version 3.29.1 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants