r/aws_appmesh_virtual_node: Support mutual TLS authentication #18127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
ewbankkit
changed the title
2 tasks
ewbankkit
changed the title
DrFaust92
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
LGTM
--- PASS: TestAccAWSAppmesh_serial (1270.44s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode (1270.44s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (82.96s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (181.97s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (114.47s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (32.03s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (118.75s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (156.02s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (70.81s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (72.45s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (44.84s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (70.68s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (70.13s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (68.90s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (72.70s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (71.93s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (41.81s)
Acceptance test output:
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh_serial/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh_serial/VirtualNode -timeout 180m
=== RUN TestAccAWSAppmesh_serial
=== RUN TestAccAWSAppmesh_serial/VirtualNode
=== RUN TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerValidation
=== RUN TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
--- PASS: TestAccAWSAppmesh_serial (544.67s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode (544.67s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (102.13s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (28.79s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (41.77s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.61s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (29.12s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (29.26s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (72.96s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (17.21s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (28.92s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (29.14s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (28.98s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (30.13s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (13.07s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (56.67s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.63s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 544.783s
ewbankkit
force-pushed
the
f-aws_appmesh_virtual_node-mutual-tls
branch
from
5b0223f
to
2878bd8
Compare
|
LGTM 🚀 Thanks @ewbankkit! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh_serial/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh_serial/VirtualNode -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.0
=== RUN TestAccAWSAppmesh_serial
=== RUN TestAccAWSAppmesh_serial/VirtualNode
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN TestAccAWSAppmesh_serial/VirtualNode/listenerValidation
=== RUN TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN TestAccAWSAppmesh_serial/VirtualNode/logging
--- PASS: TestAccAWSAppmesh_serial (498.96s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode (498.96s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (27.08s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (115.27s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (25.25s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (25.09s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (24.80s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (24.03s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (24.97s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (62.66s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (24.08s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (36.53s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (13.77s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (11.17s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (46.08s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (13.99s)
--- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (24.19s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 501.717s |
|
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #17481.
Output from acceptance testing: