resource/aws_datasync_location_s3: Add agent_arns and s3_storage_class arguments

[gazoakley]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15418

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN   TestAccAWSDataSyncLocationS3_S3StorageClass
=== PAUSE TestAccAWSDataSyncLocationS3_S3StorageClass
=== RUN   TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN   TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_basic
=== CONT  TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_disappears
=== CONT  TestAccAWSDataSyncLocationS3_S3StorageClass
--- PASS: TestAccAWSDataSyncLocationS3_S3StorageClass (47.20s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (55.32s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (60.42s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (136.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	138.004s

[cesarpball]

Is this gonna be merged soon?

[ewbankkit]

s3_storage_class added via #19190.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN   TestAccAWSDataSyncLocationS3_storageclass
=== PAUSE TestAccAWSDataSyncLocationS3_storageclass
=== RUN   TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN   TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_basic
=== CONT  TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_storageclass
=== CONT  TestAccAWSDataSyncLocationS3_disappears
--- PASS: TestAccAWSDataSyncLocationS3_storageclass (30.68s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (38.83s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (42.75s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (83.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.734s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncLocationS3_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationS3_ -timeout 180m
=== RUN   TestAccAWSDataSyncLocationS3_basic
=== PAUSE TestAccAWSDataSyncLocationS3_basic
=== RUN   TestAccAWSDataSyncLocationS3_storageclass
=== PAUSE TestAccAWSDataSyncLocationS3_storageclass
=== RUN   TestAccAWSDataSyncLocationS3_disappears
=== PAUSE TestAccAWSDataSyncLocationS3_disappears
=== RUN   TestAccAWSDataSyncLocationS3_Tags
=== PAUSE TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_basic
=== CONT  TestAccAWSDataSyncLocationS3_Tags
=== CONT  TestAccAWSDataSyncLocationS3_disappears
=== CONT  TestAccAWSDataSyncLocationS3_storageclass
--- PASS: TestAccAWSDataSyncLocationS3_storageclass (33.96s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (40.00s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (47.30s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (93.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.063s

[ghost]

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.