resource/aws_route53_resolver_firewall_rule: Add new resource

[gazoakley]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18520

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRule_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRule_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRule_block
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_block
=== RUN   TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccAWSRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_block
=== CONT  TestAccAWSRoute53ResolverFirewallRule_blockOverride
--- PASS: TestAccAWSRoute53ResolverFirewallRule_disappears (96.17s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_block (98.79s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_blockOverride (99.04s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_basic (99.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	103.330s

[gazoakley]

Based on #18558 - will rebase if necessary after review

[gazoakley]

Hi @ewbankkit - was about to make those same changes myself 😄 . The sweeper also needs fixing - I'll take a look at that shortly

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRule_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRule_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRule_block
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_block
=== RUN   TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccAWSRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRule_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRule_blockOverride
=== CONT  TestAccAWSRoute53ResolverFirewallRule_block
--- PASS: TestAccAWSRoute53ResolverFirewallRule_disappears (76.91s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_block (78.08s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_basic (79.02s)
--- PASS: TestAccAWSRoute53ResolverFirewallRule_blockOverride (79.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.384s

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.