Subnet nacl association #18807

geofflancaster · 2021-04-12T21:58:37Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12364
Closes #16660
Closes #12175
Supersedes #1034

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccNetworkAclAssociation'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccNetworkAclAssociation -timeout 120m
=== RUN   TestAccNetworkAclAssociation_basic
--- PASS: TestAccNetworkAclAssociation_basic (23.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.454s

YakDriver · 2021-04-15T17:10:16Z

@geofflancaster At first glance, this PR looks great! Thank you. Hopefully we'll have a chance to do a careful review and merge soon. Thank you for providing the implementation, tests, and documentation! 🎉

geofflancaster · 2021-05-10T23:18:49Z

@YakDriver any updates on this?

geofflancaster · 2021-08-06T20:35:33Z

Bump.

zhelding · 2021-10-19T16:38:29Z

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

…letion. Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACL_ PKG=ec2 ACCTEST_PARALLELISM=5 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccEC2NetworkACL_' -timeout 180m === RUN TestAccEC2NetworkACL_basic === PAUSE TestAccEC2NetworkACL_basic === RUN TestAccEC2NetworkACL_disappears === PAUSE TestAccEC2NetworkACL_disappears === RUN TestAccEC2NetworkACL_tags === PAUSE TestAccEC2NetworkACL_tags === RUN TestAccEC2NetworkACL_Egress_mode === PAUSE TestAccEC2NetworkACL_Egress_mode === RUN TestAccEC2NetworkACL_Ingress_mode === PAUSE TestAccEC2NetworkACL_Ingress_mode === RUN TestAccEC2NetworkACL_egressAndIngressRules === PAUSE TestAccEC2NetworkACL_egressAndIngressRules === RUN TestAccEC2NetworkACL_OnlyIngressRules_basic === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic === RUN TestAccEC2NetworkACL_OnlyIngressRules_update === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update === RUN TestAccEC2NetworkACL_caseSensitivityNoChanges === PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges === RUN TestAccEC2NetworkACL_onlyEgressRules === PAUSE TestAccEC2NetworkACL_onlyEgressRules === RUN TestAccEC2NetworkACL_subnetChange === PAUSE TestAccEC2NetworkACL_subnetChange === RUN TestAccEC2NetworkACL_subnets === PAUSE TestAccEC2NetworkACL_subnets === RUN TestAccEC2NetworkACL_subnetsDelete === PAUSE TestAccEC2NetworkACL_subnetsDelete === RUN TestAccEC2NetworkACL_ipv6Rules === PAUSE TestAccEC2NetworkACL_ipv6Rules === RUN TestAccEC2NetworkACL_ipv6ICMPRules === PAUSE TestAccEC2NetworkACL_ipv6ICMPRules === RUN TestAccEC2NetworkACL_ipv6VPCRules === PAUSE TestAccEC2NetworkACL_ipv6VPCRules === RUN TestAccEC2NetworkACL_espProtocol === PAUSE TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_basic === CONT TestAccEC2NetworkACL_onlyEgressRules === CONT TestAccEC2NetworkACL_subnetsDelete === CONT TestAccEC2NetworkACL_subnets === CONT TestAccEC2NetworkACL_ipv6Rules --- PASS: TestAccEC2NetworkACL_basic (36.03s) === CONT TestAccEC2NetworkACL_espProtocol --- PASS: TestAccEC2NetworkACL_onlyEgressRules (47.80s) === CONT TestAccEC2NetworkACL_ipv6VPCRules --- PASS: TestAccEC2NetworkACL_ipv6Rules (54.02s) === CONT TestAccEC2NetworkACL_ipv6ICMPRules --- PASS: TestAccEC2NetworkACL_espProtocol (30.11s) === CONT TestAccEC2NetworkACL_egressAndIngressRules --- PASS: TestAccEC2NetworkACL_subnetsDelete (68.78s) === CONT TestAccEC2NetworkACL_caseSensitivityNoChanges --- PASS: TestAccEC2NetworkACL_subnets (75.17s) === CONT TestAccEC2NetworkACL_OnlyIngressRules_update --- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (26.74s) === CONT TestAccEC2NetworkACL_OnlyIngressRules_basic --- PASS: TestAccEC2NetworkACL_ipv6VPCRules (40.33s) === CONT TestAccEC2NetworkACL_subnetChange --- PASS: TestAccEC2NetworkACL_egressAndIngressRules (40.71s) === CONT TestAccEC2NetworkACL_Egress_mode --- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (47.23s) === CONT TestAccEC2NetworkACL_Ingress_mode --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (47.33s) === CONT TestAccEC2NetworkACL_tags --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (70.44s) === CONT TestAccEC2NetworkACL_disappears --- PASS: TestAccEC2NetworkACL_subnetChange (72.74s) --- PASS: TestAccEC2NetworkACL_disappears (28.05s) --- PASS: TestAccEC2NetworkACL_Egress_mode (80.63s) --- PASS: TestAccEC2NetworkACL_Ingress_mode (79.86s) --- PASS: TestAccEC2NetworkACL_tags (74.94s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 206.955s

…isappears_NACL' and 'TestAccEC2NetworkACLAssociation_disappears_Subnet'. Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACLAssociation_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACLAssociation_' -timeout 180m === RUN TestAccEC2NetworkACLAssociation_basic === PAUSE TestAccEC2NetworkACLAssociation_basic === RUN TestAccEC2NetworkACLAssociation_disappears === PAUSE TestAccEC2NetworkACLAssociation_disappears === RUN TestAccEC2NetworkACLAssociation_disappears_NACL === PAUSE TestAccEC2NetworkACLAssociation_disappears_NACL === RUN TestAccEC2NetworkACLAssociation_disappears_Subnet === PAUSE TestAccEC2NetworkACLAssociation_disappears_Subnet === RUN TestAccEC2NetworkACLAssociation_twoAssociations === PAUSE TestAccEC2NetworkACLAssociation_twoAssociations === CONT TestAccEC2NetworkACLAssociation_basic === CONT TestAccEC2NetworkACLAssociation_disappears_Subnet === CONT TestAccEC2NetworkACLAssociation_disappears === CONT TestAccEC2NetworkACLAssociation_disappears_NACL === CONT TestAccEC2NetworkACLAssociation_twoAssociations --- PASS: TestAccEC2NetworkACLAssociation_disappears_Subnet (38.06s) --- PASS: TestAccEC2NetworkACLAssociation_disappears (38.15s) --- PASS: TestAccEC2NetworkACLAssociation_disappears_NACL (38.68s) --- PASS: TestAccEC2NetworkACLAssociation_basic (42.49s) --- PASS: TestAccEC2NetworkACLAssociation_twoAssociations (46.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 53.854s

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACL_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACL_' -timeout 180m === RUN TestAccEC2NetworkACL_basic === PAUSE TestAccEC2NetworkACL_basic === RUN TestAccEC2NetworkACL_disappears === PAUSE TestAccEC2NetworkACL_disappears === RUN TestAccEC2NetworkACL_tags === PAUSE TestAccEC2NetworkACL_tags === RUN TestAccEC2NetworkACL_Egress_mode === PAUSE TestAccEC2NetworkACL_Egress_mode === RUN TestAccEC2NetworkACL_Ingress_mode === PAUSE TestAccEC2NetworkACL_Ingress_mode === RUN TestAccEC2NetworkACL_egressAndIngressRules === PAUSE TestAccEC2NetworkACL_egressAndIngressRules === RUN TestAccEC2NetworkACL_OnlyIngressRules_basic === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic === RUN TestAccEC2NetworkACL_OnlyIngressRules_update === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update === RUN TestAccEC2NetworkACL_caseSensitivityNoChanges === PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges === RUN TestAccEC2NetworkACL_onlyEgressRules === PAUSE TestAccEC2NetworkACL_onlyEgressRules === RUN TestAccEC2NetworkACL_subnetChange === PAUSE TestAccEC2NetworkACL_subnetChange === RUN TestAccEC2NetworkACL_subnets === PAUSE TestAccEC2NetworkACL_subnets === RUN TestAccEC2NetworkACL_subnetsDelete === PAUSE TestAccEC2NetworkACL_subnetsDelete === RUN TestAccEC2NetworkACL_ipv6Rules === PAUSE TestAccEC2NetworkACL_ipv6Rules === RUN TestAccEC2NetworkACL_ipv6ICMPRules === PAUSE TestAccEC2NetworkACL_ipv6ICMPRules === RUN TestAccEC2NetworkACL_ipv6VPCRules === PAUSE TestAccEC2NetworkACL_ipv6VPCRules === RUN TestAccEC2NetworkACL_espProtocol === PAUSE TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_basic === CONT TestAccEC2NetworkACL_onlyEgressRules === CONT TestAccEC2NetworkACL_ipv6Rules === CONT TestAccEC2NetworkACL_Ingress_mode === CONT TestAccEC2NetworkACL_egressAndIngressRules === CONT TestAccEC2NetworkACL_disappears === CONT TestAccEC2NetworkACL_OnlyIngressRules_basic === CONT TestAccEC2NetworkACL_subnetsDelete === CONT TestAccEC2NetworkACL_subnets === CONT TestAccEC2NetworkACL_subnetChange === CONT TestAccEC2NetworkACL_Egress_mode === CONT TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_ipv6VPCRules === CONT TestAccEC2NetworkACL_OnlyIngressRules_update === CONT TestAccEC2NetworkACL_ipv6ICMPRules === CONT TestAccEC2NetworkACL_tags === CONT TestAccEC2NetworkACL_caseSensitivityNoChanges --- PASS: TestAccEC2NetworkACL_disappears (42.27s) --- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (43.63s) --- PASS: TestAccEC2NetworkACL_basic (43.78s) --- PASS: TestAccEC2NetworkACL_espProtocol (46.83s) --- PASS: TestAccEC2NetworkACL_ipv6VPCRules (58.18s) --- PASS: TestAccEC2NetworkACL_onlyEgressRules (58.35s) --- PASS: TestAccEC2NetworkACL_egressAndIngressRules (58.35s) --- PASS: TestAccEC2NetworkACL_ipv6Rules (63.57s) --- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (64.22s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (64.36s) --- PASS: TestAccEC2NetworkACL_subnetsDelete (79.00s) --- PASS: TestAccEC2NetworkACL_subnets (85.99s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (86.18s) --- PASS: TestAccEC2NetworkACL_subnetChange (91.53s) --- PASS: TestAccEC2NetworkACL_tags (92.37s) --- PASS: TestAccEC2NetworkACL_Egress_mode (99.65s) --- PASS: TestAccEC2NetworkACL_Ingress_mode (99.96s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 104.400s

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACL_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACL_' -timeout 180m === RUN TestAccEC2NetworkACL_basic === PAUSE TestAccEC2NetworkACL_basic === RUN TestAccEC2NetworkACL_disappears === PAUSE TestAccEC2NetworkACL_disappears === RUN TestAccEC2NetworkACL_tags === PAUSE TestAccEC2NetworkACL_tags === RUN TestAccEC2NetworkACL_Egress_mode === PAUSE TestAccEC2NetworkACL_Egress_mode === RUN TestAccEC2NetworkACL_Ingress_mode === PAUSE TestAccEC2NetworkACL_Ingress_mode === RUN TestAccEC2NetworkACL_egressAndIngressRules === PAUSE TestAccEC2NetworkACL_egressAndIngressRules === RUN TestAccEC2NetworkACL_OnlyIngressRules_basic === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic === RUN TestAccEC2NetworkACL_OnlyIngressRules_update === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update === RUN TestAccEC2NetworkACL_caseSensitivityNoChanges === PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges === RUN TestAccEC2NetworkACL_onlyEgressRules === PAUSE TestAccEC2NetworkACL_onlyEgressRules === RUN TestAccEC2NetworkACL_subnetChange === PAUSE TestAccEC2NetworkACL_subnetChange === RUN TestAccEC2NetworkACL_subnets === PAUSE TestAccEC2NetworkACL_subnets === RUN TestAccEC2NetworkACL_subnetsDelete === PAUSE TestAccEC2NetworkACL_subnetsDelete === RUN TestAccEC2NetworkACL_ipv6Rules === PAUSE TestAccEC2NetworkACL_ipv6Rules === RUN TestAccEC2NetworkACL_ipv6ICMPRules === PAUSE TestAccEC2NetworkACL_ipv6ICMPRules === RUN TestAccEC2NetworkACL_ipv6VPCRules === PAUSE TestAccEC2NetworkACL_ipv6VPCRules === RUN TestAccEC2NetworkACL_espProtocol === PAUSE TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_basic === CONT TestAccEC2NetworkACL_onlyEgressRules === CONT TestAccEC2NetworkACL_ipv6Rules === CONT TestAccEC2NetworkACL_subnetsDelete === CONT TestAccEC2NetworkACL_Ingress_mode === CONT TestAccEC2NetworkACL_tags === CONT TestAccEC2NetworkACL_subnets === CONT TestAccEC2NetworkACL_subnetChange === CONT TestAccEC2NetworkACL_egressAndIngressRules === CONT TestAccEC2NetworkACL_caseSensitivityNoChanges === CONT TestAccEC2NetworkACL_OnlyIngressRules_update === CONT TestAccEC2NetworkACL_ipv6VPCRules === CONT TestAccEC2NetworkACL_OnlyIngressRules_basic === CONT TestAccEC2NetworkACL_Egress_mode === CONT TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_ipv6ICMPRules === CONT TestAccEC2NetworkACL_disappears --- PASS: TestAccEC2NetworkACL_disappears (37.88s) --- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (39.82s) --- PASS: TestAccEC2NetworkACL_basic (45.33s) --- PASS: TestAccEC2NetworkACL_espProtocol (45.79s) --- PASS: TestAccEC2NetworkACL_ipv6VPCRules (57.17s) --- PASS: TestAccEC2NetworkACL_onlyEgressRules (57.82s) --- PASS: TestAccEC2NetworkACL_egressAndIngressRules (58.57s) --- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (60.57s) --- PASS: TestAccEC2NetworkACL_ipv6Rules (62.72s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (62.83s) --- PASS: TestAccEC2NetworkACL_subnets (81.70s) --- PASS: TestAccEC2NetworkACL_subnetsDelete (84.22s) --- PASS: TestAccEC2NetworkACL_tags (90.29s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (91.21s) --- PASS: TestAccEC2NetworkACL_Ingress_mode (95.33s) --- PASS: TestAccEC2NetworkACL_Egress_mode (95.56s) === CONT TestAccEC2NetworkACL_subnetChange network_acl_test.go:409: Step 3/3 error: Error running apply: exit status 1 Error: error creating EC2 Network ACL (acl-0bd2b0339abb92b53) Association: InvalidAssociationID.NotFound: The association ID 'aclassoc-0e845a1f77a8f781e' does not exist status code: 400, request id: 69b4d9e6-0bcd-4ae6-8471-31164a1697b7 with aws_network_acl.test, on terraform_plugin_test.tf line 30, in resource "aws_network_acl" "test": 30: resource "aws_network_acl" "test" { --- FAIL: TestAccEC2NetworkACL_subnetChange (194.20s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 197.905s FAIL make: *** [testacc] Error 1

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACL_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACL_' -timeout 180m === RUN TestAccEC2NetworkACL_basic === PAUSE TestAccEC2NetworkACL_basic === RUN TestAccEC2NetworkACL_disappears === PAUSE TestAccEC2NetworkACL_disappears === RUN TestAccEC2NetworkACL_tags === PAUSE TestAccEC2NetworkACL_tags === RUN TestAccEC2NetworkACL_Egress_mode === PAUSE TestAccEC2NetworkACL_Egress_mode === RUN TestAccEC2NetworkACL_Ingress_mode === PAUSE TestAccEC2NetworkACL_Ingress_mode === RUN TestAccEC2NetworkACL_egressAndIngressRules === PAUSE TestAccEC2NetworkACL_egressAndIngressRules === RUN TestAccEC2NetworkACL_OnlyIngressRules_basic === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic === RUN TestAccEC2NetworkACL_OnlyIngressRules_update === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update === RUN TestAccEC2NetworkACL_caseSensitivityNoChanges === PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges === RUN TestAccEC2NetworkACL_onlyEgressRules === PAUSE TestAccEC2NetworkACL_onlyEgressRules === RUN TestAccEC2NetworkACL_subnetChange === PAUSE TestAccEC2NetworkACL_subnetChange === RUN TestAccEC2NetworkACL_subnets === PAUSE TestAccEC2NetworkACL_subnets === RUN TestAccEC2NetworkACL_subnetsDelete === PAUSE TestAccEC2NetworkACL_subnetsDelete === RUN TestAccEC2NetworkACL_ipv6Rules === PAUSE TestAccEC2NetworkACL_ipv6Rules === RUN TestAccEC2NetworkACL_ipv6ICMPRules === PAUSE TestAccEC2NetworkACL_ipv6ICMPRules === RUN TestAccEC2NetworkACL_ipv6VPCRules === PAUSE TestAccEC2NetworkACL_ipv6VPCRules === RUN TestAccEC2NetworkACL_espProtocol === PAUSE TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_basic === CONT TestAccEC2NetworkACL_onlyEgressRules === CONT TestAccEC2NetworkACL_ipv6Rules === CONT TestAccEC2NetworkACL_ipv6VPCRules === CONT TestAccEC2NetworkACL_disappears === CONT TestAccEC2NetworkACL_subnets === CONT TestAccEC2NetworkACL_subnetsDelete === CONT TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_ipv6ICMPRules === CONT TestAccEC2NetworkACL_egressAndIngressRules === CONT TestAccEC2NetworkACL_caseSensitivityNoChanges === CONT TestAccEC2NetworkACL_OnlyIngressRules_update === CONT TestAccEC2NetworkACL_subnetChange === CONT TestAccEC2NetworkACL_OnlyIngressRules_basic === CONT TestAccEC2NetworkACL_Egress_mode === CONT TestAccEC2NetworkACL_tags === CONT TestAccEC2NetworkACL_Ingress_mode --- PASS: TestAccEC2NetworkACL_disappears (41.13s) --- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (42.72s) --- PASS: TestAccEC2NetworkACL_basic (45.84s) --- PASS: TestAccEC2NetworkACL_espProtocol (46.82s) --- PASS: TestAccEC2NetworkACL_ipv6VPCRules (57.86s) --- PASS: TestAccEC2NetworkACL_onlyEgressRules (59.48s) --- PASS: TestAccEC2NetworkACL_egressAndIngressRules (59.51s) --- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (65.03s) --- PASS: TestAccEC2NetworkACL_ipv6Rules (65.04s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (65.33s) --- PASS: TestAccEC2NetworkACL_subnets (85.20s) --- PASS: TestAccEC2NetworkACL_subnetsDelete (85.79s) --- PASS: TestAccEC2NetworkACL_tags (91.47s) --- PASS: TestAccEC2NetworkACL_subnetChange (92.49s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (95.58s) --- PASS: TestAccEC2NetworkACL_Ingress_mode (97.62s) --- PASS: TestAccEC2NetworkACL_Egress_mode (98.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 102.739s

…teNetworkAclEntries'. Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACL_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACL_' -timeout 180m === RUN TestAccEC2NetworkACL_basic === PAUSE TestAccEC2NetworkACL_basic === RUN TestAccEC2NetworkACL_disappears === PAUSE TestAccEC2NetworkACL_disappears === RUN TestAccEC2NetworkACL_tags === PAUSE TestAccEC2NetworkACL_tags === RUN TestAccEC2NetworkACL_Egress_mode === PAUSE TestAccEC2NetworkACL_Egress_mode === RUN TestAccEC2NetworkACL_Ingress_mode === PAUSE TestAccEC2NetworkACL_Ingress_mode === RUN TestAccEC2NetworkACL_egressAndIngressRules === PAUSE TestAccEC2NetworkACL_egressAndIngressRules === RUN TestAccEC2NetworkACL_OnlyIngressRules_basic === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic === RUN TestAccEC2NetworkACL_OnlyIngressRules_update === PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update === RUN TestAccEC2NetworkACL_caseSensitivityNoChanges === PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges === RUN TestAccEC2NetworkACL_onlyEgressRules === PAUSE TestAccEC2NetworkACL_onlyEgressRules === RUN TestAccEC2NetworkACL_subnetChange === PAUSE TestAccEC2NetworkACL_subnetChange === RUN TestAccEC2NetworkACL_subnets === PAUSE TestAccEC2NetworkACL_subnets === RUN TestAccEC2NetworkACL_subnetsDelete === PAUSE TestAccEC2NetworkACL_subnetsDelete === RUN TestAccEC2NetworkACL_ipv6Rules === PAUSE TestAccEC2NetworkACL_ipv6Rules === RUN TestAccEC2NetworkACL_ipv6ICMPRules === PAUSE TestAccEC2NetworkACL_ipv6ICMPRules === RUN TestAccEC2NetworkACL_ipv6VPCRules === PAUSE TestAccEC2NetworkACL_ipv6VPCRules === RUN TestAccEC2NetworkACL_espProtocol === PAUSE TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_basic === CONT TestAccEC2NetworkACL_onlyEgressRules === CONT TestAccEC2NetworkACL_ipv6Rules === CONT TestAccEC2NetworkACL_Ingress_mode === CONT TestAccEC2NetworkACL_tags === CONT TestAccEC2NetworkACL_ipv6ICMPRules === CONT TestAccEC2NetworkACL_subnetsDelete === CONT TestAccEC2NetworkACL_subnets === CONT TestAccEC2NetworkACL_subnetChange === CONT TestAccEC2NetworkACL_egressAndIngressRules === CONT TestAccEC2NetworkACL_caseSensitivityNoChanges === CONT TestAccEC2NetworkACL_Egress_mode === CONT TestAccEC2NetworkACL_OnlyIngressRules_update === CONT TestAccEC2NetworkACL_OnlyIngressRules_basic === CONT TestAccEC2NetworkACL_ipv6VPCRules === CONT TestAccEC2NetworkACL_espProtocol === CONT TestAccEC2NetworkACL_disappears --- PASS: TestAccEC2NetworkACL_disappears (49.49s) --- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (50.88s) --- PASS: TestAccEC2NetworkACL_basic (52.00s) --- PASS: TestAccEC2NetworkACL_espProtocol (53.85s) --- PASS: TestAccEC2NetworkACL_ipv6VPCRules (67.59s) --- PASS: TestAccEC2NetworkACL_egressAndIngressRules (67.96s) --- PASS: TestAccEC2NetworkACL_onlyEgressRules (68.02s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (72.64s) --- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (74.42s) --- PASS: TestAccEC2NetworkACL_ipv6Rules (74.45s) --- PASS: TestAccEC2NetworkACL_subnetsDelete (97.17s) --- PASS: TestAccEC2NetworkACL_subnets (97.74s) --- PASS: TestAccEC2NetworkACL_tags (105.77s) --- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (106.86s) --- PASS: TestAccEC2NetworkACL_Ingress_mode (113.66s) --- PASS: TestAccEC2NetworkACL_Egress_mode (113.83s) === CONT TestAccEC2NetworkACL_subnetChange network_acl_test.go:409: Step 3/3 error: Error running apply: exit status 1 Error: error creating EC2 Network ACL (acl-08bb876eefe45f372) Association: InvalidAssociationID.NotFound: The association ID 'aclassoc-05d9ca41251fb599a' does not exist status code: 400, request id: c3f6459f-442e-442c-b3c5-5d72e249ea20 with aws_network_acl.test, on terraform_plugin_test.tf line 30, in resource "aws_network_acl" "test": 30: resource "aws_network_acl" "test" { --- FAIL: TestAccEC2NetworkACL_subnetChange (208.10s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 214.359s FAIL make: *** [testacc] Error 1

Acceptance test output: % make testacc TESTS=TestAccEC2DefaultNetworkACL_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultNetworkACL_' -timeout 180m === RUN TestAccEC2DefaultNetworkACL_basic === PAUSE TestAccEC2DefaultNetworkACL_basic === RUN TestAccEC2DefaultNetworkACL_basicIPv6VPC === PAUSE TestAccEC2DefaultNetworkACL_basicIPv6VPC === RUN TestAccEC2DefaultNetworkACL_Deny_ingress === PAUSE TestAccEC2DefaultNetworkACL_Deny_ingress === RUN TestAccEC2DefaultNetworkACL_withIPv6Ingress === PAUSE TestAccEC2DefaultNetworkACL_withIPv6Ingress === RUN TestAccEC2DefaultNetworkACL_subnetRemoval === PAUSE TestAccEC2DefaultNetworkACL_subnetRemoval === RUN TestAccEC2DefaultNetworkACL_subnetReassign === PAUSE TestAccEC2DefaultNetworkACL_subnetReassign === CONT TestAccEC2DefaultNetworkACL_basic === CONT TestAccEC2DefaultNetworkACL_withIPv6Ingress === CONT TestAccEC2DefaultNetworkACL_subnetRemoval === CONT TestAccEC2DefaultNetworkACL_Deny_ingress === CONT TestAccEC2DefaultNetworkACL_subnetReassign === CONT TestAccEC2DefaultNetworkACL_basicIPv6VPC --- PASS: TestAccEC2DefaultNetworkACL_basic (32.42s) --- PASS: TestAccEC2DefaultNetworkACL_Deny_ingress (33.61s) --- PASS: TestAccEC2DefaultNetworkACL_withIPv6Ingress (33.67s) --- PASS: TestAccEC2DefaultNetworkACL_basicIPv6VPC (45.46s) --- PASS: TestAccEC2DefaultNetworkACL_subnetRemoval (68.42s) --- PASS: TestAccEC2DefaultNetworkACL_subnetReassign (76.87s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 80.645s

Acceptance test output: % make testacc TESTS=TestAccEC2DefaultNetworkACL_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultNetworkACL_' -timeout 180m === RUN TestAccEC2DefaultNetworkACL_basic === PAUSE TestAccEC2DefaultNetworkACL_basic === RUN TestAccEC2DefaultNetworkACL_basicIPv6VPC === PAUSE TestAccEC2DefaultNetworkACL_basicIPv6VPC === RUN TestAccEC2DefaultNetworkACL_tags === PAUSE TestAccEC2DefaultNetworkACL_tags === RUN TestAccEC2DefaultNetworkACL_Deny_ingress === PAUSE TestAccEC2DefaultNetworkACL_Deny_ingress === RUN TestAccEC2DefaultNetworkACL_withIPv6Ingress === PAUSE TestAccEC2DefaultNetworkACL_withIPv6Ingress === RUN TestAccEC2DefaultNetworkACL_subnetRemoval === PAUSE TestAccEC2DefaultNetworkACL_subnetRemoval === RUN TestAccEC2DefaultNetworkACL_subnetReassign === PAUSE TestAccEC2DefaultNetworkACL_subnetReassign === CONT TestAccEC2DefaultNetworkACL_basic === CONT TestAccEC2DefaultNetworkACL_withIPv6Ingress === CONT TestAccEC2DefaultNetworkACL_Deny_ingress === CONT TestAccEC2DefaultNetworkACL_tags === CONT TestAccEC2DefaultNetworkACL_basicIPv6VPC === CONT TestAccEC2DefaultNetworkACL_subnetRemoval === CONT TestAccEC2DefaultNetworkACL_subnetReassign --- PASS: TestAccEC2DefaultNetworkACL_basic (36.95s) --- PASS: TestAccEC2DefaultNetworkACL_Deny_ingress (37.92s) --- PASS: TestAccEC2DefaultNetworkACL_withIPv6Ingress (37.99s) --- PASS: TestAccEC2DefaultNetworkACL_basicIPv6VPC (46.17s) --- PASS: TestAccEC2DefaultNetworkACL_subnetRemoval (66.14s) --- PASS: TestAccEC2DefaultNetworkACL_subnetReassign (72.55s) --- PASS: TestAccEC2DefaultNetworkACL_tags (78.94s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 82.958s

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACLRule_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACLRule_' -timeout 180m === RUN TestAccEC2NetworkACLRule_basic === PAUSE TestAccEC2NetworkACLRule_basic === RUN TestAccEC2NetworkACLRule_disappears === PAUSE TestAccEC2NetworkACLRule_disappears === RUN TestAccEC2NetworkACLRule_Disappears_networkACL === PAUSE TestAccEC2NetworkACLRule_Disappears_networkACL === RUN TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === PAUSE TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === RUN TestAccEC2NetworkACLRule_ipv6 === PAUSE TestAccEC2NetworkACLRule_ipv6 === RUN TestAccEC2NetworkACLRule_ipv6ICMP === PAUSE TestAccEC2NetworkACLRule_ipv6ICMP === RUN TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === PAUSE TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === RUN TestAccEC2NetworkACLRule_allProtocol === PAUSE TestAccEC2NetworkACLRule_allProtocol === RUN TestAccEC2NetworkACLRule_tcpProtocol === PAUSE TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_basic === CONT TestAccEC2NetworkACLRule_ipv6ICMP === CONT TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_allProtocol === CONT TestAccEC2NetworkACLRule_ipv6 === CONT TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === CONT TestAccEC2NetworkACLRule_Disappears_networkACL === CONT TestAccEC2NetworkACLRule_disappears === CONT TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === CONT TestAccEC2NetworkACLRule_allProtocol network_acl_rule_test.go:213: Step 1/2 error: After applying this test step, the plan was not empty. stdout: Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: -/+ destroy and then create replacement Terraform will perform the following actions: # aws_network_acl_rule.baz must be replaced -/+ resource "aws_network_acl_rule" "baz" { ~ from_port = 0 -> 22 # forces replacement - icmp_code = 0 -> null - icmp_type = 0 -> null ~ id = "nacl-2142537903" -> (known after apply) ~ to_port = 0 -> 22 # forces replacement # (6 unchanged attributes hidden) } Plan: 1 to add, 0 to change, 1 to destroy. --- FAIL: TestAccEC2NetworkACLRule_allProtocol (30.33s) === CONT TestAccEC2NetworkACLRule_ipv6 network_acl_rule_test.go:125: Failed state verification, resource with ID nacl-1741481141 not found === CONT TestAccEC2NetworkACLRule_basic network_acl_rule_test.go:22: Failed state verification, resource with ID nacl-2880102436 not found --- PASS: TestAccEC2NetworkACLRule_Disappears_networkACL (38.29s) --- PASS: TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber (40.48s) --- PASS: TestAccEC2NetworkACLRule_disappears (40.87s) --- PASS: TestAccEC2NetworkACLRule_ipv6ICMP (41.53s) --- FAIL: TestAccEC2NetworkACLRule_ipv6 (41.70s) --- FAIL: TestAccEC2NetworkACLRule_basic (43.98s) === CONT TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate network_acl_rule_test.go:179: Step 2/3 error: Error running apply: exit status 1 Error: Provider produced inconsistent final plan When expanding the plan for aws_network_acl_rule.test to include new values learned so far during apply, provider "registry.terraform.io/hashicorp/aws" produced an invalid new value for .ipv6_cidr_block: was cty.StringVal(""), but now cty.StringVal("2600:1f14:35a:af00::/56"). This is a bug in the provider, which should be reported in the provider's own issue tracker. --- PASS: TestAccEC2NetworkACLRule_tcpProtocol (61.55s) --- FAIL: TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (62.64s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 66.490s FAIL make: *** [testacc] Error 1

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACLRule_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACLRule_' -timeout 180m === RUN TestAccEC2NetworkACLRule_basic === PAUSE TestAccEC2NetworkACLRule_basic === RUN TestAccEC2NetworkACLRule_disappears === PAUSE TestAccEC2NetworkACLRule_disappears === RUN TestAccEC2NetworkACLRule_Disappears_networkACL === PAUSE TestAccEC2NetworkACLRule_Disappears_networkACL === RUN TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === PAUSE TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === RUN TestAccEC2NetworkACLRule_ipv6 === PAUSE TestAccEC2NetworkACLRule_ipv6 === RUN TestAccEC2NetworkACLRule_ipv6ICMP === PAUSE TestAccEC2NetworkACLRule_ipv6ICMP === RUN TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === PAUSE TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === RUN TestAccEC2NetworkACLRule_allProtocol === PAUSE TestAccEC2NetworkACLRule_allProtocol === RUN TestAccEC2NetworkACLRule_tcpProtocol === PAUSE TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_basic === CONT TestAccEC2NetworkACLRule_ipv6ICMP === CONT TestAccEC2NetworkACLRule_ipv6 === CONT TestAccEC2NetworkACLRule_Disappears_networkACL === CONT TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === CONT TestAccEC2NetworkACLRule_disappears === CONT TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === CONT TestAccEC2NetworkACLRule_allProtocol === CONT TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate network_acl_rule_test.go:239: Step 1/3 error: Check failed: Check 2/4 error: Not found: aws_network_acl_rule.test === CONT TestAccEC2NetworkACLRule_allProtocol network_acl_rule_test.go:277: Step 1/2 error: Check failed: 2 errors occurred: * Check 4/11 error: aws_network_acl_rule.test: Attribute 'from_port' expected "22", got "0" * Check 11/11 error: aws_network_acl_rule.test: Attribute 'to_port' expected "22", got "0" --- FAIL: TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (24.54s) --- FAIL: TestAccEC2NetworkACLRule_allProtocol (26.51s) === CONT TestAccEC2NetworkACLRule_ipv6 network_acl_rule_test.go:164: Failed state verification, resource with ID nacl-4107606206 not found === CONT TestAccEC2NetworkACLRule_basic network_acl_rule_test.go:25: Failed state verification, resource with ID nacl-996638004 not found --- PASS: TestAccEC2NetworkACLRule_Disappears_networkACL (37.50s) --- PASS: TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber (39.23s) --- PASS: TestAccEC2NetworkACLRule_disappears (39.81s) --- PASS: TestAccEC2NetworkACLRule_ipv6ICMP (42.25s) --- FAIL: TestAccEC2NetworkACLRule_ipv6 (42.27s) --- FAIL: TestAccEC2NetworkACLRule_basic (43.06s) --- PASS: TestAccEC2NetworkACLRule_tcpProtocol (55.81s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 59.862s FAIL make: *** [testacc] Error 1

…orp#6721 mistakenly removed in hashicorp#22420.

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACLRule_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACLRule_' -timeout 180m === RUN TestAccEC2NetworkACLRule_basic === PAUSE TestAccEC2NetworkACLRule_basic === RUN TestAccEC2NetworkACLRule_disappears === PAUSE TestAccEC2NetworkACLRule_disappears === RUN TestAccEC2NetworkACLRule_Disappears_networkACL === PAUSE TestAccEC2NetworkACLRule_Disappears_networkACL === RUN TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === PAUSE TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === RUN TestAccEC2NetworkACLRule_ipv6 === PAUSE TestAccEC2NetworkACLRule_ipv6 === RUN TestAccEC2NetworkACLRule_ipv6ICMP === PAUSE TestAccEC2NetworkACLRule_ipv6ICMP === RUN TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === PAUSE TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === RUN TestAccEC2NetworkACLRule_allProtocol === PAUSE TestAccEC2NetworkACLRule_allProtocol === RUN TestAccEC2NetworkACLRule_tcpProtocol === PAUSE TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_basic === CONT TestAccEC2NetworkACLRule_ipv6ICMP === CONT TestAccEC2NetworkACLRule_disappears === CONT TestAccEC2NetworkACLRule_allProtocol === CONT TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === CONT TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === CONT TestAccEC2NetworkACLRule_ipv6 === CONT TestAccEC2NetworkACLRule_Disappears_networkACL --- PASS: TestAccEC2NetworkACLRule_Disappears_networkACL (35.83s) --- PASS: TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber (37.73s) --- PASS: TestAccEC2NetworkACLRule_disappears (38.16s) --- PASS: TestAccEC2NetworkACLRule_ipv6 (38.73s) --- PASS: TestAccEC2NetworkACLRule_ipv6ICMP (40.09s) --- PASS: TestAccEC2NetworkACLRule_basic (46.70s) --- PASS: TestAccEC2NetworkACLRule_tcpProtocol (55.74s) --- PASS: TestAccEC2NetworkACLRule_allProtocol (56.43s) --- PASS: TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (75.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 80.354s

Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACLRule_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACLRule_' -timeout 180m === RUN TestAccEC2NetworkACLRule_basic === PAUSE TestAccEC2NetworkACLRule_basic === RUN TestAccEC2NetworkACLRule_disappears === PAUSE TestAccEC2NetworkACLRule_disappears === RUN TestAccEC2NetworkACLRule_Disappears_networkACL === PAUSE TestAccEC2NetworkACLRule_Disappears_networkACL === RUN TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === PAUSE TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === RUN TestAccEC2NetworkACLRule_ipv6 === PAUSE TestAccEC2NetworkACLRule_ipv6 === RUN TestAccEC2NetworkACLRule_ipv6ICMP === PAUSE TestAccEC2NetworkACLRule_ipv6ICMP === RUN TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === PAUSE TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate === RUN TestAccEC2NetworkACLRule_allProtocol === PAUSE TestAccEC2NetworkACLRule_allProtocol === RUN TestAccEC2NetworkACLRule_tcpProtocol === PAUSE TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_basic === CONT TestAccEC2NetworkACLRule_ipv6ICMP === CONT TestAccEC2NetworkACLRule_allProtocol === CONT TestAccEC2NetworkACLRule_tcpProtocol === CONT TestAccEC2NetworkACLRule_ipv6 === CONT TestAccEC2NetworkACLRule_disappears === CONT TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber === CONT TestAccEC2NetworkACLRule_Disappears_networkACL === CONT TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate --- PASS: TestAccEC2NetworkACLRule_Disappears_networkACL (59.76s) --- PASS: TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber (61.75s) --- PASS: TestAccEC2NetworkACLRule_disappears (62.08s) --- PASS: TestAccEC2NetworkACLRule_ipv6 (66.11s) --- PASS: TestAccEC2NetworkACLRule_ipv6ICMP (66.55s) --- PASS: TestAccEC2NetworkACLRule_basic (76.44s) --- PASS: TestAccEC2NetworkACLRule_allProtocol (81.80s) --- PASS: TestAccEC2NetworkACLRule_tcpProtocol (83.37s) --- PASS: TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (102.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 113.589s

…ssociateWithDefaultNACL'. Acceptance test output: % make testacc TESTS=TestAccEC2NetworkACLAssociation_associateWithDefaultNACL PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2NetworkACLAssociation_associateWithDefaultNACL' -timeout 180m === RUN TestAccEC2NetworkACLAssociation_associateWithDefaultNACL === PAUSE TestAccEC2NetworkACLAssociation_associateWithDefaultNACL === CONT TestAccEC2NetworkACLAssociation_associateWithDefaultNACL --- PASS: TestAccEC2NetworkACLAssociation_associateWithDefaultNACL (38.09s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 42.008s

ewbankkit

LGTM 🚀.

Commercial

 % make testacc TESTARGS='-run=TestAccEC2NetworkACLAssociation_\|TestAccEC2NetworkACLRule_\|TestAccEC2DefaultNetworkACL_\|TestAccEC2NetworkACL_\|TestAccEC2NetworkACLsDataSource_\|TestAccVPC_' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2NetworkACLAssociation_\|TestAccEC2NetworkACLRule_\|TestAccEC2DefaultNetworkACL_\|TestAccEC2NetworkACL_\|TestAccEC2NetworkACLsDataSource_\|TestAccVPC_ -timeout 180m
=== RUN   TestAccEC2DefaultNetworkACL_basic
=== PAUSE TestAccEC2DefaultNetworkACL_basic
=== RUN   TestAccEC2DefaultNetworkACL_basicIPv6VPC
=== PAUSE TestAccEC2DefaultNetworkACL_basicIPv6VPC
=== RUN   TestAccEC2DefaultNetworkACL_tags
=== PAUSE TestAccEC2DefaultNetworkACL_tags
=== RUN   TestAccEC2DefaultNetworkACL_Deny_ingress
=== PAUSE TestAccEC2DefaultNetworkACL_Deny_ingress
=== RUN   TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== PAUSE TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== RUN   TestAccEC2DefaultNetworkACL_subnetRemoval
=== PAUSE TestAccEC2DefaultNetworkACL_subnetRemoval
=== RUN   TestAccEC2DefaultNetworkACL_subnetReassign
=== PAUSE TestAccEC2DefaultNetworkACL_subnetReassign
=== RUN   TestAccEC2NetworkACLAssociation_basic
=== PAUSE TestAccEC2NetworkACLAssociation_basic
=== RUN   TestAccEC2NetworkACLAssociation_disappears
=== PAUSE TestAccEC2NetworkACLAssociation_disappears
=== RUN   TestAccEC2NetworkACLAssociation_disappears_NACL
=== PAUSE TestAccEC2NetworkACLAssociation_disappears_NACL
=== RUN   TestAccEC2NetworkACLAssociation_disappears_Subnet
=== PAUSE TestAccEC2NetworkACLAssociation_disappears_Subnet
=== RUN   TestAccEC2NetworkACLAssociation_twoAssociations
=== PAUSE TestAccEC2NetworkACLAssociation_twoAssociations
=== RUN   TestAccEC2NetworkACLAssociation_associateWithDefaultNACL
=== PAUSE TestAccEC2NetworkACLAssociation_associateWithDefaultNACL
=== RUN   TestAccEC2NetworkACLRule_basic
=== PAUSE TestAccEC2NetworkACLRule_basic
=== RUN   TestAccEC2NetworkACLRule_disappears
=== PAUSE TestAccEC2NetworkACLRule_disappears
=== RUN   TestAccEC2NetworkACLRule_Disappears_networkACL
=== PAUSE TestAccEC2NetworkACLRule_Disappears_networkACL
=== RUN   TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber
=== PAUSE TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber
=== RUN   TestAccEC2NetworkACLRule_ipv6
=== PAUSE TestAccEC2NetworkACLRule_ipv6
=== RUN   TestAccEC2NetworkACLRule_ipv6ICMP
=== PAUSE TestAccEC2NetworkACLRule_ipv6ICMP
=== RUN   TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== PAUSE TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== RUN   TestAccEC2NetworkACLRule_allProtocol
=== PAUSE TestAccEC2NetworkACLRule_allProtocol
=== RUN   TestAccEC2NetworkACLRule_tcpProtocol
=== PAUSE TestAccEC2NetworkACLRule_tcpProtocol
=== RUN   TestAccEC2NetworkACL_basic
=== PAUSE TestAccEC2NetworkACL_basic
=== RUN   TestAccEC2NetworkACL_disappears
=== PAUSE TestAccEC2NetworkACL_disappears
=== RUN   TestAccEC2NetworkACL_tags
=== PAUSE TestAccEC2NetworkACL_tags
=== RUN   TestAccEC2NetworkACL_Egress_mode
=== PAUSE TestAccEC2NetworkACL_Egress_mode
=== RUN   TestAccEC2NetworkACL_Ingress_mode
=== PAUSE TestAccEC2NetworkACL_Ingress_mode
=== RUN   TestAccEC2NetworkACL_egressAndIngressRules
=== PAUSE TestAccEC2NetworkACL_egressAndIngressRules
=== RUN   TestAccEC2NetworkACL_OnlyIngressRules_basic
=== PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic
=== RUN   TestAccEC2NetworkACL_OnlyIngressRules_update
=== PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update
=== RUN   TestAccEC2NetworkACL_caseSensitivityNoChanges
=== PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges
=== RUN   TestAccEC2NetworkACL_onlyEgressRules
=== PAUSE TestAccEC2NetworkACL_onlyEgressRules
=== RUN   TestAccEC2NetworkACL_subnetChange
=== PAUSE TestAccEC2NetworkACL_subnetChange
=== RUN   TestAccEC2NetworkACL_subnets
=== PAUSE TestAccEC2NetworkACL_subnets
=== RUN   TestAccEC2NetworkACL_subnetsDelete
=== PAUSE TestAccEC2NetworkACL_subnetsDelete
=== RUN   TestAccEC2NetworkACL_ipv6Rules
=== PAUSE TestAccEC2NetworkACL_ipv6Rules
=== RUN   TestAccEC2NetworkACL_ipv6ICMPRules
=== PAUSE TestAccEC2NetworkACL_ipv6ICMPRules
=== RUN   TestAccEC2NetworkACL_ipv6VPCRules
=== PAUSE TestAccEC2NetworkACL_ipv6VPCRules
=== RUN   TestAccEC2NetworkACL_espProtocol
=== PAUSE TestAccEC2NetworkACL_espProtocol
=== RUN   TestAccEC2NetworkACLsDataSource_basic
=== PAUSE TestAccEC2NetworkACLsDataSource_basic
=== RUN   TestAccEC2NetworkACLsDataSource_filter
=== PAUSE TestAccEC2NetworkACLsDataSource_filter
=== RUN   TestAccEC2NetworkACLsDataSource_tags
=== PAUSE TestAccEC2NetworkACLsDataSource_tags
=== RUN   TestAccEC2NetworkACLsDataSource_vpcID
=== PAUSE TestAccEC2NetworkACLsDataSource_vpcID
=== RUN   TestAccEC2NetworkACLsDataSource_empty
=== PAUSE TestAccEC2NetworkACLsDataSource_empty
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
=== PAUSE TestAccVPC_IpamIpv4BasicNetmask
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
=== PAUSE TestAccVPC_IpamIpv4BasicExplicitCidr
=== CONT  TestAccEC2DefaultNetworkACL_basic
=== CONT  TestAccEC2NetworkACL_subnetsDelete
=== CONT  TestAccEC2NetworkACLRule_ipv6
=== CONT  TestAccEC2NetworkACL_subnets
--- PASS: TestAccEC2DefaultNetworkACL_basic (34.23s)
=== CONT  TestAccEC2NetworkACL_subnetChange
--- PASS: TestAccEC2NetworkACLRule_ipv6 (36.62s)
=== CONT  TestAccEC2NetworkACL_onlyEgressRules
--- PASS: TestAccEC2NetworkACL_subnets (73.63s)
=== CONT  TestAccEC2NetworkACL_caseSensitivityNoChanges
--- PASS: TestAccEC2NetworkACL_subnetsDelete (75.30s)
=== CONT  TestAccEC2NetworkACL_OnlyIngressRules_update
--- PASS: TestAccEC2NetworkACL_onlyEgressRules (45.02s)
=== CONT  TestAccEC2NetworkACL_OnlyIngressRules_basic
--- PASS: TestAccEC2NetworkACL_subnetChange (77.64s)
=== CONT  TestAccEC2NetworkACL_egressAndIngressRules
--- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (49.72s)
=== CONT  TestAccEC2NetworkACL_Ingress_mode
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (54.22s)
=== CONT  TestAccEC2NetworkACL_Egress_mode
--- PASS: TestAccEC2NetworkACL_egressAndIngressRules (42.65s)
=== CONT  TestAccEC2NetworkACL_tags
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (81.69s)
=== CONT  TestAccEC2NetworkACL_disappears
--- PASS: TestAccEC2NetworkACL_disappears (27.23s)
=== CONT  TestAccEC2NetworkACL_basic
--- PASS: TestAccEC2NetworkACL_Ingress_mode (85.08s)
=== CONT  TestAccEC2NetworkACLRule_tcpProtocol
--- PASS: TestAccEC2NetworkACL_basic (32.58s)
=== CONT  TestAccEC2NetworkACLRule_allProtocol
--- PASS: TestAccEC2NetworkACL_Egress_mode (85.19s)
=== CONT  TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
--- PASS: TestAccEC2NetworkACL_tags (77.06s)
=== CONT  TestAccEC2NetworkACLRule_ipv6ICMP
--- PASS: TestAccEC2NetworkACLRule_tcpProtocol (50.85s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccEC2NetworkACLRule_ipv6ICMP (34.03s)
=== CONT  TestAccVPC_IpamIpv4BasicExplicitCidr
--- PASS: TestAccEC2NetworkACLRule_allProtocol (50.26s)
=== CONT  TestAccVPC_IpamIpv4BasicNetmask
--- PASS: TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (69.92s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (54.19s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (99.16s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
--- PASS: TestAccVPC_classicLinkDNSSupportOptionSet (31.46s)
=== CONT  TestAccVPC_classicLinkOptionSet
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (111.63s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccVPC_classicLinkOptionSet (32.70s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_disabledDNSSupport (42.19s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_bothDNSOptionsSet (41.78s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_updateDNSHostnames (60.54s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_tenancy (83.42s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccVPC_ignoreTags (60.36s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (49.06s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_defaultAndIgnoreTags (59.78s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (0.99s)
=== CONT  TestAccEC2NetworkACLsDataSource_empty
--- PASS: TestAccEC2NetworkACLsDataSource_empty (13.60s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (50.73s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (56.30s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (41.03s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (40.84s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_DefaultTags_providerOnly (54.47s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_disappears (20.01s)
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_tags (80.53s)
=== CONT  TestAccEC2DefaultNetworkACL_subnetRemoval
--- PASS: TestAccVPC_basic (30.11s)
=== CONT  TestAccEC2NetworkACLAssociation_disappears
--- PASS: TestAccEC2NetworkACLAssociation_disappears (32.96s)
=== CONT  TestAccEC2NetworkACLAssociation_basic
--- PASS: TestAccEC2DefaultNetworkACL_subnetRemoval (65.50s)
=== CONT  TestAccEC2DefaultNetworkACL_subnetReassign
--- PASS: TestAccEC2NetworkACLAssociation_basic (38.20s)
=== CONT  TestAccEC2NetworkACLRule_basic
--- PASS: TestAccEC2NetworkACLRule_basic (44.04s)
=== CONT  TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber
--- PASS: TestAccEC2DefaultNetworkACL_subnetReassign (74.01s)
=== CONT  TestAccEC2NetworkACLRule_Disappears_networkACL
--- PASS: TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber (31.19s)
=== CONT  TestAccEC2NetworkACLRule_disappears
--- PASS: TestAccEC2NetworkACLRule_Disappears_networkACL (31.17s)
=== CONT  TestAccEC2NetworkACLsDataSource_basic
--- PASS: TestAccEC2NetworkACLRule_disappears (31.13s)
=== CONT  TestAccEC2NetworkACLsDataSource_vpcID
--- PASS: TestAccEC2NetworkACLsDataSource_basic (28.45s)
=== CONT  TestAccEC2NetworkACLsDataSource_tags
--- PASS: TestAccEC2NetworkACLsDataSource_vpcID (29.54s)
=== CONT  TestAccEC2NetworkACLsDataSource_filter
--- PASS: TestAccEC2NetworkACLsDataSource_tags (30.65s)
=== CONT  TestAccEC2NetworkACLAssociation_twoAssociations
--- PASS: TestAccEC2NetworkACLsDataSource_filter (30.54s)
=== CONT  TestAccEC2NetworkACLAssociation_associateWithDefaultNACL
--- PASS: TestAccEC2NetworkACLAssociation_twoAssociations (40.81s)
=== CONT  TestAccEC2NetworkACL_ipv6VPCRules
--- PASS: TestAccEC2NetworkACLAssociation_associateWithDefaultNACL (35.46s)
=== CONT  TestAccEC2NetworkACL_espProtocol
--- PASS: TestAccEC2NetworkACL_espProtocol (31.23s)
=== CONT  TestAccEC2NetworkACLAssociation_disappears_NACL
--- PASS: TestAccEC2NetworkACL_ipv6VPCRules (42.00s)
=== CONT  TestAccEC2NetworkACLAssociation_disappears_Subnet
--- PASS: TestAccEC2NetworkACLAssociation_disappears_NACL (33.49s)
=== CONT  TestAccEC2NetworkACL_ipv6ICMPRules
--- PASS: TestAccEC2NetworkACLAssociation_disappears_Subnet (32.71s)
=== CONT  TestAccEC2DefaultNetworkACL_tags
--- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (27.55s)
=== CONT  TestAccEC2DefaultNetworkACL_withIPv6Ingress
--- PASS: TestAccEC2DefaultNetworkACL_withIPv6Ingress (31.31s)
=== CONT  TestAccEC2DefaultNetworkACL_Deny_ingress
--- PASS: TestAccEC2DefaultNetworkACL_tags (75.27s)
=== CONT  TestAccEC2DefaultNetworkACL_basicIPv6VPC
--- PASS: TestAccEC2DefaultNetworkACL_Deny_ingress (29.72s)
=== CONT  TestAccEC2NetworkACL_ipv6Rules
--- PASS: TestAccEC2DefaultNetworkACL_basicIPv6VPC (44.00s)
--- PASS: TestAccEC2NetworkACL_ipv6Rules (50.82s)
--- PASS: TestAccVPC_IpamIpv4BasicNetmask (1724.04s)
--- PASS: TestAccVPC_IpamIpv4BasicExplicitCidr (1725.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1995.562s

GovCloud

% make testacc TESTARGS='-run=TestAccEC2NetworkACLAssociation_\|TestAccEC2NetworkACLRule_\|TestAccEC2DefaultNetworkACL_\|TestAccEC2NetworkACL_\|TestAccEC2NetworkACLsDataSource_\|TestAccVPC_' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2NetworkACLAssociation_\|TestAccEC2NetworkACLRule_\|TestAccEC2DefaultNetworkACL_\|TestAccEC2NetworkACL_\|TestAccEC2NetworkACLsDataSource_\|TestAccVPC_ -timeout 180m
=== RUN   TestAccEC2DefaultNetworkACL_basic
=== PAUSE TestAccEC2DefaultNetworkACL_basic
=== RUN   TestAccEC2DefaultNetworkACL_basicIPv6VPC
=== PAUSE TestAccEC2DefaultNetworkACL_basicIPv6VPC
=== RUN   TestAccEC2DefaultNetworkACL_tags
=== PAUSE TestAccEC2DefaultNetworkACL_tags
=== RUN   TestAccEC2DefaultNetworkACL_Deny_ingress
=== PAUSE TestAccEC2DefaultNetworkACL_Deny_ingress
=== RUN   TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== PAUSE TestAccEC2DefaultNetworkACL_withIPv6Ingress
=== RUN   TestAccEC2DefaultNetworkACL_subnetRemoval
=== PAUSE TestAccEC2DefaultNetworkACL_subnetRemoval
=== RUN   TestAccEC2DefaultNetworkACL_subnetReassign
=== PAUSE TestAccEC2DefaultNetworkACL_subnetReassign
=== RUN   TestAccEC2NetworkACLAssociation_basic
=== PAUSE TestAccEC2NetworkACLAssociation_basic
=== RUN   TestAccEC2NetworkACLAssociation_disappears
=== PAUSE TestAccEC2NetworkACLAssociation_disappears
=== RUN   TestAccEC2NetworkACLAssociation_disappears_NACL
=== PAUSE TestAccEC2NetworkACLAssociation_disappears_NACL
=== RUN   TestAccEC2NetworkACLAssociation_disappears_Subnet
=== PAUSE TestAccEC2NetworkACLAssociation_disappears_Subnet
=== RUN   TestAccEC2NetworkACLAssociation_twoAssociations
=== PAUSE TestAccEC2NetworkACLAssociation_twoAssociations
=== RUN   TestAccEC2NetworkACLAssociation_associateWithDefaultNACL
=== PAUSE TestAccEC2NetworkACLAssociation_associateWithDefaultNACL
=== RUN   TestAccEC2NetworkACLRule_basic
=== PAUSE TestAccEC2NetworkACLRule_basic
=== RUN   TestAccEC2NetworkACLRule_disappears
=== PAUSE TestAccEC2NetworkACLRule_disappears
=== RUN   TestAccEC2NetworkACLRule_Disappears_networkACL
=== PAUSE TestAccEC2NetworkACLRule_Disappears_networkACL
=== RUN   TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber
=== PAUSE TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber
=== RUN   TestAccEC2NetworkACLRule_ipv6
=== PAUSE TestAccEC2NetworkACLRule_ipv6
=== RUN   TestAccEC2NetworkACLRule_ipv6ICMP
=== PAUSE TestAccEC2NetworkACLRule_ipv6ICMP
=== RUN   TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== PAUSE TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
=== RUN   TestAccEC2NetworkACLRule_allProtocol
=== PAUSE TestAccEC2NetworkACLRule_allProtocol
=== RUN   TestAccEC2NetworkACLRule_tcpProtocol
=== PAUSE TestAccEC2NetworkACLRule_tcpProtocol
=== RUN   TestAccEC2NetworkACL_basic
=== PAUSE TestAccEC2NetworkACL_basic
=== RUN   TestAccEC2NetworkACL_disappears
=== PAUSE TestAccEC2NetworkACL_disappears
=== RUN   TestAccEC2NetworkACL_tags
=== PAUSE TestAccEC2NetworkACL_tags
=== RUN   TestAccEC2NetworkACL_Egress_mode
=== PAUSE TestAccEC2NetworkACL_Egress_mode
=== RUN   TestAccEC2NetworkACL_Ingress_mode
=== PAUSE TestAccEC2NetworkACL_Ingress_mode
=== RUN   TestAccEC2NetworkACL_egressAndIngressRules
=== PAUSE TestAccEC2NetworkACL_egressAndIngressRules
=== RUN   TestAccEC2NetworkACL_OnlyIngressRules_basic
=== PAUSE TestAccEC2NetworkACL_OnlyIngressRules_basic
=== RUN   TestAccEC2NetworkACL_OnlyIngressRules_update
=== PAUSE TestAccEC2NetworkACL_OnlyIngressRules_update
=== RUN   TestAccEC2NetworkACL_caseSensitivityNoChanges
=== PAUSE TestAccEC2NetworkACL_caseSensitivityNoChanges
=== RUN   TestAccEC2NetworkACL_onlyEgressRules
=== PAUSE TestAccEC2NetworkACL_onlyEgressRules
=== RUN   TestAccEC2NetworkACL_subnetChange
=== PAUSE TestAccEC2NetworkACL_subnetChange
=== RUN   TestAccEC2NetworkACL_subnets
=== PAUSE TestAccEC2NetworkACL_subnets
=== RUN   TestAccEC2NetworkACL_subnetsDelete
=== PAUSE TestAccEC2NetworkACL_subnetsDelete
=== RUN   TestAccEC2NetworkACL_ipv6Rules
=== PAUSE TestAccEC2NetworkACL_ipv6Rules
=== RUN   TestAccEC2NetworkACL_ipv6ICMPRules
=== PAUSE TestAccEC2NetworkACL_ipv6ICMPRules
=== RUN   TestAccEC2NetworkACL_ipv6VPCRules
=== PAUSE TestAccEC2NetworkACL_ipv6VPCRules
=== RUN   TestAccEC2NetworkACL_espProtocol
=== PAUSE TestAccEC2NetworkACL_espProtocol
=== RUN   TestAccEC2NetworkACLsDataSource_basic
=== PAUSE TestAccEC2NetworkACLsDataSource_basic
=== RUN   TestAccEC2NetworkACLsDataSource_filter
=== PAUSE TestAccEC2NetworkACLsDataSource_filter
=== RUN   TestAccEC2NetworkACLsDataSource_tags
=== PAUSE TestAccEC2NetworkACLsDataSource_tags
=== RUN   TestAccEC2NetworkACLsDataSource_vpcID
=== PAUSE TestAccEC2NetworkACLsDataSource_vpcID
=== RUN   TestAccEC2NetworkACLsDataSource_empty
=== PAUSE TestAccEC2NetworkACLsDataSource_empty
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
=== PAUSE TestAccVPC_IpamIpv4BasicNetmask
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
=== PAUSE TestAccVPC_IpamIpv4BasicExplicitCidr
=== CONT  TestAccEC2DefaultNetworkACL_basic
=== CONT  TestAccEC2NetworkACL_subnetsDelete
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccVPC_IpamIpv4BasicExplicitCidr
    acctest.go:759: skipping tests; missing IAM service-linked role /aws-service-role/ipam.amazonaws.com. Please create the role and retry
--- SKIP: TestAccVPC_IpamIpv4BasicExplicitCidr (1.90s)
=== CONT  TestAccVPC_IpamIpv4BasicNetmask
    acctest.go:759: skipping tests; missing IAM service-linked role /aws-service-role/ipam.amazonaws.com. Please create the role and retry
--- SKIP: TestAccVPC_IpamIpv4BasicNetmask (0.39s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
    availability_zone_data_source_test.go:204: skipping since no Local Zones are available
--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (0.51s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccEC2DefaultNetworkACL_basic (30.65s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (54.85s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccEC2NetworkACL_subnetsDelete (68.10s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_ignoreTags (56.18s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (109.90s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_defaultAndIgnoreTags (58.01s)
=== CONT  TestAccEC2NetworkACLRule_ipv6
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (1.36s)
=== CONT  TestAccEC2NetworkACL_subnets
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (48.11s)
=== CONT  TestAccEC2NetworkACL_subnetChange
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (47.29s)
=== CONT  TestAccEC2NetworkACL_onlyEgressRules
--- PASS: TestAccEC2NetworkACLRule_ipv6 (30.62s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccEC2NetworkACL_onlyEgressRules (42.40s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
--- PASS: TestAccEC2NetworkACL_subnets (64.51s)
=== CONT  TestAccVPC_classicLinkOptionSet
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
    acctest.go:1017: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error enabling EC2 VPC (vpc-098a1bf1b135c1a8f) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: fbd26ddc-9aeb-4027-b39d-dd596c1616e4
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
=== CONT  TestAccVPC_classicLinkOptionSet
    acctest.go:1017: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error enabling EC2 VPC (vpc-0218bebbb0baaa4aa) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: f2708172-7dfc-46da-ad03-7fe817aea4b6
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
--- PASS: TestAccEC2NetworkACL_subnetChange (70.56s)
=== CONT  TestAccEC2NetworkACL_caseSensitivityNoChanges
--- SKIP: TestAccVPC_classicLinkDNSSupportOptionSet (10.30s)
=== CONT  TestAccEC2NetworkACL_OnlyIngressRules_update
--- SKIP: TestAccVPC_classicLinkOptionSet (10.33s)
=== CONT  TestAccEC2NetworkACL_OnlyIngressRules_basic
--- PASS: TestAccVPC_tenancy (78.52s)
=== CONT  TestAccEC2NetworkACL_egressAndIngressRules
--- PASS: TestAccEC2NetworkACL_caseSensitivityNoChanges (46.27s)
=== CONT  TestAccEC2NetworkACLRule_tcpProtocol
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_basic (46.67s)
=== CONT  TestAccEC2NetworkACLRule_allProtocol
--- PASS: TestAccEC2NetworkACL_OnlyIngressRules_update (73.96s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccEC2NetworkACL_egressAndIngressRules (40.41s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccEC2NetworkACLRule_tcpProtocol (46.01s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccEC2NetworkACLRule_allProtocol (45.73s)
=== CONT  TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate
--- PASS: TestAccVPC_disabledDNSSupport (41.62s)
=== CONT  TestAccEC2NetworkACLsDataSource_empty
--- PASS: TestAccVPC_bothDNSOptionsSet (41.61s)
=== CONT  TestAccEC2NetworkACLRule_ipv6ICMP
--- PASS: TestAccEC2NetworkACLsDataSource_empty (12.79s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2NetworkACLRule_ipv6ICMP (31.64s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_updateDNSHostnames (57.78s)
=== CONT  TestAccEC2NetworkACL_Egress_mode
--- PASS: TestAccEC2NetworkACLRule_ipv6VPCAssignGeneratedIPv6CIDRBlockUpdate (66.46s)
=== CONT  TestAccEC2NetworkACL_basic
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (53.58s)
=== CONT  TestAccEC2NetworkACL_Ingress_mode
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (39.47s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccEC2NetworkACL_basic (28.51s)
=== CONT  TestAccEC2NetworkACL_tags
--- PASS: TestAccEC2NetworkACL_Egress_mode (77.69s)
=== CONT  TestAccEC2NetworkACLsDataSource_basic
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (40.70s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccEC2NetworkACLsDataSource_basic (26.78s)
=== CONT  TestAccEC2NetworkACLsDataSource_vpcID
--- PASS: TestAccEC2NetworkACL_Ingress_mode (80.62s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccEC2NetworkACL_tags (74.63s)
=== CONT  TestAccEC2NetworkACLsDataSource_tags
--- PASS: TestAccVPC_DefaultTags_providerOnly (54.22s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccEC2NetworkACLsDataSource_vpcID (28.69s)
=== CONT  TestAccEC2NetworkACLsDataSource_filter
--- PASS: TestAccEC2NetworkACLsDataSource_tags (27.44s)
=== CONT  TestAccEC2NetworkACL_ipv6VPCRules
--- PASS: TestAccVPC_disappears (17.82s)
=== CONT  TestAccEC2NetworkACL_disappears
--- PASS: TestAccEC2NetworkACLsDataSource_filter (27.40s)
=== CONT  TestAccEC2NetworkACL_espProtocol
--- PASS: TestAccEC2NetworkACL_disappears (26.52s)
=== CONT  TestAccEC2NetworkACLAssociation_disappears_NACL
--- PASS: TestAccEC2NetworkACL_ipv6VPCRules (41.84s)
=== CONT  TestAccEC2NetworkACL_ipv6ICMPRules
--- PASS: TestAccVPC_tags (76.54s)
=== CONT  TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber
--- PASS: TestAccEC2NetworkACL_espProtocol (30.71s)
=== CONT  TestAccEC2NetworkACLRule_basic
--- PASS: TestAccEC2NetworkACLAssociation_disappears_NACL (30.34s)
=== CONT  TestAccEC2NetworkACLAssociation_associateWithDefaultNACL
--- PASS: TestAccEC2NetworkACL_ipv6ICMPRules (26.81s)
=== CONT  TestAccEC2NetworkACLRule_Disappears_networkACL
--- PASS: TestAccEC2NetworkACLRule_Disappears_ingressEgressSameNumber (28.08s)
=== CONT  TestAccEC2NetworkACLRule_disappears
--- PASS: TestAccEC2NetworkACLRule_basic (38.62s)
=== CONT  TestAccEC2NetworkACL_ipv6Rules
--- PASS: TestAccEC2NetworkACLRule_Disappears_networkACL (28.58s)
=== CONT  TestAccEC2NetworkACLAssociation_twoAssociations
--- PASS: TestAccEC2NetworkACLAssociation_associateWithDefaultNACL (34.12s)
=== CONT  TestAccEC2DefaultNetworkACL_subnetRemoval
--- PASS: TestAccEC2NetworkACLRule_disappears (30.24s)
=== CONT  TestAccEC2DefaultNetworkACL_Deny_ingress
--- PASS: TestAccEC2NetworkACLAssociation_twoAssociations (36.24s)
=== CONT  TestAccEC2DefaultNetworkACL_withIPv6Ingress
--- PASS: TestAccEC2DefaultNetworkACL_Deny_ingress (28.31s)
=== CONT  TestAccEC2NetworkACLAssociation_basic
--- PASS: TestAccEC2NetworkACL_ipv6Rules (46.75s)
=== CONT  TestAccVPC_basic
--- PASS: TestAccEC2DefaultNetworkACL_subnetRemoval (58.85s)
=== CONT  TestAccEC2DefaultNetworkACL_tags
--- PASS: TestAccEC2DefaultNetworkACL_withIPv6Ingress (30.09s)
=== CONT  TestAccEC2DefaultNetworkACL_subnetReassign
--- PASS: TestAccVPC_basic (30.64s)
=== CONT  TestAccEC2NetworkACLAssociation_disappears_Subnet
--- PASS: TestAccEC2NetworkACLAssociation_basic (34.68s)
=== CONT  TestAccEC2DefaultNetworkACL_basicIPv6VPC
--- PASS: TestAccEC2NetworkACLAssociation_disappears_Subnet (28.93s)
=== CONT  TestAccEC2NetworkACLAssociation_disappears
--- PASS: TestAccEC2DefaultNetworkACL_basicIPv6VPC (39.52s)
--- PASS: TestAccEC2NetworkACLAssociation_disappears (30.73s)
--- PASS: TestAccEC2DefaultNetworkACL_subnetReassign (64.88s)
--- PASS: TestAccEC2DefaultNetworkACL_tags (72.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	713.723s

ewbankkit · 2022-02-08T20:41:31Z

@geofflancaster Thanks for the contribution 🎉 👏.

github-actions · 2022-02-10T18:14:50Z

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-20T02:32:35Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

geofflancaster added 2 commits February 16, 2021 21:09

created resource files. Copied test file from another resource

49408fa

working test case

88f90a2

geofflancaster requested a review from a team as a code owner April 12, 2021 21:58

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2021

geofflancaster added 14 commits April 12, 2021 17:00

removed unused code

382b6cb

updated read function

5a682ab

reformated markdown

1017b06

fixed lint errors

fa6df7b

fixed md lint error

98181a5

lint updates

e0d21a4

lint error fixes

c6cb16c

update markdown

daa5fc5

fixed fmt

456a2f9

fixed missing subnet association error

7a6816a

added lint ignore

98dc232

trying to get the nilerr lint to pass

5b84987

switch from lint:ignore to nolint

894f358

removed update code since it isn't used

f08c8da

YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2021

Merge remote-tracking branch 'origin' into subnet-nacl-association

3a50f44

ewbankkit added 17 commits February 6, 2022 17:46

r/aws_network_acl: Tidy up sweeper.

228177d

Tweak 'networkACLProtocolNumber'.

0b6ab2e

Add CHANGELOG entry.

0bd6c95

r/aws_vpc: Restore resourceVPCCustomizeDiff functionality from hashic…

3e0c6d7

…orp#6721 mistakenly removed in hashicorp#22420.

github-actions bot added sweeper Pertains to changes to or issues with the sweeper. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 8, 2022

ewbankkit added 2 commits February 8, 2022 13:38

Correct documentation page file name.

f372d7d

Fix terrafmt errors.

f2aee7c

ewbankkit approved these changes Feb 8, 2022

View reviewed changes

ewbankkit merged commit de6e94d into hashicorp:main Feb 8, 2022

github-actions bot added this to the v4.0.0 milestone Feb 8, 2022

github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022

geofflancaster deleted the subnet-nacl-association branch May 23, 2023 15:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subnet nacl association #18807

Subnet nacl association #18807

geofflancaster commented Apr 12, 2021 •

edited by ewbankkit

YakDriver commented Apr 15, 2021

geofflancaster commented May 10, 2021

geofflancaster commented Aug 6, 2021

zhelding commented Oct 19, 2021

ewbankkit left a comment

ewbankkit commented Feb 8, 2022

github-actions bot commented Feb 10, 2022

github-actions bot commented May 20, 2022

Subnet nacl association #18807

Subnet nacl association #18807

Conversation

geofflancaster commented Apr 12, 2021 • edited by ewbankkit

Community Note

YakDriver commented Apr 15, 2021

geofflancaster commented May 10, 2021

geofflancaster commented Aug 6, 2021

zhelding commented Oct 19, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Feb 8, 2022

github-actions bot commented Feb 10, 2022

github-actions bot commented May 20, 2022

geofflancaster commented Apr 12, 2021 •

edited by ewbankkit