Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags argument to resource/aws_aws_organizations_organizational_unit (#15476) #18861

Merged
merged 7 commits into from
Apr 22, 2021
Merged

Add tags argument to resource/aws_aws_organizations_organizational_unit (#15476) #18861

merged 7 commits into from
Apr 22, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 14, 2021 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Continues work in #15615
Closes #15476
Relates #7926

Output from acceptance testing:

--- PASS: TestAccAWSOrganizations_serial (119.73s)
    --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit (102.49s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/basic (21.51s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/disappears (15.73s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/Name (28.55s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/Tags (36.71s)
    --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnits (0.00s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnits/DataSource (17.24s)
PASS

@anGie44 anGie44 requested a review from a team as a code owner April 14, 2021 17:33
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 14, 2021
@anGie44 anGie44 closed this Apr 14, 2021
@anGie44 anGie44 deleted the issue-15476 branch April 14, 2021 17:37
@anGie44 anGie44 restored the issue-15476 branch April 22, 2021 00:56
@anGie44 anGie44 reopened this Apr 22, 2021
@anGie44 anGie44 mentioned this pull request Apr 22, 2021
Closed
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 22, 2021
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 22, 2021
@bflad bflad self-assigned this Apr 22, 2021
bflad
bflad approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Output from acceptance testing:

    --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit (92.72s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/basic (18.49s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/disappears (14.16s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/Name (25.11s)
        --- PASS: TestAccAWSOrganizations_serial/OrganizationalUnit/Tags (34.96s)

@anGie44 anGie44 added this to the v3.38.0 milestone Apr 22, 2021
@anGie44 anGie44 merged commit 2f42211 into main Apr 22, 2021
@anGie44 anGie44 deleted the issue-15476 branch April 22, 2021 14:43
github-actions bot pushed a commit that referenced this pull request Apr 22, 2021
Update CHANGELOG.md for #18861
e8056b5
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

tags attribute support for aws_organizations_organizational_unit
2 participants
@anGie44 @bflad