Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: update SetTagsDiff when setting the computed tags_all attribute #18958

Merged
merged 3 commits into from
Apr 20, 2021
Merged

provider: update SetTagsDiff when setting the computed tags_all attribute #18958

merged 3 commits into from
Apr 20, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18366

Output from acceptance testing before code change in aws/tags.go:

Error: Provider produced inconsistent final plan

        When expanding the plan for aws_subnet.test to include new values learned so
        far during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "key1" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.


        Error: Provider produced inconsistent final plan

        When expanding the plan for aws_subnet.test to include new values learned so
        far during apply, provider "registry.terraform.io/hashicorp/aws" produced an
        invalid new value for .tags_all: new element "key2" has appeared.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

Output from acceptance testing after code change in aws/tags.go:

--- PASS: TestAccAWSSubnet_updateTagsKnownAtApply (27.48s)

@anGie44 anGie44 requested a review from a team as a code owner April 19, 2021 21:29
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 19, 2021
@YakDriver YakDriver self-assigned this Apr 19, 2021
YakDriver
YakDriver approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSSubnet_updateTagsKnownAtApply (52.64s)

Output from acceptance tests (us-east-1):

--- PASS: TestAccAWSSubnet_updateTagsKnownAtApply (26.35s)

Output from acceptance tests (GovCloud):

--- PASS: TestAccAWSSubnet_updateTagsKnownAtApply (58.31s)

anGie44
anGie44 commented Apr 20, 2021
View reviewed changes
aws/tags.go
}
} else {
if err := diff.SetNewComputed("tags_all"); err != nil {
return fmt.Errorf("error setting tags_all to computed: %w", err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the messaging here in-case we'd need to differentiate between the 2 errors

@anGie44 anGie44 added this to the v3.38.0 milestone Apr 20, 2021
@anGie44 anGie44 merged commit 78170f2 into main Apr 20, 2021
@anGie44 anGie44 deleted the b-default-tags-custom-diff-for-computed branch April 20, 2021 00:59
github-actions bot pushed a commit that referenced this pull request Apr 20, 2021
Update CHANGELOG.md for #18958
0184fc4
@anGie44 anGie44 mentioned this pull request Apr 20, 2021
Closed
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

Provider produced inconsistent final plan - tags_all errors without using default_tags block
2 participants
@anGie44 @YakDriver