Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using aws_dms_replication_task without replication_task_settings being provided #19021

Closed
dealweb723 opened this issue Apr 20, 2021 · 4 comments · Fixed by #36936
Closed

Using aws_dms_replication_task without replication_task_settings being provided #19021

dealweb723 opened this issue Apr 20, 2021 · 4 comments · Fixed by #36936
Assignees
Labels
bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@dealweb723
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

  • terraform 13.6
  • hashicorp/aws 3.36

Affected Resource(s)

  • aws_dms_replication_task

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_dms_replication_task" "dms_rep_task" {
  migration_type            = "full-load-and-cdc"
  replication_instance_arn  = [remove for security reasons]
  replication_task_id       = "my-dms-task-id"
  source_endpoint_arn       = [remove for security reasons]
  table_mappings            = "{\"rules\":[{\"rule-type\":\"selection\",\"rule-id\":\"1\",\"rule-name\":\"1\",\"object-locator\":{\"schema-name\":\"%\",\"table-name\":\"%\"},\"rule-action\":\"include\"}]}"

  target_endpoint_arn       = [remove for security reasons]
}

Debug Output

Panic Output

Expected Behavior

Expected tf apply to be able to run multiple times without issue

Actual Behavior

  • Running aws_dms_replication_task but without providing replication_task_settings as that is an optional setting per the doc (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dms_replication_task#replication_task_settings)
  • Everything is created just fine after the first apply
  • Run the same tf code again and still without the optional replication_task_settings and it fails. In looking at tf plan it shows that replication_task_settings is there and it plans to remove it. The tf apply fails with "Error: InvalidParameterCombinationException: No modifications were requested on the task"
  • The work around is to add some dummy json to aws_dms_replication_task in the initial build and keep that in any builds onwards.

Steps to Reproduce

  1. Run terraform apply
  2. Rerun terraform apply

Important Factoids

References

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 20, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 6, 2021
@Sebor
Copy link

Sebor commented Sep 1, 2021

I've faced with the same issue.
it is necessary to use

  lifecycle {
    ignore_changes = [replication_task_settings]
  }

as dirty workaround

@ewbankkit ewbankkit added the service/dms Issues and PRs that pertain to the dms service. label Jun 2, 2022
@gdavison gdavison self-assigned this Apr 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 10, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.46.0 milestone Apr 17, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
6 participants