Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_wafv2_logging_configuration: add support for logging_filter #19051

Merged
merged 4 commits into from
Apr 22, 2021
Merged

resource/aws_wafv2_logging_configuration: add support for logging_filter #19051

merged 4 commits into from
Apr 22, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 22, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18665

Output from acceptance testing:

--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_emptyRedactedFields (373.82s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_basic (456.06s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_disappears (572.65s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_disappears_WebAcl (584.69s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateMethodRedactedField (585.70s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateEmptyRedactedFields (653.53s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_changeResourceARNForceNew (717.29s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateQueryStringRedactedField (738.86s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateUriPathRedactedField (738.91s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_changeLogDestinationConfigsForceNew (762.54s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateMultipleRedactedFields (827.28s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateSingleHeaderRedactedField (841.12s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_loggingFilter (865.88s)

@anGie44 anGie44 requested a review from a team as a code owner April 22, 2021 01:02
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 22, 2021
@anGie44 anGie44 force-pushed the f-wafv2-logging-config-record-filtering branch 5 times, most recently from 54bc33a to c01dd72 Compare April 22, 2021 01:18
@anGie44 anGie44 force-pushed the f-wafv2-logging-config-record-filtering branch from c01dd72 to e95255c Compare April 22, 2021 01:55
@bflad bflad self-assigned this Apr 22, 2021
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 22, 2021
bflad
bflad approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor validation nits, otherwise looks great! 🚀

Output from acceptance testing:

--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_emptyRedactedFields (102.35s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_disappears_WebAcl (103.33s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_basic (104.64s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_disappears (121.55s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateSingleHeaderRedactedField (132.30s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateMethodRedactedField (135.95s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateUriPathRedactedField (137.04s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateEmptyRedactedFields (141.10s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateQueryStringRedactedField (141.97s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_updateMultipleRedactedFields (146.92s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_loggingFilter (176.18s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_changeResourceARNForceNew (188.33s)
--- PASS: TestAccAwsWafv2WebACLLoggingConfiguration_changeLogDestinationConfigsForceNew (193.05s)

aws/resource_aws_wafv2_web_acl_logging_configuration.go Outdated Show resolved Hide resolved
aws/resource_aws_wafv2_web_acl_logging_configuration.go Outdated Show resolved Hide resolved
aws/resource_aws_wafv2_web_acl_logging_configuration.go
output, err := conn.GetLoggingConfiguration(input)

if !d.IsNewResource() && tfawserr.ErrCodeEquals(err, wafv2.ErrCodeWAFNonexistentItemException) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

anGie44 and others added 2 commits April 22, 2021 11:49
@anGie44 @bflad
Update aws/resource_aws_wafv2_web_acl_logging_configuration.go
be9c2e2 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@anGie44 @bflad
Update aws/resource_aws_wafv2_web_acl_logging_configuration.go
c0ea8cd 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@anGie44 anGie44 added this to the v3.38.0 milestone Apr 22, 2021
@anGie44 anGie44 merged commit 5c1576d into main Apr 22, 2021
@anGie44 anGie44 deleted the f-wafv2-logging-config-record-filtering branch April 22, 2021 16:40
github-actions bot pushed a commit that referenced this pull request Apr 22, 2021
Update CHANGELOG.md for #19051
166e130
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@mcab mcab mentioned this pull request May 24, 2021
Closed
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

Support record filtering for AWS WAF logging configuration
2 participants
@anGie44 @bflad