Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/resource aws batch job queue #19121

Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 27, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18638.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSBatchJobQueue'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBatchJobQueue -timeout 180m
=== RUN   TestAccAWSBatchJobQueue_basic
=== PAUSE TestAccAWSBatchJobQueue_basic
=== RUN   TestAccAWSBatchJobQueue_disappears
=== PAUSE TestAccAWSBatchJobQueue_disappears
=== RUN   TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== PAUSE TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== RUN   TestAccAWSBatchJobQueue_updateName
=== PAUSE TestAccAWSBatchJobQueue_updateName
=== RUN   TestAccAWSBatchJobQueue_Priority
=== PAUSE TestAccAWSBatchJobQueue_Priority
=== RUN   TestAccAWSBatchJobQueue_State
=== PAUSE TestAccAWSBatchJobQueue_State
=== RUN   TestAccAWSBatchJobQueue_Tags
=== PAUSE TestAccAWSBatchJobQueue_Tags
=== CONT  TestAccAWSBatchJobQueue_basic
=== CONT  TestAccAWSBatchJobQueue_Priority
=== CONT  TestAccAWSBatchJobQueue_Tags
=== CONT  TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== CONT  TestAccAWSBatchJobQueue_updateName
=== CONT  TestAccAWSBatchJobQueue_State
=== CONT  TestAccAWSBatchJobQueue_disappears
--- PASS: TestAccAWSBatchJobQueue_basic (151.61s)
--- PASS: TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate (151.72s)
--- PASS: TestAccAWSBatchJobQueue_disappears (183.27s)
--- PASS: TestAccAWSBatchJobQueue_Priority (213.43s)
--- PASS: TestAccAWSBatchJobQueue_Tags (242.71s)
--- PASS: TestAccAWSBatchJobQueue_State (247.28s)
--- PASS: TestAccAWSBatchJobQueue_updateName (370.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	374.361s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner April 27, 2021 13:20
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/batch Issues and PRs that pertain to the batch service. labels Apr 27, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 27, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 27, 2021
@ewbankkit ewbankkit self-assigned this Apr 27, 2021
@ewbankkit ewbankkit force-pushed the f/resource_aws_batch_job_queue branch from 331d865 to 824379f Compare April 27, 2021 13:56
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchJobQueue_'         
==> Checking that code complies with gofmt requirements...
=== RUN   TestAccAWSBatchJobQueue_basic
=== PAUSE TestAccAWSBatchJobQueue_basic
=== RUN   TestAccAWSBatchJobQueue_disappears
=== PAUSE TestAccAWSBatchJobQueue_disappears
=== RUN   TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== PAUSE TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== RUN   TestAccAWSBatchJobQueue_Priority
=== PAUSE TestAccAWSBatchJobQueue_Priority
=== RUN   TestAccAWSBatchJobQueue_State
=== PAUSE TestAccAWSBatchJobQueue_State
=== RUN   TestAccAWSBatchJobQueue_Tags
=== PAUSE TestAccAWSBatchJobQueue_Tags
=== CONT  TestAccAWSBatchJobQueue_basic
=== CONT  TestAccAWSBatchJobQueue_State
=== CONT  TestAccAWSBatchJobQueue_Tags
=== CONT  TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== CONT  TestAccAWSBatchJobQueue_disappears
=== CONT  TestAccAWSBatchJobQueue_Priority
--- PASS: TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate (93.78s)
--- PASS: TestAccAWSBatchJobQueue_State (98.06s)
--- PASS: TestAccAWSBatchJobQueue_Priority (98.51s)
--- PASS: TestAccAWSBatchJobQueue_basic (101.64s)
--- PASS: TestAccAWSBatchJobQueue_disappears (102.99s)
--- PASS: TestAccAWSBatchJobQueue_Tags (155.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	158.841s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSBatchJobQueue_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBatchJobQueue_ -timeout 180m
=== RUN   TestAccAWSBatchJobQueue_basic
=== PAUSE TestAccAWSBatchJobQueue_basic
=== RUN   TestAccAWSBatchJobQueue_disappears
=== PAUSE TestAccAWSBatchJobQueue_disappears
=== RUN   TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== PAUSE TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== RUN   TestAccAWSBatchJobQueue_Priority
=== PAUSE TestAccAWSBatchJobQueue_Priority
=== RUN   TestAccAWSBatchJobQueue_State
=== PAUSE TestAccAWSBatchJobQueue_State
=== RUN   TestAccAWSBatchJobQueue_Tags
=== PAUSE TestAccAWSBatchJobQueue_Tags
=== CONT  TestAccAWSBatchJobQueue_basic
=== CONT  TestAccAWSBatchJobQueue_State
=== CONT  TestAccAWSBatchJobQueue_Tags
=== CONT  TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate
=== CONT  TestAccAWSBatchJobQueue_Priority
=== CONT  TestAccAWSBatchJobQueue_disappears
--- PASS: TestAccAWSBatchJobQueue_ComputeEnvironments_ExternalOrderUpdate (115.92s)
--- PASS: TestAccAWSBatchJobQueue_disappears (125.15s)
--- PASS: TestAccAWSBatchJobQueue_basic (145.80s)
--- PASS: TestAccAWSBatchJobQueue_Tags (147.25s)
--- PASS: TestAccAWSBatchJobQueue_State (148.02s)
--- PASS: TestAccAWSBatchJobQueue_Priority (148.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	151.365s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 👏.
All looks good - Just added a CHANGELOG entry.

@ewbankkit ewbankkit merged commit fd79111 into hashicorp:main Apr 27, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 27, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@nikhil-goenka nikhil-goenka deleted the f/resource_aws_batch_job_queue branch May 1, 2021 04:22
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_batch_job_queue name should be ForceNew: true
2 participants