Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/resource aws codestarconnections connection - support for host_arn #19284

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented May 8, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17592.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeStarConnectionsConnection_'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeStarConnectionsConnection_ -timeout 180m
=== RUN   TestAccAWSCodeStarConnectionsConnection_Basic
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Basic
=== RUN   TestAccAWSCodeStarConnectionsConnection_HostArn
=== PAUSE TestAccAWSCodeStarConnectionsConnection_HostArn
=== RUN   TestAccAWSCodeStarConnectionsConnection_disappears
=== PAUSE TestAccAWSCodeStarConnectionsConnection_disappears
=== RUN   TestAccAWSCodeStarConnectionsConnection_Tags
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT  TestAccAWSCodeStarConnectionsConnection_Basic
=== CONT  TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT  TestAccAWSCodeStarConnectionsConnection_disappears
=== CONT  TestAccAWSCodeStarConnectionsConnection_HostArn
--- PASS: TestAccAWSCodeStarConnectionsConnection_disappears (31.99s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Basic (45.22s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_HostArn (49.88s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Tags (108.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	112.031s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner May 8, 2021 11:40
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 8, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 8, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label May 8, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 10, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
%  make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== RUN   TestAccAWSCodeStarConnectionsConnection_Basic
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Basic
=== RUN   TestAccAWSCodeStarConnectionsConnection_HostArn
=== PAUSE TestAccAWSCodeStarConnectionsConnection_HostArn
=== RUN   TestAccAWSCodeStarConnectionsConnection_disappears
=== PAUSE TestAccAWSCodeStarConnectionsConnection_disappears
=== RUN   TestAccAWSCodeStarConnectionsConnection_Tags
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT  TestAccAWSCodeStarConnectionsConnection_disappears
=== CONT  TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT  TestAccAWSCodeStarConnectionsConnection_Basic
=== CONT  TestAccAWSCodeStarConnectionsConnection_HostArn
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_tags
--- PASS: TestAccAWSCodeStarConnectionsConnection_disappears (12.83s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (16.55s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (16.75s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Basic (17.20s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_HostArn (19.83s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Tags (36.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.811s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection_\|TestAccAWSCodeStarConnectionsConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== RUN   TestAccAWSCodeStarConnectionsConnection_Basic
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Basic
=== RUN   TestAccAWSCodeStarConnectionsConnection_HostArn
=== PAUSE TestAccAWSCodeStarConnectionsConnection_HostArn
=== RUN   TestAccAWSCodeStarConnectionsConnection_disappears
=== PAUSE TestAccAWSCodeStarConnectionsConnection_disappears
=== RUN   TestAccAWSCodeStarConnectionsConnection_Tags
=== PAUSE TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT  TestAccAWSCodeStarConnectionsConnection_Tags
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== CONT  TestAccAWSCodeStarConnectionsConnection_HostArn
=== CONT  TestAccAWSCodeStarConnectionsConnection_disappears
=== CONT  TestAccAWSCodeStarConnectionsConnection_Basic
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_tags
    provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
=== CONT  TestAccAWSCodeStarConnectionsConnection_Tags
    provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (2.40s)
--- SKIP: TestAccAWSCodeStarConnectionsConnection_Tags (2.40s)
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_basic
    provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (2.40s)
=== CONT  TestAccAWSCodeStarConnectionsConnection_disappears
    provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccAWSCodeStarConnectionsConnection_disappears (2.40s)
=== CONT  TestAccAWSCodeStarConnectionsConnection_Basic
    provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccAWSCodeStarConnectionsConnection_Basic (2.40s)
=== CONT  TestAccAWSCodeStarConnectionsConnection_HostArn
    provider_test.go:721: skipping tests; partition aws-us-gov does not support codestar-connections service
--- SKIP: TestAccAWSCodeStarConnectionsConnection_HostArn (2.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6.897s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 👏.
I went ahead and added the host_arn attribute to the aws_codestarconnections_connection data source.

@ewbankkit ewbankkit merged commit 50521dd into hashicorp:main May 10, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 10, 2021
@nikhil-goenka nikhil-goenka deleted the f/resource_aws_codestarconnections_connection branch May 10, 2021 15:26
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GitHubEnterpriseServer codestarconnections_host on codestarconnections_connection
2 participants