Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rd/lb_listener - add tagging support #19286

Merged
merged 9 commits into from
May 10, 2021
Merged

rd/lb_listener - add tagging support #19286

merged 9 commits into from
May 10, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 9, 2021 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSLBListener_basic (238.97s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (258.95s)
--- PASS: TestAccAWSLBListener_redirect (268.95s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (283.98s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (252.78s)
--- PASS: TestAccAWSLBListener_fixedResponse (256.44s)
--- PASS: TestAccAWSLBListener_forwardWeighted (344.86s)
--- PASS: TestAccAWSLBListener_basicUdp (352.52s)
--- PASS: TestAccAWSLBListener_cognito (239.13s)
--- PASS: TestAccAWSLBListener_oidc (234.86s)
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (262.75s)
--- PASS: TestAccAWSLBListener_tags (343.80s)
--- PASS: TestAccAWSLBListener_https (268.00s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (393.24s)


--- PASS: TestAccDataSourceAWSLBListener_https (228.32s)
--- PASS: TestAccDataSourceAWSLBListener_basic (246.71s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (247.13s)
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (280.80s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 9, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review May 9, 2021 22:18
@DrFaust92 DrFaust92 requested a review from a team as a code owner May 9, 2021 22:18
@DrFaust92 DrFaust92 changed the title r/lb_listener - add tagging support rd/lb_listener - add tagging support May 9, 2021
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 9, 2021
@ewbankkit ewbankkit self-assigned this May 10, 2021
ewbankkit
ewbankkit approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBListener_\|TestAccDataSourceAWSLBListener_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSLBListener_\|TestAccDataSourceAWSLBListener_ -timeout 180m
=== RUN   TestAccDataSourceAWSLBListener_basic
=== PAUSE TestAccDataSourceAWSLBListener_basic
=== RUN   TestAccDataSourceAWSLBListener_BackwardsCompatibility
=== PAUSE TestAccDataSourceAWSLBListener_BackwardsCompatibility
=== RUN   TestAccDataSourceAWSLBListener_https
=== PAUSE TestAccDataSourceAWSLBListener_https
=== RUN   TestAccDataSourceAWSLBListener_DefaultAction_Forward
=== PAUSE TestAccDataSourceAWSLBListener_DefaultAction_Forward
=== RUN   TestAccAWSLBListener_basic
=== PAUSE TestAccAWSLBListener_basic
=== RUN   TestAccAWSLBListener_tags
=== PAUSE TestAccAWSLBListener_tags
=== RUN   TestAccAWSLBListener_forwardWeighted
=== PAUSE TestAccAWSLBListener_forwardWeighted
=== RUN   TestAccAWSLBListener_basicUdp
=== PAUSE TestAccAWSLBListener_basicUdp
=== RUN   TestAccAWSLBListener_BackwardsCompatibility
=== PAUSE TestAccAWSLBListener_BackwardsCompatibility
=== RUN   TestAccAWSLBListener_https
=== PAUSE TestAccAWSLBListener_https
=== RUN   TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
=== PAUSE TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
=== RUN   TestAccAWSLBListener_Protocol_Tls
=== PAUSE TestAccAWSLBListener_Protocol_Tls
=== RUN   TestAccAWSLBListener_redirect
=== PAUSE TestAccAWSLBListener_redirect
=== RUN   TestAccAWSLBListener_fixedResponse
=== PAUSE TestAccAWSLBListener_fixedResponse
=== RUN   TestAccAWSLBListener_cognito
=== PAUSE TestAccAWSLBListener_cognito
=== RUN   TestAccAWSLBListener_oidc
=== PAUSE TestAccAWSLBListener_oidc
=== RUN   TestAccAWSLBListener_DefaultAction_Order
=== PAUSE TestAccAWSLBListener_DefaultAction_Order
=== RUN   TestAccAWSLBListener_DefaultAction_Order_Recreates
=== PAUSE TestAccAWSLBListener_DefaultAction_Order_Recreates
=== CONT  TestAccDataSourceAWSLBListener_basic
=== CONT  TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
=== CONT  TestAccAWSLBListener_oidc
--- PASS: TestAccDataSourceAWSLBListener_basic (199.15s)
=== CONT  TestAccAWSLBListener_fixedResponse
--- PASS: TestAccAWSLBListener_oidc (212.59s)
=== CONT  TestAccAWSLBListener_cognito
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (235.71s)
=== CONT  TestAccAWSLBListener_DefaultAction_Order_Recreates
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (199.82s)
=== CONT  TestAccAWSLBListener_Protocol_Tls
--- PASS: TestAccAWSLBListener_cognito (224.03s)
=== CONT  TestAccAWSLBListener_tags
--- PASS: TestAccAWSLBListener_fixedResponse (240.22s)
=== CONT  TestAccAWSLBListener_https
--- PASS: TestAccAWSLBListener_tags (230.18s)
=== CONT  TestAccAWSLBListener_BackwardsCompatibility
--- PASS: TestAccAWSLBListener_https (231.08s)
=== CONT  TestAccAWSLBListener_basicUdp
--- PASS: TestAccAWSLBListener_Protocol_Tls (359.77s)
=== CONT  TestAccAWSLBListener_redirect
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (228.26s)
=== CONT  TestAccAWSLBListener_forwardWeighted
--- PASS: TestAccAWSLBListener_redirect (230.05s)
=== CONT  TestAccDataSourceAWSLBListener_DefaultAction_Forward
--- PASS: TestAccAWSLBListener_basicUdp (369.78s)
=== CONT  TestAccDataSourceAWSLBListener_https
--- PASS: TestAccAWSLBListener_forwardWeighted (255.92s)
=== CONT  TestAccAWSLBListener_basic
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (213.60s)
=== CONT  TestAccDataSourceAWSLBListener_BackwardsCompatibility
--- PASS: TestAccDataSourceAWSLBListener_https (250.98s)
=== CONT  TestAccAWSLBListener_DefaultAction_Order
--- PASS: TestAccAWSLBListener_basic (187.89s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (218.74s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (198.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1493.707s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBListener_\|TestAccDataSourceAWSLBListener_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLBListener_\|TestAccDataSourceAWSLBListener_ -timeout 180m
=== RUN   TestAccDataSourceAWSLBListener_basic
=== PAUSE TestAccDataSourceAWSLBListener_basic
=== RUN   TestAccDataSourceAWSLBListener_BackwardsCompatibility
=== PAUSE TestAccDataSourceAWSLBListener_BackwardsCompatibility
=== RUN   TestAccDataSourceAWSLBListener_https
=== PAUSE TestAccDataSourceAWSLBListener_https
=== RUN   TestAccDataSourceAWSLBListener_DefaultAction_Forward
=== PAUSE TestAccDataSourceAWSLBListener_DefaultAction_Forward
=== RUN   TestAccAWSLBListener_basic
=== PAUSE TestAccAWSLBListener_basic
=== RUN   TestAccAWSLBListener_tags
=== PAUSE TestAccAWSLBListener_tags
=== RUN   TestAccAWSLBListener_forwardWeighted
=== PAUSE TestAccAWSLBListener_forwardWeighted
=== RUN   TestAccAWSLBListener_basicUdp
=== PAUSE TestAccAWSLBListener_basicUdp
=== RUN   TestAccAWSLBListener_BackwardsCompatibility
=== PAUSE TestAccAWSLBListener_BackwardsCompatibility
=== RUN   TestAccAWSLBListener_https
=== PAUSE TestAccAWSLBListener_https
=== RUN   TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
=== PAUSE TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
=== RUN   TestAccAWSLBListener_Protocol_Tls
=== PAUSE TestAccAWSLBListener_Protocol_Tls
=== RUN   TestAccAWSLBListener_redirect
=== PAUSE TestAccAWSLBListener_redirect
=== RUN   TestAccAWSLBListener_fixedResponse
=== PAUSE TestAccAWSLBListener_fixedResponse
=== RUN   TestAccAWSLBListener_cognito
=== PAUSE TestAccAWSLBListener_cognito
=== RUN   TestAccAWSLBListener_oidc
=== PAUSE TestAccAWSLBListener_oidc
=== RUN   TestAccAWSLBListener_DefaultAction_Order
=== PAUSE TestAccAWSLBListener_DefaultAction_Order
=== RUN   TestAccAWSLBListener_DefaultAction_Order_Recreates
=== PAUSE TestAccAWSLBListener_DefaultAction_Order_Recreates
=== CONT  TestAccDataSourceAWSLBListener_basic
=== CONT  TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
=== CONT  TestAccAWSLBListener_DefaultAction_Order_Recreates
=== CONT  TestAccAWSLBListener_Protocol_Tls
=== CONT  TestAccAWSLBListener_redirect
=== CONT  TestAccAWSLBListener_basicUdp
=== CONT  TestAccDataSourceAWSLBListener_https
=== CONT  TestAccAWSLBListener_BackwardsCompatibility
=== CONT  TestAccAWSLBListener_cognito
=== CONT  TestAccAWSLBListener_DefaultAction_Order
=== CONT  TestAccAWSLBListener_https
=== CONT  TestAccAWSLBListener_oidc
=== CONT  TestAccAWSLBListener_fixedResponse
=== CONT  TestAccAWSLBListener_forwardWeighted
=== CONT  TestAccDataSourceAWSLBListener_DefaultAction_Forward
=== CONT  TestAccAWSLBListener_tags
=== CONT  TestAccAWSLBListener_basic
=== CONT  TestAccDataSourceAWSLBListener_BackwardsCompatibility
=== CONT  TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer
    provider_test.go:1072: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/10 10:06:24 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating gateway Load Balancer: ValidationError: Type must be one of: 'application, network'
        	status code: 400, request id: 31c30ee7-e0f5-40cd-851b-4dcd85dd797c
        
          on terraform_plugin_test.tf line 29, in resource "aws_lb" "test":
          29: resource "aws_lb" "test" {
        
        
        
        Error: error creating LB Target Group: ValidationError: Protocol 'GENEVE' must be one of 'TCP,UDP,TCP_UDP,HTTPS,HTTP,TLS'
        	status code: 400, request id: 11add5b5-d996-43d7-8d58-1089175293ac
        
          on terraform_plugin_test.tf line 38, in resource "aws_lb_target_group" "test":
          38: resource "aws_lb_target_group" "test" {
        
        
--- SKIP: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (29.87s)
=== CONT  TestAccAWSLBListener_cognito
    provider_test.go:1072: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/10 10:06:24 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating ELBv2 Listener (arn:aws-us-gov:elasticloadbalancing:us-gov-west-1:357342307427:loadbalancer/app/tf-acc-test-4847333944184910203/04257d9fe9c74b4e): ValidationError: Action type 'authenticate-cognito' must be one of 'redirect,fixed-response,forward,authenticate-oidc'
        	status code: 400, request id: 40777c4f-a834-4a00-bfc8-d797c67432ee
        
          on terraform_plugin_test.tf line 128, in resource "aws_lb_listener" "test":
         128: resource "aws_lb_listener" "test" {
        
        
--- SKIP: TestAccAWSLBListener_cognito (156.04s)
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (161.49s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (170.13s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (170.36s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (170.38s)
--- PASS: TestAccAWSLBListener_fixedResponse (172.56s)
--- PASS: TestAccDataSourceAWSLBListener_https (174.50s)
--- PASS: TestAccAWSLBListener_redirect (175.39s)
--- PASS: TestAccAWSLBListener_oidc (181.47s)
--- PASS: TestAccDataSourceAWSLBListener_basic (184.04s)
--- PASS: TestAccAWSLBListener_basic (215.68s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (223.97s)
--- PASS: TestAccAWSLBListener_tags (224.87s)
--- PASS: TestAccAWSLBListener_https (226.29s)
--- PASS: TestAccAWSLBListener_forwardWeighted (231.59s)
--- PASS: TestAccAWSLBListener_basicUdp (358.99s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (391.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	395.333s

@ewbankkit ewbankkit merged commit c777989 into hashicorp:main May 10, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 10, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
@DrFaust92 DrFaust92 deleted the r/lb_listner_tags branch February 12, 2022 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.40.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrFaust92 @ewbankkit