resource/networkfirewall_rule_group: check configuration changes in rules when determining update input

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19414

Output from acceptance testing:

--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRules (163.26s)

--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rules (166.65s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList (166.88s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction (178.55s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule (178.77s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule (178.78s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_disappears (193.26s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList (266.68s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule (312.36s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_header (312.82s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule (329.79s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_tags (339.96s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules (386.25s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_action (393.60s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (405.81s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAwsNetworkFirewallRuleGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsNetworkFirewallRuleGroup_ -timeout 180m
=== RUN   TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList
=== RUN   TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule
=== RUN   TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule
=== RUN   TestAccAwsNetworkFirewallRuleGroup_basic_rules
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_basic_rules
=== RUN   TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccAwsNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccAwsNetworkFirewallRuleGroup_statefulRule_action
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_statefulRule_action
=== RUN   TestAccAwsNetworkFirewallRuleGroup_statefulRule_header
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_statefulRule_header
=== RUN   TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccAwsNetworkFirewallRuleGroup_tags
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_tags
=== RUN   TestAccAwsNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccAwsNetworkFirewallRuleGroup_disappears
=== CONT  TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList
=== CONT  TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccAwsNetworkFirewallRuleGroup_statefulRule_header
=== CONT  TestAccAwsNetworkFirewallRuleGroup_statefulRule_action
=== CONT  TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccAwsNetworkFirewallRuleGroup_basic_rules
=== CONT  TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule
=== CONT  TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccAwsNetworkFirewallRuleGroup_updateRules
=== CONT  TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule
=== CONT  TestAccAwsNetworkFirewallRuleGroup_disappears
=== CONT  TestAccAwsNetworkFirewallRuleGroup_tags
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rulesSourceList (147.83s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_rules (148.18s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_disappears (151.46s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatefulRule (164.07s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statelessRuleWithCustomAction (168.88s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statefulRule (169.17s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_basic_statelessRule (169.49s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_header (172.77s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRulesSourceList (175.44s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateRules (175.62s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_tags (193.65s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateStatelessRule (196.56s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_updateMultipleStatefulRules (198.88s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (207.17s)
--- PASS: TestAccAwsNetworkFirewallRuleGroup_statefulRule_action (209.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	212.792s

[ghost]

This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.