Predictive autoscaling

[bill-rich]

Add predictive autoscaling support to aws_autoscaling_policy.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAutoscalingPolicy_ -timeout 180m
=== RUN   TestAccAWSAutoscalingPolicy_basic
=== PAUSE TestAccAWSAutoscalingPolicy_basic
=== RUN   TestAccAWSAutoscalingPolicy_predictiveScaling
=== PAUSE TestAccAWSAutoscalingPolicy_predictiveScaling
=== RUN   TestAccAWSAutoscalingPolicy_predictiveScalingRemoved
=== PAUSE TestAccAWSAutoscalingPolicy_predictiveScalingRemoved
=== RUN   TestAccAWSAutoscalingPolicy_predictiveScalingUpdated
=== PAUSE TestAccAWSAutoscalingPolicy_predictiveScalingUpdated
=== RUN   TestAccAWSAutoscalingPolicy_disappears
=== PAUSE TestAccAWSAutoscalingPolicy_disappears
=== RUN   TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment
=== PAUSE TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment
=== RUN   TestAccAWSAutoscalingPolicy_TargetTrack_Predefined
=== PAUSE TestAccAWSAutoscalingPolicy_TargetTrack_Predefined
=== RUN   TestAccAWSAutoscalingPolicy_TargetTrack_Custom
=== PAUSE TestAccAWSAutoscalingPolicy_TargetTrack_Custom
=== RUN   TestAccAWSAutoscalingPolicy_zerovalue
=== PAUSE TestAccAWSAutoscalingPolicy_zerovalue
=== CONT  TestAccAWSAutoscalingPolicy_basic
=== CONT  TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment
=== CONT  TestAccAWSAutoscalingPolicy_TargetTrack_Custom
=== CONT  TestAccAWSAutoscalingPolicy_predictiveScaling
=== CONT  TestAccAWSAutoscalingPolicy_predictiveScalingUpdated
=== CONT  TestAccAWSAutoscalingPolicy_predictiveScalingRemoved
=== CONT  TestAccAWSAutoscalingPolicy_zerovalue
=== CONT  TestAccAWSAutoscalingPolicy_disappears
=== CONT  TestAccAWSAutoscalingPolicy_TargetTrack_Predefined
--- PASS: TestAccAWSAutoscalingPolicy_disappears (57.14s)
--- PASS: TestAccAWSAutoscalingPolicy_zerovalue (58.61s)
--- PASS: TestAccAWSAutoscalingPolicy_predictiveScaling (61.01s)
--- PASS: TestAccAWSAutoscalingPolicy_TargetTrack_Custom (62.98s)
--- PASS: TestAccAWSAutoscalingPolicy_TargetTrack_Predefined (63.81s)
--- PASS: TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment (67.18s)
--- PASS: TestAccAWSAutoscalingPolicy_predictiveScalingUpdated (75.46s)
--- PASS: TestAccAWSAutoscalingPolicy_predictiveScalingRemoved (91.24s)
--- PASS: TestAccAWSAutoscalingPolicy_basic (103.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	103.495s

[gdavison]

There are a couple issues where we could get tripped up by Terraform's behaviour of handling a zero-value the same as unset. The range for max_capacity_buffer also looks like it's been changed to 0-100

[gdavison]

LGTM 🚀

Acceptance test results

--- PASS: TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment (40.61s)
--- PASS: TestAccAWSAutoscalingPolicy_TargetTrack_Predefined (58.62s)
--- PASS: TestAccAWSAutoscalingPolicy_zerovalue (58.68s)
--- PASS: TestAccAWSAutoscalingPolicy_predictiveScaling (62.36s)
--- PASS: TestAccAWSAutoscalingPolicy_disappears (63.85s)
--- PASS: TestAccAWSAutoscalingPolicy_TargetTrack_Custom (67.02s)
--- PASS: TestAccAWSAutoscalingPolicy_predictiveScalingRemoved (73.85s)
--- PASS: TestAccAWSAutoscalingPolicy_predictiveScalingUpdated (74.41s)
--- PASS: TestAccAWSAutoscalingPolicy_basic (92.73s)

[ghost]

This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.