r/servicecatalog_principal_portfolio_association: New resource

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic (29.80s)
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears (79.08s)

Output from acceptance testing (GovCloud):

(partition aws-us-gov does not support budgets service)

--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic (33.07s)
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears (81.99s)

References:

• Unusual IAM behavior for rapidly creating IAM role and calling API: servicecatalog.PrincipalARN contains principal's unique ID, not ARN aws/aws-sdk-go#3920 (resolved by using the retry to wait until IAM returns an ARN rather than a unique ID for the role, note: that is also why the disappears test takes a bit longer than the basic test, distinguishing between not found because IAM is returning unique IDs and not found because it doesn't exist)
• Background on getting it all working: https://stackoverflow.com/a/67713362/2121526

[ewbankkit]

Needs .changelog/19470.txt.

[ewbankkit]

Suggested change

	Default: "en",
	Default: tfservicecatalog.ServiceCatalogAcceptLanguageEnglish,

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogPrincipalPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogPrincipalPortfolioAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic
=== RUN   TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears
=== CONT  TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic
=== CONT  TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic (27.91s)
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears (77.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	81.019s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogPrincipalPortfolioAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogPrincipalPortfolioAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic
=== PAUSE TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic
=== RUN   TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears
=== CONT  TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic
=== CONT  TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic (33.77s)
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears (83.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.584s

[YakDriver]

Thanks for the feedback! I also updated the other places that should have been using the enum. Also, the enum was unnecessarily verbose. All fixed.

Commercial:

--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic (29.70s)
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears (78.25s)

GovCloud:

--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_basic (33.70s)
--- PASS: TestAccAWSServiceCatalogPrincipalPortfolioAssociation_disappears (82.37s)

[ghost]

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.