Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/transfer_user - add support for posix_profile #19693

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17022
Depends On #19691

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSTransferUser_'
--- PASS: TestAccAWSTransferUser_UserName_Validation (31.73s)
--- PASS: TestAccAWSTransferUser_homeDirectoryMappings (214.30s)
--- PASS: TestAccAWSTransferUser_basic (218.56s)
--- PASS: TestAccAWSTransferUser_disappears (224.98s)
--- PASS: TestAccAWSTransferUser_posix (247.17s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (536.80s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 7, 2021 11:46
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. labels Jun 7, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 7, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransferUser_'                                                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransferUser_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.55
=== RUN   TestAccAWSTransferUser_basic
=== PAUSE TestAccAWSTransferUser_basic
=== RUN   TestAccAWSTransferUser_posix
=== PAUSE TestAccAWSTransferUser_posix
=== RUN   TestAccAWSTransferUser_modifyWithOptions
=== PAUSE TestAccAWSTransferUser_modifyWithOptions
=== RUN   TestAccAWSTransferUser_disappears
=== PAUSE TestAccAWSTransferUser_disappears
=== RUN   TestAccAWSTransferUser_UserName_Validation
=== PAUSE TestAccAWSTransferUser_UserName_Validation
=== RUN   TestAccAWSTransferUser_homeDirectoryMappings
=== PAUSE TestAccAWSTransferUser_homeDirectoryMappings
=== CONT  TestAccAWSTransferUser_basic
=== CONT  TestAccAWSTransferUser_UserName_Validation
=== CONT  TestAccAWSTransferUser_modifyWithOptions
=== CONT  TestAccAWSTransferUser_homeDirectoryMappings
=== CONT  TestAccAWSTransferUser_disappears
=== CONT  TestAccAWSTransferUser_posix
--- PASS: TestAccAWSTransferUser_UserName_Validation (25.68s)
--- PASS: TestAccAWSTransferUser_basic (200.20s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (202.68s)
--- PASS: TestAccAWSTransferUser_homeDirectoryMappings (211.63s)
--- PASS: TestAccAWSTransferUser_posix (250.50s)
--- PASS: TestAccAWSTransferUser_disappears (263.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	266.834s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSTransferUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSTransferUser_ -timeout 180m
=== RUN   TestAccAWSTransferUser_basic
=== PAUSE TestAccAWSTransferUser_basic
=== RUN   TestAccAWSTransferUser_posix
=== PAUSE TestAccAWSTransferUser_posix
=== RUN   TestAccAWSTransferUser_modifyWithOptions
=== PAUSE TestAccAWSTransferUser_modifyWithOptions
=== RUN   TestAccAWSTransferUser_disappears
=== PAUSE TestAccAWSTransferUser_disappears
=== RUN   TestAccAWSTransferUser_UserName_Validation
=== PAUSE TestAccAWSTransferUser_UserName_Validation
=== RUN   TestAccAWSTransferUser_homeDirectoryMappings
=== PAUSE TestAccAWSTransferUser_homeDirectoryMappings
=== CONT  TestAccAWSTransferUser_basic
=== CONT  TestAccAWSTransferUser_UserName_Validation
=== CONT  TestAccAWSTransferUser_modifyWithOptions
=== CONT  TestAccAWSTransferUser_disappears
=== CONT  TestAccAWSTransferUser_posix
=== CONT  TestAccAWSTransferUser_homeDirectoryMappings
=== CONT  TestAccAWSTransferUser_basic
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/08 10:02:31 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
        
=== CONT  TestAccAWSTransferUser_disappears
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/08 10:02:31 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
        
=== CONT  TestAccAWSTransferUser_modifyWithOptions
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/08 10:02:31 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
        
=== CONT  TestAccAWSTransferUser_homeDirectoryMappings
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/08 10:02:31 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
        
=== CONT  TestAccAWSTransferUser_posix
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/08 10:02:31 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Transfer Server: InvalidRequestException: Invalid server type: PUBLIC
        
          on terraform_plugin_test.tf line 2, in resource "aws_transfer_server" "test":
           2: resource "aws_transfer_server" "test" {
        
        
--- SKIP: TestAccAWSTransferUser_basic (13.51s)
--- SKIP: TestAccAWSTransferUser_disappears (13.77s)
--- SKIP: TestAccAWSTransferUser_modifyWithOptions (14.34s)
--- SKIP: TestAccAWSTransferUser_homeDirectoryMappings (14.35s)
--- SKIP: TestAccAWSTransferUser_posix (14.39s)
--- PASS: TestAccAWSTransferUser_UserName_Validation (19.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.765s

@ewbankkit ewbankkit merged commit debac80 into hashicorp:main Jun 8, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 8, 2021
@DrFaust92 DrFaust92 deleted the r/transfer_server_user_efs branch June 8, 2021 15:57
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Transfer Family support for Amazon Elastic File System
2 participants