Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudwatch_event_target - fix input transformer input paths validation #19703

Merged

Conversation

kromol
Copy link

@kromol kromol commented Jun 7, 2021

Set max items to be 100 to match current AWS Documentation

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19698

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_input_transformer'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventTarget_input_transformer -timeout 180m
=== RUN   TestAccAWSCloudWatchEventTarget_input_transformer
=== PAUSE TestAccAWSCloudWatchEventTarget_input_transformer
=== CONT  TestAccAWSCloudWatchEventTarget_input_transformer
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (76.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       78.102s

...

@kromol kromol requested a review from a team as a code owner June 7, 2021 20:37
@ghost ghost added size/S Managed by automation to categorize the size of a PR. labels Jun 7, 2021
@github-actions github-actions bot added service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 7, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. service/eventbridge labels Jun 7, 2021
@anGie44 anGie44 self-assigned this Jun 7, 2021
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-input-paths-max-items branch from be173ee to 55502d3 Compare June 8, 2021 01:08
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @kromol ! only note for next time is to make sure to add a .changelog/<PR-Number>.txt file to describe the changes and check if the documentation needs to be updated (I missed this on first review 😅). Thank you for this fix! 🚀 🚀

Output of acceptance tests (in commercial):

--- SKIP: TestAccAWSCloudWatchEventTarget_PartnerEventBus (0.00s)
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (37.84s)
--- PASS: TestAccAWSCloudWatchEventTarget_GeneratedTargetId (40.63s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (41.10s)
--- PASS: TestAccAWSCloudWatchEventTarget_http (41.89s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (43.65s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (51.78s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (53.03s)
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusName (58.20s)
--- PASS: TestAccAWSCloudWatchEventTarget_inputTransformerJsonString (58.33s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (64.26s)
--- PASS: TestAccAWSCloudWatchEventTarget_basic (69.18s)
--- PASS: TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig (74.79s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (76.74s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (77.31s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (95.13s)

@anGie44 anGie44 added this to the v3.45.0 milestone Jun 8, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eventbridge labels Jun 8, 2021
@anGie44 anGie44 merged commit 575fc2f into hashicorp:main Jun 8, 2021
@kromol kromol deleted the b-cloudwatch-event-target-input-paths-max-items branch June 8, 2021 06:35
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong validation foraws_cloudwatch_event_target input_transformer.input_paths maximum size
2 participants