Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cognito_user_pool: Suppress diff for empty account_recovery_setting #19704

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17228

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPool_'
--- PASS: TestAccAWSCognitoUserPool_disappears (36.21s)
--- PASS: TestAccAWSCognitoUserPool_withEmailConfiguration (48.64s)
--- PASS: TestAccAWSCognitoUserPool_basic (49.39s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesModified (55.65s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesRemoved (69.13s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (84.86s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (85.12s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (89.72s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributes (90.26s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (90.54s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (92.42s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameAttributes (93.19s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (117.97s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (80.43s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (132.00s)
--- PASS: TestAccAWSCognitoUserPool_withTags (132.07s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (44.21s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (70.04s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig (142.36s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (148.96s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (114.95s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig (156.79s)
--- PASS: TestAccAWSCognitoUserPool_update (162.28s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (77.89s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (167.04s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (77.55s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (97.68s)
--- PASS: TestAccAWSCognitoUserPool_recovery (106.39s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (148.63s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (107.22s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (110.59s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (157.08s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 7, 2021 21:00
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels Jun 7, 2021
@DrFaust92 DrFaust92 changed the title extract email config + supress diff r/cognito_user_pool: Suppress diff for empty account_recovery_setting Jun 7, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Jun 7, 2021
@anGie44 anGie44 self-assigned this Jun 7, 2021
@anGie44 anGie44 added this to the v3.45.0 milestone Jun 10, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output of acceptance tests (commerical):

--- SKIP: TestAccAWSCognitoUserPoolDomain_custom (0.00s)
--- PASS: TestAccAWSCognitoUserPoolClient_disappears_userPool (58.06s)
--- PASS: TestAccAWSCognitoUserPoolClient_disappears (69.28s)
--- PASS: TestAccAWSCognitoUserPoolDomain_disappears (74.17s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (79.77s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (80.94s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (81.53s)
--- PASS: TestAccAWSCognitoUserPool_basic (82.30s)
--- PASS: TestAccAWSCognitoUserPoolDomain_basic (82.57s)
--- PASS: TestAccAWSCognitoUserPoolClient_analyticsConfigWithArn (84.81s)
--- PASS: TestAccAWSCognitoUserPoolClient_idTokenValidity (129.86s)
--- PASS: TestAccAWSCognitoUserPoolClient_tokenValidityUnits (129.90s)
--- PASS: TestAccAWSCognitoUserPoolClient_accessTokenValidity (130.36s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (131.20s)
--- PASS: TestAccAWSCognitoUserPoolClient_tokenValidityUnitsWTokenValidity (132.01s)
--- PASS: TestAccAWSCognitoUserPoolClient_refreshTokenValidity (132.55s)
--- SKIP: TestAccAWSCognitoUserPool_withEmailConfigurationSource (0.00s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (133.67s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (133.64s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (185.22s)
--- PASS: TestAccAWSCognitoUserPool_recovery (187.05s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (130.85s)
--- PASS: TestAccAWSCognitoUserPoolClient_analyticsConfig (198.88s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (132.55s)
--- PASS: TestAccAWSCognitoUserPool_withEmailConfiguration (78.16s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (127.57s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (147.33s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (152.31s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (122.65s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (121.74s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (126.59s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameAttributes (127.07s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (182.40s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (199.47s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (208.43s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesRemoved (83.48s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (165.08s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributesModified (84.61s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (166.72s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (226.13s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (126.02s)
--- PASS: TestAccAWSCognitoUserPool_disappears (58.98s)
--- PASS: TestAccAWSCognitoUserPool_withTags (181.33s)
--- PASS: TestAccAWSCognitoUserPool_schemaAttributes (121.66s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_AllClients_Disappears (64.34s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (147.61s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (114.09s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_emailConfig (154.67s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig_smsConfig (150.19s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_Client_Disappears (56.38s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_AllClients_CSS (108.32s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_AllClients_ImageFile (106.19s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_Client_CSS (93.59s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_UpdateClientToAll_CSS (79.83s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_UpdateAllToClient_CSS (80.18s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_Client_Image (83.68s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_ClientAndAll_CSS (85.40s)
--- PASS: TestAccAWSCognitoUserPool_update (146.93s)
--- PASS: TestAccAWSCognitoUserPoolUICustomization_AllClients_CSSAndImageFile (117.78s)

@anGie44 anGie44 merged commit 1ac5e4d into hashicorp:main Jun 10, 2021
@DrFaust92 DrFaust92 deleted the r/cognito_user_pool_supress_diff branch June 11, 2021 06:52
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cognito_user_pool asking for update to remove account_recovery_setting without changes
2 participants