Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/servicecatalog_portfolio_constraints: New data source #19813

Merged
merged 12 commits into from Jun 30, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jun 15, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run='TestAccAWSServiceCatalogConstraint_|TestAccAWSServiceCatalogConstraintDataSource_|TestAccAWSServiceCatalogPortfolioConstraintDataSource_' -timeout 180m
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (35.16s)
--- PASS: TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic (36.07s)
--- PASS: TestAccAWSServiceCatalogConstraintDataSource_basic (36.55s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (36.88s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (55.08s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogConstraint_disappears (38.68s)
--- PASS: TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic (39.36s)
--- PASS: TestAccAWSServiceCatalogConstraintDataSource_basic (40.16s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (41.91s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (63.57s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jun 15, 2021
@YakDriver YakDriver force-pushed the f-servicecat-ds-port-constraint branch from a5a6e55 to 4c1b008 Compare June 29, 2021 16:15
@YakDriver YakDriver changed the title [WIP] d/servicecatalog_portfolio_constraints: New data source d/servicecatalog_portfolio_constraints: New data source Jun 29, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 29, 2021
@YakDriver YakDriver added this to the v3.48.0 milestone Jun 29, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogPortfolioConstraintDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogPortfolioConstraintDataSource_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic
=== PAUSE TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic
=== CONT  TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic
--- PASS: TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic (35.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.010s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogPortfolioConstraintDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogPortfolioConstraintDataSource_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic
=== PAUSE TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic
=== CONT  TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic
--- PASS: TestAccAWSServiceCatalogPortfolioConstraintDataSource_basic (38.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.279s

@YakDriver YakDriver force-pushed the f-servicecat-ds-port-constraint branch from 9a3b17c to 058b8ca Compare June 30, 2021 20:59
@YakDriver YakDriver merged commit d8b8725 into main Jun 30, 2021
@YakDriver YakDriver deleted the f-servicecat-ds-port-constraint branch June 30, 2021 21:19
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants