d/aws_iam_session_context: New data source #19957

YakDriver · 2021-06-24T20:59:57Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19958

Special thanks to @dpowley for helping storyboard a solution!

Output from acceptance/unit testing (us-west-2):

--- PASS: TestAssumedRoleRoleSessionName (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/regular_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/'assumed-role'_part_of_ARN_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/user_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_from_AWS_example (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/multiple_slashes_in_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_sts_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/role_with_path (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/wrong_service (0.00s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (13.05s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (16.37s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (16.47s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (16.48s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (17.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	13.257s

Output from acceptance/unit testing (GovCloud):

--- PASS: TestAssumedRoleRoleSessionName (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/regular_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/'assumed-role'_part_of_ARN_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/user_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_from_AWS_example (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/multiple_slashes_in_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_sts_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/role_with_path (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/wrong_service (0.00s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (13.05s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (19.06s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (19.07s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (20.06s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (20.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.041s

dpowley · 2021-06-24T23:14:34Z

aws/data_source_aws_caller_identity.go

+		}
+
+		re := regexp.MustCompile(`^assumed-role/`)
+		parsedARN.Resource = re.ReplaceAllString(parsedARN.Resource, "role/")


This will return the incorrect sourceArn for roles with paths. The sts assumed-role ARN doesn't include the path of the role. For instance, if you have IAM role ARN arn:aws:iam::{accountId}:role/{path}/{roleName} and you assume that role , the assumed-role ARN will be arn:aws:sts::{accountId}:assumed-role/{roleName}/{sessionName}. To derive the sourceARN, you would need to call getRole after parsing the role name from the sts ARN. The problem is then, the caller identity data source will then require the iam:GetRole permission, which could theoretically break workflows.

😞 absolutely right

DrFaust92

Some minor comments, otherwise LGTM

dpowley · 2021-06-28T16:55:18Z

aws/internal/service/iam/finder/finder.go

@@ -109,3 +111,22 @@ func Policies(conn *iam.IAM, arn, name, pathPrefix string) ([]*iam.Policy, error

 	return results, err
 }
+
+// RoleByName returns a role's ARN given the role name
+func RoleByName(conn *iam.IAM, name string) (*iam.Role, error) {


Can this just be named Role? This is just a wrapper on getRole, and the above RO functions are named simply by resource.

Yes, love it

dpowley · 2021-06-28T16:58:02Z

aws/data_source_aws_iam_assumed_role_source.go

+
+// roleNameSessionFromARN returns the role and session names in an ARN if any.
+// Otherwise, it returns empty strings.
+func roleNameSessionFromARN(rawARN string) (string, string) {


This function would ideally return an error if there is no session name to grab (i.e. its not a valid sts assumed-role arn), right?

Yes, the problem is that good Go says we should return an error if we don't plan on dealing with it, which we don't.

dpowley · 2021-06-28T17:02:52Z

aws/data_source_aws_iam_assumed_role_source.go

+		d.Set("source_arn", arn)
+		d.Set("session_name", "")
+		d.Set("role_name", "")
+		d.Set("role_path", "")


I don't think returning role_path is necessary. Seems like an arbitrary field to choose to return from GetRole output. Maybe we could leave it off and if folks want more role context for this datasource we can always add it later?

dpowley · 2021-06-28T17:03:24Z

aws/data_source_aws_iam_assumed_role_source.go

+	if roleName, sessionName = roleNameSessionFromARN(arn); roleName == "" {
+		d.Set("source_arn", arn)
+		d.Set("session_name", "")
+		d.Set("role_name", "")


The field name structure for source_arn and role_name seems inconsistent. Could we name them both with source? Or we could even return arn, role_arn, role_name and session_name

the challenge here is if you're using an IAM user, you should still be able to get out a passed through user ARN from source_arn.

Yeah I see what you are saying. Don't love it, but can't think of a better way to do it.

issuer_arn?

dpowley · 2021-06-28T17:19:29Z

aws/data_source_aws_iam_assumed_role_source.go

+		return "", ""
+	}
+
+	if reRole.MatchString(parsedARN.Resource) && parsedARN.Service != "iam" {


My take on this is we should spit IAM role ARNs out just like we would any non-sts assumed-role ARN. If they want metadata on a role, they should use the aws_iam_role data source.

Since we have the role name, I figure I'd also verify IAM role - no cost.

Its not costly, but I think it muddies the water a little on what this data source does. Its easiest to say if you pass in an assumed-role arn we'll give you back all of the metadata and if not you only get sourceArn. Once you add in a case for IAM role, I think the use case isn't quite as clear.

Yeah, I can see that.

Water un muddied

ewbankkit · 2021-06-28T18:20:23Z

.changelog/19957.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+aws_iam_assumed_role_source


Suggested change

aws_iam_assumed_role_source

aws_iam_session_context

ewbankkit · 2021-06-28T18:21:09Z

aws/data_source_aws_iam_session_context.go

+				Type:     schema.TypeString,
+				Computed: true,
+			},
+			"source_arn": {


Swap with session_name for alphabetic ordering?

it's now called issuer_name and should be in the correct order

YakDriver · 2021-06-28T19:13:42Z

Tests after many refactors:

GovCloud:

--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (13.07s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (17.41s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (17.42s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (19.85s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (19.85s)
--- PASS: TestAssumedRoleRoleSessionName (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/regular_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/'assumed-role'_part_of_ARN_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/user_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_from_AWS_example (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/multiple_slashes_in_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_sts_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/role_with_path (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/wrong_service (0.00s)

us-west-2:

--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (8.84s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (11.30s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (11.30s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (11.50s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (11.65s)
--- PASS: TestAssumedRoleRoleSessionName (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/regular_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/'assumed-role'_part_of_ARN_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/user_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/assumed_role_from_AWS_example (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/multiple_slashes_in_resource (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/not_an_sts_ARN (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/role_with_path (0.00s)
    --- PASS: TestAssumedRoleRoleSessionName/wrong_service (0.00s)

website/docs/d/iam_session_context.markdown

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMSessionContext_'        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMSessionContext_ -timeout 180m
=== RUN   TestAccAWSDataSourceIAMSessionContext_basic
=== PAUSE TestAccAWSDataSourceIAMSessionContext_basic
=== RUN   TestAccAWSDataSourceIAMSessionContext_withPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_withPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== CONT  TestAccAWSDataSourceIAMSessionContext_basic
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== CONT  TestAccAWSDataSourceIAMSessionContext_withPath
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (14.35s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (16.05s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (17.17s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (17.21s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (17.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.124s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMSessionContext_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMSessionContext_ -timeout 180m
=== RUN   TestAccAWSDataSourceIAMSessionContext_basic
=== PAUSE TestAccAWSDataSourceIAMSessionContext_basic
=== RUN   TestAccAWSDataSourceIAMSessionContext_withPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_withPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== RUN   TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== PAUSE TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== CONT  TestAccAWSDataSourceIAMSessionContext_basic
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser
=== CONT  TestAccAWSDataSourceIAMSessionContext_notAssumedRole
=== CONT  TestAccAWSDataSourceIAMSessionContext_withPath
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleUser (18.53s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRole (23.04s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_notAssumedRoleWithPath (23.36s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_basic (23.51s)
--- PASS: TestAccAWSDataSourceIAMSessionContext_withPath (23.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	28.284s

ewbankkit · 2021-06-28T19:25:38Z

Verified that one of our nightly CI tests that fails with an assumed role passes using

data "aws_caller_identity" "current" {}

data "aws_iam_session_context" "current" {
  arn = data.aws_caller_identity.current.arn
}

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointServiceAllowedPrincipal_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointServiceAllowedPrincipal_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== PAUSE TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== CONT  TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
    resource_aws_vpc_endpoint_service_allowed_principal_test.go:19: Step 1/1 error: Error running apply: exit status 1
        2021/06/28 14:59:22 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: Error creating VPC Endpoint Service allowed principal: InvalidPrincipal: Invalid Principal: 'arn:aws:sts::123456789012:assumed-role/terraform_team1_dev-developer/abc@example.com'
        	status code: 400, request id: e1a5d963-8952-41dd-a2dd-aa120a0ee9d2
        
          on terraform_plugin_test.tf line 63, in resource "aws_vpc_endpoint_service_allowed_principal" "test":
          63: resource "aws_vpc_endpoint_service_allowed_principal" "test" {
        
        
--- FAIL: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (258.09s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	261.617s
FAIL
make: *** [testacc] Error 1

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointServiceAllowedPrincipal_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointServiceAllowedPrincipal_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== PAUSE TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== CONT  TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (227.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	230.947s

github-actions · 2021-07-08T15:53:43Z

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-08-08T02:05:55Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

YakDriver added 4 commits June 24, 2021 15:11

caller_identity: Add source role

d86a246

d/caller_identity: Add source_arn

b81de6a

tests/d/caller_identity: Unit test source_arn

11d04ce

docs/d/caller_identity: Docs for source_arn

c659b64

YakDriver added 2 commits June 24, 2021 17:01

d/caller_identity: Add changelog

62d7c93

docs/d/caller_identity: Add example

984d0cd

YakDriver added the service/iam Issues and PRs that pertain to the iam service. label Jun 24, 2021

tests/d/caller_identity: Appease dear linter

4ecde63

github-actions bot removed the service/iam Issues and PRs that pertain to the iam service. label Jun 24, 2021

dpowley reviewed Jun 24, 2021

View reviewed changes

YakDriver added 8 commits June 25, 2021 17:05

ds/caller_identity: Revert to previous

f887951

ds/iam_assumed_role_source: Update changelog

ad1f9a3

i/iam_role: Add role finder

ae63556

provider: Add new data source

1125604

d/iam_assumed_role_source: New data source

3353636

tests/d/iam_assumed_role_source: New data source

1cdcdf2

docs/d/iam_assumed_role_source: New data source

8394cf0

tests/d/iam_assumed_role_source: Remove comments

914cd83

YakDriver changed the title ~~d/caller_identity: Add source_arn for assumed roles~~ d/aws_iam_assumed_role_source: New data source Jun 25, 2021

YakDriver requested a review from dpowley June 25, 2021 21:14

YakDriver added 2 commits June 25, 2021 17:21

docs/d/caller_identity: Remove old attribute

39f176a

docs/d/iam_assumed_role_source: Clarify docs

a4704cc

DrFaust92 approved these changes Jun 28, 2021

View reviewed changes

dpowley reviewed Jun 28, 2021

View reviewed changes

d/iam_session_context: Refactor

aa4183c

YakDriver changed the title ~~d/aws_iam_assumed_role_source: New data source~~ d/aws_iam_session_context: New data source Jun 28, 2021

ewbankkit reviewed Jun 28, 2021

View reviewed changes

YakDriver added 5 commits June 28, 2021 14:26

d/iam_session_context: Refactor attribute

3f2f55b

d/iam_session_context: Update changelog

4947200

d/iam_session_context: Refactor arguments, attributes

8c76c24

docs/d/iam_session_context: Fix docs

1232685

d/iam_session_context: Rework helper

db6575b

ewbankkit removed the service/sts Issues and PRs that pertain to the sts service. label Jun 28, 2021

YakDriver requested review from dpowley and ewbankkit June 28, 2021 19:14

ewbankkit reviewed Jun 28, 2021

View reviewed changes

website/docs/d/iam_session_context.markdown Outdated Show resolved Hide resolved

Update website/docs/d/iam_session_context.markdown

a824e7c

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>

github-actions bot added the service/sts Issues and PRs that pertain to the sts service. label Jun 28, 2021

Fix docs

4252de0

ewbankkit approved these changes Jun 28, 2021

View reviewed changes

YakDriver added this to the v3.48.0 milestone Jun 28, 2021

YakDriver merged commit 6c348dd into main Jun 28, 2021

YakDriver deleted the f-caller-id-base-role branch June 28, 2021 20:24

github-actions bot pushed a commit that referenced this pull request Jun 28, 2021

Update CHANGELOG.md for #19957

3a38e51

This was referenced Jun 29, 2021

r/servicecatalog_provisioned_product: New resource #19459

Merged

servicecatalog: Test for launch paths data source fails if using assumed role #19998

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

d/aws_iam_session_context: New data source #19957

d/aws_iam_session_context: New data source #19957

YakDriver commented Jun 24, 2021 •

edited

dpowley Jun 24, 2021

YakDriver Jun 25, 2021

DrFaust92 left a comment

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

dpowley Jun 28, 2021

YakDriver Jun 28, 2021

YakDriver Jun 28, 2021

ewbankkit Jun 28, 2021

ewbankkit Jun 28, 2021

YakDriver Jun 28, 2021

YakDriver commented Jun 28, 2021

ewbankkit left a comment

ewbankkit commented Jun 28, 2021

github-actions bot commented Jul 8, 2021

github-actions bot commented Aug 8, 2021

		@@ -0,0 +1,3 @@
		```release-note:new-data-source
		aws_iam_assumed_role_source

d/aws_iam_session_context: New data source #19957

d/aws_iam_session_context: New data source #19957

Conversation

YakDriver commented Jun 24, 2021 • edited

Community Note

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DrFaust92 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YakDriver commented Jun 28, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Jun 28, 2021

github-actions bot commented Jul 8, 2021

github-actions bot commented Aug 8, 2021

YakDriver commented Jun 24, 2021 •

edited