Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #20216 #20265

Merged
merged 2 commits into from Jul 21, 2021
Merged

Fix for issue #20216 #20265

merged 2 commits into from Jul 21, 2021

Conversation

obourdon
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20216

Output from acceptance testing:

$ AWS_PROFILE=scratch AWS_DEFAULT_REGION=us-west-2 TF_ACC=1 ACCTEST_PARALLELISM=1 gmake testacc TEST=./aws TESTARGS='-run=TestAccAWSRouteTable_'

...

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jul 21, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 21, 2021
@ewbankkit ewbankkit self-assigned this Jul 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSRouteTableAssociation_'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTableAssociation_ -timeout 180m
=== RUN   TestAccAWSRouteTableAssociation_Subnet_basic
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_basic
=== RUN   TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_Gateway_basic
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_basic
=== RUN   TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_disappears
=== PAUSE TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Subnet_basic
=== CONT  TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== CONT  TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Gateway_basic
=== CONT  TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
--- PASS: TestAccAWSRouteTableAssociation_disappears (43.24s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (46.00s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (66.01s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (75.27s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (97.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	100.327s

@ewbankkit
Copy link
Contributor

@obourdon Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8862a60 into hashicorp:main Jul 21, 2021
@obourdon
Copy link
Contributor Author

@ewbankkit many thanks for such a prompt integration. Cheers

@obourdon obourdon deleted the fix-20216 branch July 21, 2021 19:02
@github-actions github-actions bot added this to the v3.51.0 milestone Jul 21, 2021
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform unable to delete the AWS routing table association
2 participants