Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appconfig_deployment: add to deployment_strategy_id validation #20420

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 3, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20418

Output from acceptance testing:

--- PASS: TestAccAWSAppConfigDeployment_PredefinedStrategy (151.45s)
--- PASS: TestAccAWSAppConfigDeployment_basic (212.57s)
--- PASS: TestAccAWSAppConfigDeployment_Tags (241.59s)

@anGie44 anGie44 changed the title r/appconfig_deploymeny: add to deployment_strategy_id validation r/appconfig_deployment: add to deployment_strategy_id validation Aug 3, 2021
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appconfig Issues and PRs that pertain to the appconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 3, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSAppConfigDeployment_'                                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigDeployment_ -timeout 180m
=== RUN   TestAccAWSAppConfigDeployment_basic
=== PAUSE TestAccAWSAppConfigDeployment_basic
=== RUN   TestAccAWSAppConfigDeployment_PredefinedStrategy
=== PAUSE TestAccAWSAppConfigDeployment_PredefinedStrategy
=== RUN   TestAccAWSAppConfigDeployment_Tags
=== PAUSE TestAccAWSAppConfigDeployment_Tags
=== CONT  TestAccAWSAppConfigDeployment_basic
=== CONT  TestAccAWSAppConfigDeployment_Tags
=== CONT  TestAccAWSAppConfigDeployment_PredefinedStrategy
--- PASS: TestAccAWSAppConfigDeployment_PredefinedStrategy (151.42s)
--- PASS: TestAccAWSAppConfigDeployment_basic (213.79s)
--- PASS: TestAccAWSAppConfigDeployment_Tags (253.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	257.464s

@anGie44 anGie44 added this to the v3.53.0 milestone Aug 4, 2021
@anGie44 anGie44 merged commit cff6ae4 into main Aug 4, 2021
@anGie44 anGie44 deleted the f-appconfig-deployment-validation branch August 4, 2021 13:07
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/appconfig Issues and PRs that pertain to the appconfig service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/appconfig_deployment: add predefined strategies to validation of deployment_strategy_id
2 participants