Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/imagebuilder_image_configuration: set terminate_instance_on_failure directly in API requests #20464

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Notes

  • boolean field with a Default failed the d.GetOk() checks that controlled whether or not the value was set in the input structs

Output from acceptance testing before change:

Attribute 'terminate_instance_on_failure' expected "false", got "true"

Output from acceptance testing after change:

--- PASS: TestAccAwsImageBuilderComponentDataSource_Arn (84.36s)
--- PASS: TestAccAwsImageBuilderComponent_ChangeDescription (90.75s)
--- PASS: TestAccAwsImageBuilderComponent_Description (89.33s)
--- PASS: TestAccAwsImageBuilderComponent_KmsKeyId (86.22s)
--- PASS: TestAccAwsImageBuilderComponent_Platform_Windows (92.57s)
--- PASS: TestAccAwsImageBuilderComponent_SupportedOsVersions (92.02s)
--- PASS: TestAccAwsImageBuilderComponent_Tags (202.35s)
--- PASS: TestAccAwsImageBuilderComponent_Uri (92.44s)
--- PASS: TestAccAwsImageBuilderComponent_basic (90.64s)
--- PASS: TestAccAwsImageBuilderComponent_disappears (69.02s)
--- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (85.94s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (153.10s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (118.57s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (151.14s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (149.23s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (150.05s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (82.05s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (151.22s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (146.87s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (144.81s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (146.22s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (206.98s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (90.93s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (76.90s)
--- PASS: TestAccAwsImageBuilderImageDataSource_Arn_Aws (67.69s)
--- PASS: TestAccAwsImageBuilderImageDataSource_Arn_Self (1447.45s)
--- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (102.41s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Description (169.59s)
--- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (170.21s)
--- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (169.64s)
--- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (166.83s)
--- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (167.80s)
--- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (161.94s)
--- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (167.50s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (165.91s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (167.27s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Status (169.12s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Tags (193.85s)
--- PASS: TestAccAwsImageBuilderImagePipeline_basic (106.84s)
--- PASS: TestAccAwsImageBuilderImagePipeline_disappears (97.22s)
--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (90.77s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (83.78s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (88.55s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (86.67s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (89.56s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (86.56s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (110.10s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (84.66s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2 (85.55s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3 (90.22s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (87.73s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (81.50s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (80.28s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (79.38s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (129.47s)
--- PASS: TestAccAwsImageBuilderImageRecipe_WorkingDirectory (70.14s)
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (88.95s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (77.53s)
--- PASS: TestAccAwsImageBuilderImage_DistributionConfigurationArn (1450.02s)
--- PASS: TestAccAwsImageBuilderImage_EnhancedImageMetadataEnabled (1187.26s)
--- PASS: TestAccAwsImageBuilderImage_ImageTestsConfiguration_ImageTestsEnabled (952.78s)
--- PASS: TestAccAwsImageBuilderImage_ImageTestsConfiguration_TimeoutMinutes (1319.56s)
--- PASS: TestAccAwsImageBuilderImage_Tags (1463.45s)
--- PASS: TestAccAwsImageBuilderImage_basic (1447.66s)
--- PASS: TestAccAwsImageBuilderImage_disappears (1198.82s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (98.69s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (100.89s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (113.16s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (101.74s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (106.33s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (97.24s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (95.94s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (96.24s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (93.10s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (89.20s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (81.97s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (97.29s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (66.09s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (59.21s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (55.72s)

@github-actions github-actions bot added service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XS Managed by automation to categorize the size of a PR. labels Aug 6, 2021
@anGie44 anGie44 marked this pull request as ready for review August 6, 2021 17:32
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Aug 6, 2021
@ewbankkit ewbankkit self-assigned this Aug 6, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAwsImageBuilder'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsImageBuilder -timeout 180m
=== RUN   TestAccAwsImageBuilderComponentDataSource_Arn
=== PAUSE TestAccAwsImageBuilderComponentDataSource_Arn
=== RUN   TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn
=== PAUSE TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn
=== RUN   TestAccAwsImageBuilderImagePipelineDataSource_Arn
=== PAUSE TestAccAwsImageBuilderImagePipelineDataSource_Arn
=== RUN   TestAccAwsImageBuilderImageRecipeDataSource_Arn
=== PAUSE TestAccAwsImageBuilderImageRecipeDataSource_Arn
=== RUN   TestAccAwsImageBuilderImageDataSource_Arn_Aws
=== PAUSE TestAccAwsImageBuilderImageDataSource_Arn_Aws
=== RUN   TestAccAwsImageBuilderImageDataSource_Arn_Self
=== PAUSE TestAccAwsImageBuilderImageDataSource_Arn_Self
=== RUN   TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn
=== PAUSE TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn
=== RUN   TestAccAwsImageBuilderComponent_basic
=== PAUSE TestAccAwsImageBuilderComponent_basic
=== RUN   TestAccAwsImageBuilderComponent_disappears
=== PAUSE TestAccAwsImageBuilderComponent_disappears
=== RUN   TestAccAwsImageBuilderComponent_ChangeDescription
=== PAUSE TestAccAwsImageBuilderComponent_ChangeDescription
=== RUN   TestAccAwsImageBuilderComponent_Description
=== PAUSE TestAccAwsImageBuilderComponent_Description
=== RUN   TestAccAwsImageBuilderComponent_KmsKeyId
=== PAUSE TestAccAwsImageBuilderComponent_KmsKeyId
=== RUN   TestAccAwsImageBuilderComponent_Platform_Windows
=== PAUSE TestAccAwsImageBuilderComponent_Platform_Windows
=== RUN   TestAccAwsImageBuilderComponent_SupportedOsVersions
=== PAUSE TestAccAwsImageBuilderComponent_SupportedOsVersions
=== RUN   TestAccAwsImageBuilderComponent_Tags
=== PAUSE TestAccAwsImageBuilderComponent_Tags
=== RUN   TestAccAwsImageBuilderComponent_Uri
=== PAUSE TestAccAwsImageBuilderComponent_Uri
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_basic
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_disappears
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_disappears
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Description
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Description
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Tags
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Tags
=== RUN   TestAccAwsImageBuilderImagePipeline_basic
=== PAUSE TestAccAwsImageBuilderImagePipeline_basic
=== RUN   TestAccAwsImageBuilderImagePipeline_disappears
=== PAUSE TestAccAwsImageBuilderImagePipeline_disappears
=== RUN   TestAccAwsImageBuilderImagePipeline_Description
=== PAUSE TestAccAwsImageBuilderImagePipeline_Description
=== RUN   TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn
=== PAUSE TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn
=== RUN   TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled
=== PAUSE TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled
=== RUN   TestAccAwsImageBuilderImagePipeline_ImageRecipeArn
=== PAUSE TestAccAwsImageBuilderImagePipeline_ImageRecipeArn
=== RUN   TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled
=== PAUSE TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled
=== RUN   TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes
=== PAUSE TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes
=== RUN   TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn
=== PAUSE TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn
=== RUN   TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition
=== PAUSE TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition
=== RUN   TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression
=== PAUSE TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression
=== RUN   TestAccAwsImageBuilderImagePipeline_Status
=== PAUSE TestAccAwsImageBuilderImagePipeline_Status
=== RUN   TestAccAwsImageBuilderImagePipeline_Tags
=== PAUSE TestAccAwsImageBuilderImagePipeline_Tags
=== RUN   TestAccAwsImageBuilderImageRecipe_basic
=== PAUSE TestAccAwsImageBuilderImageRecipe_basic
=== RUN   TestAccAwsImageBuilderImageRecipe_disappears
=== PAUSE TestAccAwsImageBuilderImageRecipe_disappears
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice
=== RUN   TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName
=== PAUSE TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName
=== RUN   TestAccAwsImageBuilderImageRecipe_Component
=== PAUSE TestAccAwsImageBuilderImageRecipe_Component
=== RUN   TestAccAwsImageBuilderImageRecipe_Description
=== PAUSE TestAccAwsImageBuilderImageRecipe_Description
=== RUN   TestAccAwsImageBuilderImageRecipe_Tags
=== PAUSE TestAccAwsImageBuilderImageRecipe_Tags
=== RUN   TestAccAwsImageBuilderImageRecipe_WorkingDirectory
=== PAUSE TestAccAwsImageBuilderImageRecipe_WorkingDirectory
=== RUN   TestAccAwsImageBuilderImage_basic
=== PAUSE TestAccAwsImageBuilderImage_basic
=== RUN   TestAccAwsImageBuilderImage_disappears
=== PAUSE TestAccAwsImageBuilderImage_disappears
=== RUN   TestAccAwsImageBuilderImage_DistributionConfigurationArn
=== PAUSE TestAccAwsImageBuilderImage_DistributionConfigurationArn
=== RUN   TestAccAwsImageBuilderImage_EnhancedImageMetadataEnabled
=== PAUSE TestAccAwsImageBuilderImage_EnhancedImageMetadataEnabled
=== RUN   TestAccAwsImageBuilderImage_ImageTestsConfiguration_ImageTestsEnabled
=== PAUSE TestAccAwsImageBuilderImage_ImageTestsConfiguration_ImageTestsEnabled
=== RUN   TestAccAwsImageBuilderImage_ImageTestsConfiguration_TimeoutMinutes
=== PAUSE TestAccAwsImageBuilderImage_ImageTestsConfiguration_TimeoutMinutes
=== RUN   TestAccAwsImageBuilderImage_Tags
=== PAUSE TestAccAwsImageBuilderImage_Tags
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_basic
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_basic
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_disappears
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_disappears
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_Description
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_Description
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_Tags
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_Tags
=== RUN   TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure
=== PAUSE TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure
=== CONT  TestAccAwsImageBuilderComponentDataSource_Arn
=== CONT  TestAccAwsImageBuilderImagePipeline_Tags
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_Tags
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_Description
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_disappears
=== CONT  TestAccAwsImageBuilderInfrastructureConfiguration_basic
=== CONT  TestAccAwsImageBuilderImage_Tags
=== CONT  TestAccAwsImageBuilderImage_ImageTestsConfiguration_TimeoutMinutes
=== CONT  TestAccAwsImageBuilderImage_ImageTestsConfiguration_ImageTestsEnabled
--- PASS: TestAccAwsImageBuilderComponentDataSource_Arn (58.98s)
=== CONT  TestAccAwsImageBuilderImage_EnhancedImageMetadataEnabled
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (89.11s)
=== CONT  TestAccAwsImageBuilderImage_DistributionConfigurationArn
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (102.75s)
=== CONT  TestAccAwsImageBuilderImage_disappears
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (115.48s)
=== CONT  TestAccAwsImageBuilderImage_basic
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (147.13s)
=== CONT  TestAccAwsImageBuilderImageRecipe_WorkingDirectory
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (150.56s)
=== CONT  TestAccAwsImageBuilderImageRecipe_Tags
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (150.77s)
=== CONT  TestAccAwsImageBuilderImageRecipe_Description
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (151.50s)
=== CONT  TestAccAwsImageBuilderImageRecipe_Component
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (162.88s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (166.09s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (166.49s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (167.24s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (167.67s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (167.68s)
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (168.68s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops
--- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (184.50s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Tags (190.25s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted
--- PASS: TestAccAwsImageBuilderImageRecipe_WorkingDirectory (54.15s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (53.39s)
=== CONT  TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (56.86s)
=== CONT  TestAccAwsImageBuilderImageRecipe_disappears
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (68.34s)
=== CONT  TestAccAwsImageBuilderImageRecipe_basic
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (57.74s)
=== CONT  TestAccAwsImageBuilderComponent_KmsKeyId
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp2 (59.62s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (58.60s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeTypeGp3 (61.23s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Description
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (60.14s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_disappears
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (58.77s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_basic
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (76.42s)
=== CONT  TestAccAwsImageBuilderComponent_Uri
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (62.46s)
=== CONT  TestAccAwsImageBuilderComponent_Tags
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (62.67s)
=== CONT  TestAccAwsImageBuilderComponent_SupportedOsVersions
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (63.93s)
=== CONT  TestAccAwsImageBuilderComponent_Platform_Windows
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (56.80s)
=== CONT  TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (52.87s)
=== CONT  TestAccAwsImageBuilderComponent_Description
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (66.77s)
=== CONT  TestAccAwsImageBuilderComponent_ChangeDescription
--- PASS: TestAccAwsImageBuilderComponent_KmsKeyId (67.96s)
=== CONT  TestAccAwsImageBuilderComponent_disappears
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (148.32s)
=== CONT  TestAccAwsImageBuilderComponent_basic
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (66.38s)
=== CONT  TestAccAwsImageBuilderImageRecipeDataSource_Arn
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (90.59s)
=== CONT  TestAccAwsImageBuilderImageDataSource_Arn_Self
--- PASS: TestAccAwsImageBuilderComponent_SupportedOsVersions (63.57s)
=== CONT  TestAccAwsImageBuilderImageDataSource_Arn_Aws
--- PASS: TestAccAwsImageBuilderComponent_Platform_Windows (64.24s)
=== CONT  TestAccAwsImageBuilderImagePipelineDataSource_Arn
--- PASS: TestAccAwsImageBuilderComponent_Uri (89.90s)
=== CONT  TestAccAwsImageBuilderImagePipeline_Description
--- PASS: TestAccAwsImageBuilderComponent_disappears (47.88s)
=== CONT  TestAccAwsImageBuilderImagePipeline_Status
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (114.94s)
=== CONT  TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression
--- PASS: TestAccAwsImageBuilderComponent_Description (66.39s)
=== CONT  TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (120.40s)
=== CONT  TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn
--- PASS: TestAccAwsImageBuilderComponent_ChangeDescription (70.41s)
=== CONT  TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes
--- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (85.38s)
=== CONT  TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled
--- PASS: TestAccAwsImageBuilderComponent_basic (64.04s)
=== CONT  TestAccAwsImageBuilderImagePipeline_ImageRecipeArn
--- PASS: TestAccAwsImageBuilderImageDataSource_Arn_Aws (43.68s)
=== CONT  TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled
--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (63.79s)
=== CONT  TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn
--- PASS: TestAccAwsImageBuilderComponent_Tags (135.84s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds
--- PASS: TestAccAwsImageBuilderImagePipelineDataSource_Arn (70.71s)
=== CONT  TestAccAwsImageBuilderImagePipeline_disappears
--- PASS: TestAccAwsImageBuilderImagePipeline_Description (99.30s)
=== CONT  TestAccAwsImageBuilderImagePipeline_basic
--- PASS: TestAccAwsImageBuilderImagePipeline_Status (96.02s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Tags
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (88.90s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
--- PASS: TestAccAwsImageBuilderImagePipeline_InfrastructureConfigurationArn (93.45s)
=== CONT  TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (98.75s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds
--- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_TimeoutMinutes (84.44s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name
--- PASS: TestAccAwsImageBuilderImagePipeline_ImageTestsConfiguration_ImageTestsEnabled (82.98s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
    resource_aws_imagebuilder_distribution_configuration_test.go:463: Step 1/3 error: Error running apply: exit status 1
        
        Error: Error creating License Manager license configuration: ResourceLimitExceededException: You have reached the maximum allowed number of license configurations created in one day.
        
          with aws_licensemanager_license_configuration.test,
          on terraform_plugin_test.tf line 4, in resource "aws_licensemanager_license_configuration" "test":
           4: resource "aws_licensemanager_license_configuration" "test" {
        
--- PASS: TestAccAwsImageBuilderImagePipeline_disappears (45.85s)
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId
--- FAIL: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (13.41s)
--- PASS: TestAccAwsImageBuilderImagePipeline_EnhancedImageMetadataEnabled (84.21s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (66.87s)
--- PASS: TestAccAwsImageBuilderImagePipeline_ImageRecipeArn (93.70s)
--- PASS: TestAccAwsImageBuilderImagePipeline_DistributionConfigurationArn (88.98s)
--- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (31.00s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (29.03s)
--- PASS: TestAccAwsImageBuilderImagePipeline_basic (45.92s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (45.13s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (45.46s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (62.09s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (50.64s)
--- PASS: TestAccAwsImageBuilderImage_ImageTestsConfiguration_ImageTestsEnabled (1107.81s)
--- PASS: TestAccAwsImageBuilderImage_EnhancedImageMetadataEnabled (1238.60s)
--- PASS: TestAccAwsImageBuilderImage_ImageTestsConfiguration_TimeoutMinutes (1363.80s)
--- PASS: TestAccAwsImageBuilderImage_disappears (1358.04s)
--- PASS: TestAccAwsImageBuilderImage_basic (1493.14s)
--- PASS: TestAccAwsImageBuilderImage_DistributionConfigurationArn (1606.00s)
--- PASS: TestAccAwsImageBuilderImage_Tags (1744.65s)
--- PASS: TestAccAwsImageBuilderImageDataSource_Arn_Self (1496.52s)

Failure is unrelated to this change.

@ewbankkit ewbankkit removed their assignment Aug 6, 2021
@anGie44 anGie44 added this to the v3.54.0 milestone Aug 6, 2021
@anGie44 anGie44 merged commit 33655a8 into main Aug 6, 2021
@anGie44 anGie44 deleted the t-imagebuilder-test-failures branch August 6, 2021 19:17
github-actions bot pushed a commit that referenced this pull request Aug 6, 2021
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants