r/iot_topic_rule: add iamwaiter propagation timeout during creation

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Notes

• Tests previously failing in CI with errors similar to:

Error: error creating IoT Topic Rule (test_rule_gk1dn): InvalidRequestException: iot.amazonaws.com is unable to perform: sts:AssumeRole on resource: arn:aws:iam::*******:role/test_role_gk1dn

Output from acceptance testing:

--- PASS: TestAccAWSIoTTopicRule_Tags (112.49s)
--- PASS: TestAccAWSIoTTopicRule_basic (50.29s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (97.37s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (101.97s)
--- PASS: TestAccAWSIoTTopicRule_dynamoDbv2 (97.55s)
--- PASS: TestAccAWSIoTTopicRule_dynamodb (116.55s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (94.80s)
--- PASS: TestAccAWSIoTTopicRule_errorAction (102.27s)
--- PASS: TestAccAWSIoTTopicRule_firehose (97.54s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (112.29s)
--- PASS: TestAccAWSIoTTopicRule_iot_analytics (99.25s)
--- PASS: TestAccAWSIoTTopicRule_iot_events (98.13s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (93.72s)
--- PASS: TestAccAWSIoTTopicRule_lambda (48.03s)
--- PASS: TestAccAWSIoTTopicRule_republish (102.11s)
--- PASS: TestAccAWSIoTTopicRule_republish_with_qos (102.62s)
--- PASS: TestAccAWSIoTTopicRule_s3 (96.09s)
--- PASS: TestAccAWSIoTTopicRule_sns (95.58s)
--- PASS: TestAccAWSIoTTopicRule_sqs (97.64s)
--- PASS: TestAccAWSIoTTopicRule_step_functions (97.45s)
--- PASS: TestAccAWSIoTTopicRule_updateKinesisErrorAction (44.13s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSIoTTopicRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTTopicRule_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.40.16
=== RUN   TestAccAWSIoTTopicRule_basic
=== PAUSE TestAccAWSIoTTopicRule_basic
=== RUN   TestAccAWSIoTTopicRule_cloudwatchalarm
=== PAUSE TestAccAWSIoTTopicRule_cloudwatchalarm
=== RUN   TestAccAWSIoTTopicRule_cloudwatchmetric
=== PAUSE TestAccAWSIoTTopicRule_cloudwatchmetric
=== RUN   TestAccAWSIoTTopicRule_dynamodb
=== PAUSE TestAccAWSIoTTopicRule_dynamodb
=== RUN   TestAccAWSIoTTopicRule_dynamoDbv2
=== PAUSE TestAccAWSIoTTopicRule_dynamoDbv2
=== RUN   TestAccAWSIoTTopicRule_elasticsearch
=== PAUSE TestAccAWSIoTTopicRule_elasticsearch
=== RUN   TestAccAWSIoTTopicRule_firehose
=== PAUSE TestAccAWSIoTTopicRule_firehose
=== RUN   TestAccAWSIoTTopicRule_firehose_separator
=== PAUSE TestAccAWSIoTTopicRule_firehose_separator
=== RUN   TestAccAWSIoTTopicRule_kinesis
=== PAUSE TestAccAWSIoTTopicRule_kinesis
=== RUN   TestAccAWSIoTTopicRule_lambda
=== PAUSE TestAccAWSIoTTopicRule_lambda
=== RUN   TestAccAWSIoTTopicRule_republish
=== PAUSE TestAccAWSIoTTopicRule_republish
=== RUN   TestAccAWSIoTTopicRule_republish_with_qos
=== PAUSE TestAccAWSIoTTopicRule_republish_with_qos
=== RUN   TestAccAWSIoTTopicRule_s3
=== PAUSE TestAccAWSIoTTopicRule_s3
=== RUN   TestAccAWSIoTTopicRule_sns
=== PAUSE TestAccAWSIoTTopicRule_sns
=== RUN   TestAccAWSIoTTopicRule_sqs
=== PAUSE TestAccAWSIoTTopicRule_sqs
=== RUN   TestAccAWSIoTTopicRule_step_functions
=== PAUSE TestAccAWSIoTTopicRule_step_functions
=== RUN   TestAccAWSIoTTopicRule_iot_analytics
=== PAUSE TestAccAWSIoTTopicRule_iot_analytics
=== RUN   TestAccAWSIoTTopicRule_iot_events
=== PAUSE TestAccAWSIoTTopicRule_iot_events
=== RUN   TestAccAWSIoTTopicRule_Tags
=== PAUSE TestAccAWSIoTTopicRule_Tags
=== RUN   TestAccAWSIoTTopicRule_errorAction
=== PAUSE TestAccAWSIoTTopicRule_errorAction
=== RUN   TestAccAWSIoTTopicRule_updateKinesisErrorAction
=== PAUSE TestAccAWSIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccAWSIoTTopicRule_basic
=== CONT  TestAccAWSIoTTopicRule_sqs
=== CONT  TestAccAWSIoTTopicRule_errorAction
=== CONT  TestAccAWSIoTTopicRule_s3
=== CONT  TestAccAWSIoTTopicRule_elasticsearch
=== CONT  TestAccAWSIoTTopicRule_dynamoDbv2
=== CONT  TestAccAWSIoTTopicRule_kinesis
=== CONT  TestAccAWSIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccAWSIoTTopicRule_iot_analytics
=== CONT  TestAccAWSIoTTopicRule_republish_with_qos
=== CONT  TestAccAWSIoTTopicRule_sns
=== CONT  TestAccAWSIoTTopicRule_iot_events
=== CONT  TestAccAWSIoTTopicRule_step_functions
=== CONT  TestAccAWSIoTTopicRule_lambda
=== CONT  TestAccAWSIoTTopicRule_firehose_separator
=== CONT  TestAccAWSIoTTopicRule_firehose
=== CONT  TestAccAWSIoTTopicRule_republish
=== CONT  TestAccAWSIoTTopicRule_cloudwatchmetric
=== CONT  TestAccAWSIoTTopicRule_dynamodb
=== CONT  TestAccAWSIoTTopicRule_Tags
--- PASS: TestAccAWSIoTTopicRule_basic (27.21s)
=== CONT  TestAccAWSIoTTopicRule_cloudwatchalarm
--- PASS: TestAccAWSIoTTopicRule_lambda (27.26s)
--- PASS: TestAccAWSIoTTopicRule_republish_with_qos (46.91s)
--- PASS: TestAccAWSIoTTopicRule_firehose (46.99s)
--- PASS: TestAccAWSIoTTopicRule_republish (48.91s)
--- PASS: TestAccAWSIoTTopicRule_iot_events (51.33s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (53.17s)
--- PASS: TestAccAWSIoTTopicRule_sns (53.36s)
--- PASS: TestAccAWSIoTTopicRule_errorAction (53.82s)
--- PASS: TestAccAWSIoTTopicRule_dynamoDbv2 (55.37s)
--- PASS: TestAccAWSIoTTopicRule_sqs (58.11s)
--- PASS: TestAccAWSIoTTopicRule_step_functions (60.04s)
--- PASS: TestAccAWSIoTTopicRule_dynamodb (60.30s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (64.74s)
--- PASS: TestAccAWSIoTTopicRule_Tags (66.81s)
--- PASS: TestAccAWSIoTTopicRule_iot_analytics (67.17s)
--- PASS: TestAccAWSIoTTopicRule_updateKinesisErrorAction (69.63s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (77.48s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (74.84s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (104.19s)
--- PASS: TestAccAWSIoTTopicRule_s3 (111.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	116.129s

[github-actions]

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.