Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds configurable timeouts for aws_config_organization_conformance_pack #20560

Merged

Conversation

jakauppila
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20345

Output from acceptance testing:

I don't have a test AWS organization to run these acceptance tests in.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/configservice Issues and PRs that pertain to the configservice service. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Aug 13, 2021
@jakauppila
Copy link
Contributor Author

jakauppila commented Aug 14, 2021

Without this change this resource is not usable in a non-trivial AWS Organization. Attempting to push ~12 rules in the conformance pack to an org with ~72 accounts takes well over the current defaulted 10 minute timeout value.

Error: error waiting for Config Organization Conformance Pack (required-policies) to be created: timeout while waiting for state to become 'CREATE_SUCCESSFUL' (last state: 'CREATE_IN_PROGRESS', timeout: 10m0s)

@zhelding zhelding self-assigned this Aug 26, 2021
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2021
@zhelding
Copy link
Contributor

Thanks for the contribution @jakauppila! I went ahead and made a couple small changes and also added a changelog entry -- which I neglected to check for on your last PR.

For details on including a changelog in future PRs, you can see our Changelog Process here.

I've also gone ahead and run the relevant acceptance tests locally, and all LGTM!

[I] ➜ make testacc TESTARGS='-run=TestAccAWSConfig_serial/OrganizationConformancePack/basic\|updateInputParameters'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSConfig_serial/OrganizationConformancePack/basic\|updateInputParameters -timeout 180m
=== RUN   TestAccAWSConfig_serial
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/basic
=== RUN   TestAccAWSConfig_serial/OrganizationConformancePack/updateInputParameters
--- PASS: TestAccAWSConfig_serial (1186.69s)
    --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack (1186.69s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/basic (445.70s)
        --- PASS: TestAccAWSConfig_serial/OrganizationConformancePack/updateInputParameters (740.99s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1186.760s

@zhelding zhelding merged commit 950dbea into hashicorp:main Aug 31, 2021
@github-actions github-actions bot added this to the v3.57.0 milestone Aug 31, 2021
@jakauppila
Copy link
Contributor Author

I'll keep that in mind for next time, thanks @zhelding !

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support timeout in resource AWS Config Organization Conformance Packs
3 participants