Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_identity_provider_config: Use CreateWithoutTimeoutet al. #20561

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20558.
Closes #20155.
Relates #15090.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSEksIdentityProviderConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksIdentityProviderConfig_ -timeout 180m
=== RUN   TestAccAWSEksIdentityProviderConfig_basic
=== PAUSE TestAccAWSEksIdentityProviderConfig_basic
=== RUN   TestAccAWSEksIdentityProviderConfig_disappears
=== PAUSE TestAccAWSEksIdentityProviderConfig_disappears
=== RUN   TestAccAWSEksIdentityProviderConfig_AllOidcOptions
=== PAUSE TestAccAWSEksIdentityProviderConfig_AllOidcOptions
=== RUN   TestAccAWSEksIdentityProviderConfig_Tags
=== PAUSE TestAccAWSEksIdentityProviderConfig_Tags
=== CONT  TestAccAWSEksIdentityProviderConfig_basic
=== CONT  TestAccAWSEksIdentityProviderConfig_Tags
=== CONT  TestAccAWSEksIdentityProviderConfig_AllOidcOptions
=== CONT  TestAccAWSEksIdentityProviderConfig_disappears
--- PASS: TestAccAWSEksIdentityProviderConfig_AllOidcOptions (3932.72s)
--- PASS: TestAccAWSEksIdentityProviderConfig_disappears (4613.14s)
--- PASS: TestAccAWSEksIdentityProviderConfig_Tags (4632.16s)
--- PASS: TestAccAWSEksIdentityProviderConfig_basic (4664.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4667.967s

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. labels Aug 13, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 13, 2021
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 16, 2021
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ewbankkit ewbankkit merged commit 69deee1 into main Aug 18, 2021
@ewbankkit ewbankkit deleted the t-aws_eks_identity_provider_config-timeout branch August 18, 2021 20:31
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 18, 2021
github-actions bot pushed a commit that referenced this pull request Aug 18, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants