Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_storagegateway_smb_file_share: Only set OplocksEnabled in the API if a value is specified in configuration #20579

Merged
merged 4 commits into from
Aug 17, 2021
Merged

r/aws_storagegateway_smb_file_share: Only set OplocksEnabled in the API if a value is specified in configuration #20579

merged 4 commits into from
Aug 17, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20557.

Output from acceptance testing:

Without commenting out TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled:

Commercial

% make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_ -timeout 180m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== RUN   TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== RUN   TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== RUN   TestAccAWSStorageGatewaySmbFileShare_audit
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_audit
=== RUN   TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== RUN   TestAccAWSStorageGatewaySmbFileShare_disappears
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_disappears
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== CONT  TestAccAWSStorageGatewaySmbFileShare_disappears
=== CONT  TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== CONT  TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewaySmbFileShare_audit
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
    resource_aws_storagegateway_smb_file_share_test.go:350: Step 2/3 error: Error running apply: exit status 1
        
        Error: error updating Storage Gateway SMB File Share (arn:aws:storagegateway:us-west-2:123456789012:share/share-86C5A6E3): InvalidGatewayRequestException: The specified gateway is out of date.
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "1ce30e02-f3ee-4586-b2a7-a0401000c165"
          },
          Error_: {
            ErrorCode: "OutdatedGateway"
          },
          Message_: "The specified gateway is out of date."
        }
        
          with aws_storagegateway_smb_file_share.test,
          on terraform_plugin_test.tf line 154, in resource "aws_storagegateway_smb_file_share" "test":
         154: resource "aws_storagegateway_smb_file_share" "test" {
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (299.27s)
--- FAIL: TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled (335.92s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (347.83s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (383.64s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (385.65s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (394.55s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (397.41s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (397.71s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (403.36s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (405.20s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (418.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (425.62s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_notificationPolicy (437.02s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (450.53s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (525.87s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (287.96s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration (395.84s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1052.47s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (1085.25s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (1088.61s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (1118.42s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_smb_acl (1121.68s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       1126.097s
FAIL
make: *** [testacc] Error 1

GovCloud

% make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_ -timeout 180m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== RUN   TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== RUN   TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== RUN   TestAccAWSStorageGatewaySmbFileShare_audit
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_audit
=== RUN   TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== RUN   TestAccAWSStorageGatewaySmbFileShare_disappears
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_disappears
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewaySmbFileShare_audit
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_notificationPolicy
=== CONT  TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: bec1590b-5cbc-4d1a-a34e-be25c28c0642 : RequestId: bec1590b-5cbc-4d1a-a34e-be25c28c0642
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "bec1590b-5cbc-4d1a-a34e-be25c28c0642"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: bec1590b-5cbc-4d1a-a34e-be25c28c0642 : RequestId: bec1590b-5cbc-4d1a-a34e-be25c28c0642",
          RequestId: "bec1590b-5cbc-4d1a-a34e-be25c28c0642"
        }
        
          with aws_directory_service_directory.test,
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: dd3e6c66-d947-4ba0-aae2-08929202e2d7 : RequestId: dd3e6c66-d947-4ba0-aae2-08929202e2d7
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "dd3e6c66-d947-4ba0-aae2-08929202e2d7"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: dd3e6c66-d947-4ba0-aae2-08929202e2d7 : RequestId: dd3e6c66-d947-4ba0-aae2-08929202e2d7",
          RequestId: "dd3e6c66-d947-4ba0-aae2-08929202e2d7"
        }
        
          with aws_directory_service_directory.test,
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 039210fc-4ec2-40d3-b955-168f33a2dc96 : RequestId: 039210fc-4ec2-40d3-b955-168f33a2dc96
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "039210fc-4ec2-40d3-b955-168f33a2dc96"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 039210fc-4ec2-40d3-b955-168f33a2dc96 : RequestId: 039210fc-4ec2-40d3-b955-168f33a2dc96",
          RequestId: "039210fc-4ec2-40d3-b955-168f33a2dc96"
        }
        
          with aws_directory_service_directory.test,
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 1b12fa39-d579-4e2c-a6a4-8f7f9146afc5 : RequestId: 1b12fa39-d579-4e2c-a6a4-8f7f9146afc5
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "1b12fa39-d579-4e2c-a6a4-8f7f9146afc5"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 1b12fa39-d579-4e2c-a6a4-8f7f9146afc5 : RequestId: 1b12fa39-d579-4e2c-a6a4-8f7f9146afc5",
          RequestId: "1b12fa39-d579-4e2c-a6a4-8f7f9146afc5"
        }
        
          with aws_directory_service_directory.test,
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: b7397062-5c71-4754-9a04-a063cd42709f : RequestId: b7397062-5c71-4754-9a04-a063cd42709f
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "b7397062-5c71-4754-9a04-a063cd42709f"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: b7397062-5c71-4754-9a04-a063cd42709f : RequestId: b7397062-5c71-4754-9a04-a063cd42709f",
          RequestId: "b7397062-5c71-4754-9a04-a063cd42709f"
        }
        
          with aws_directory_service_directory.test,
          on terraform_plugin_test.tf line 116, in resource "aws_directory_service_directory" "test":
         116: resource "aws_directory_service_directory" "test" {
        
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (46.10s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_disappears
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (48.16s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_smb_acl (48.24s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (49.45s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (56.46s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled
    resource_aws_storagegateway_smb_file_share_test.go:350: Step 2/3 error: Error running apply: exit status 1
        
        Error: error updating Storage Gateway SMB File Share (arn:aws-us-gov:storagegateway:us-gov-west-1:123456789012:share/share-9281AEE5): InvalidGatewayRequestException: The specified gateway is out of date.
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "56a23d7f-b8c3-420a-ba06-a4fde82b4092"
          },
          Error_: {
            ErrorCode: "OutdatedGateway"
          },
          Message_: "The specified gateway is out of date."
        }
        
          with aws_storagegateway_smb_file_share.test,
          on terraform_plugin_test.tf line 154, in resource "aws_storagegateway_smb_file_share" "test":
         154: resource "aws_storagegateway_smb_file_share" "test" {
        
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (353.35s)
--- FAIL: TestAccAWSStorageGatewaySmbFileShare_OpLocksEnabled (362.91s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (369.42s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (322.41s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (324.52s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (384.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (384.81s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (384.98s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (397.69s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (406.68s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (427.16s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_notificationPolicy (432.91s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration (438.29s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (441.12s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (451.62s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (480.02s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (521.59s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	524.663s
FAIL
make: *** [testacc] Error 1

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 16, 2021
@ewbankkit ewbankkit changed the title r/aws_storagegateway_smb_file_share: Only set OplocksEnabled in the API a value is specified in configuration r/aws_storagegateway_smb_file_share: Only set OplocksEnabled in the API if a value is specified in configuration Aug 16, 2021
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 16, 2021
@YakDriver YakDriver self-assigned this Aug 16, 2021
YakDriver
YakDriver approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉 Odd sort of issue.

Acceptance tests in GovCloud:

--- SKIP: TestAccAWSStorageGatewaySmbFileShare_smb_acl (46.99s)
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (47.65s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (48.48s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (53.28s)
--- SKIP: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (54.37s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (343.75s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (362.41s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (366.10s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (372.11s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (325.30s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (374.81s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (397.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (403.87s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (414.30s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (414.66s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (434.26s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_notificationPolicy (436.17s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (452.23s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration (464.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (468.38s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (470.14s)

Acceptance tests on commercial (us-west-2):

--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (275.98s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (295.31s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (321.95s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (336.62s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (345.90s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (347.16s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (347.35s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (353.25s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (372.94s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (392.43s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_notificationPolicy (392.76s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (398.18s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (399.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_accessBasedEnumeration (400.73s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (441.27s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (323.98s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (956.93s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_smb_acl (1046.19s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (1078.99s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (1084.85s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1194.17s)

@ewbankkit ewbankkit merged commit 6cf9efa into main Aug 17, 2021
@ewbankkit ewbankkit deleted the t-aws_storagegateway_smb_file_share-OutdatedGateway branch August 17, 2021 15:56
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
github-actions bot pushed a commit that referenced this pull request Aug 17, 2021
Update CHANGELOG.md for #20579
e60926c
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.55.0
2 participants
@ewbankkit @YakDriver