Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msk_kafka_version data source #20638

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Add msk_kafka_version data source #20638

merged 6 commits into from
Sep 17, 2021

Conversation

james-bjss
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16268

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMskKafkaVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskKafkaVersion -timeout 180m
=== RUN   TestAccAWSMskKafkaVersion_basic
=== PAUSE TestAccAWSMskKafkaVersion_basic
=== RUN   TestAccAWSMskKafkaVersion_preferred
=== PAUSE TestAccAWSMskKafkaVersion_preferred
=== CONT  TestAccAWSMskKafkaVersion_basic
=== CONT  TestAccAWSMskKafkaVersion_preferred
--- PASS: TestAccAWSMskKafkaVersion_basic (17.61s)
--- PASS: TestAccAWSMskKafkaVersion_preferred (17.70s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       17.766s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 20, 2021
@breathingdust breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSMskKafkaVersionDataSource_'    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskKafkaVersionDataSource_ -timeout 180m
=== RUN   TestAccAWSMskKafkaVersionDataSource_basic
=== PAUSE TestAccAWSMskKafkaVersionDataSource_basic
=== RUN   TestAccAWSMskKafkaVersionDataSource_preferred
=== PAUSE TestAccAWSMskKafkaVersionDataSource_preferred
=== CONT  TestAccAWSMskKafkaVersionDataSource_basic
=== CONT  TestAccAWSMskKafkaVersionDataSource_preferred
--- PASS: TestAccAWSMskKafkaVersionDataSource_preferred (9.27s)
--- PASS: TestAccAWSMskKafkaVersionDataSource_basic (13.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.639s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSMskKafkaVersionDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskKafkaVersionDataSource_ -timeout 180m
=== RUN   TestAccAWSMskKafkaVersionDataSource_basic
=== PAUSE TestAccAWSMskKafkaVersionDataSource_basic
=== RUN   TestAccAWSMskKafkaVersionDataSource_preferred
=== PAUSE TestAccAWSMskKafkaVersionDataSource_preferred
=== CONT  TestAccAWSMskKafkaVersionDataSource_basic
=== CONT  TestAccAWSMskKafkaVersionDataSource_preferred
--- PASS: TestAccAWSMskKafkaVersionDataSource_basic (16.76s)
--- PASS: TestAccAWSMskKafkaVersionDataSource_preferred (16.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.850s

@ewbankkit ewbankkit merged commit 1194e7a into hashicorp:main Sep 17, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 17, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@james-bjss james-bjss deleted the add_msk_kafka_version branch January 29, 2022 14:53
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/kafka Issues and PRs that pertain to the kafka service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d/msk_kafka_version: new data source
3 participants