Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SES domain and email identity default configuration set #21129

Closed
KyleKotowick opened this issue Oct 2, 2021 · 13 comments · Fixed by #27260
Closed

Support for SES domain and email identity default configuration set #21129

KyleKotowick opened this issue Oct 2, 2021 · 13 comments · Fixed by #27260
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Milestone

Comments

@KyleKotowick
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

SES domain and email identities support setting a default configuration set (in the SESv2 API). Currently, Terraform does not support this feature for either of the relevant resources (aws_ses_domain_identity, aws_ses_email_identity).

The AWS API supports both specifying a default configuration set when creating a new email identity (CreateEmailIdentity), as well as setting a default configuration set for an existing email identity (PutEmailIdentityConfigurationSetAttributes).

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_ses_configuration_set" "test" {
  name = "some-configuration-set-test"
}

resource "aws_ses_domain_identity" "example" {
  domain = "example.com"
  default_configuration_set_name = aws_ses_configuration_set.test.name
}

resource "aws_ses_email_identity" "example" {
  email = "email@example.com"
  default_configuration_set_name = aws_ses_configuration_set.test.name
}

OR:

resource "aws_ses_configuration_set" "test" {
  name = "some-configuration-set-test"
}

resource "aws_ses_domain_identity" "example" {
  domain = "example.com"
}

resource "aws_ses_email_identity" "example" {
  email = "email@example.com"
}

// Since the PutEmailIdentityConfigurationSetAttributes API supports both domain and
// email identities, this resource should be able to support either as well?
resource "aws_ses_email_identity_default_configuration_set" "domain" {
  email_identity = aws_ses_domain_identity.example.domain
  configuration_set_name = aws_ses_configuration_set.test.name
}

resource "aws_ses_email_identity_default_configuration_set" "email" {
  email_identity = aws_ses_email_identity.example.domain
  configuration_set_name = aws_ses_configuration_set.test.name
}

References

@KyleKotowick KyleKotowick added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 2, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ses Issues and PRs that pertain to the ses service. labels Oct 2, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2021
@kamilturek
Copy link
Collaborator

kamilturek commented Oct 6, 2021

I am going to take care of this. As the first step we need to migrate from ses to sesv2 service from AWS SDK. Then the new attributes can be added.

@elif-benli-engin
Copy link

Do you have an estimation on this implementation?

@edobrb
Copy link

edobrb commented Apr 12, 2022

Any news on this?

@mrvladis
Copy link

Any updates?!

@gmx-git
Copy link

gmx-git commented Jul 3, 2022

@kamilturek
We're really looking forward for the default_configuration_set_name attribute for the 'aws_ses_domain_identity' and 'aws_ses_email_identity' resources.
It would be great if this topic could be picked up again!
Thank you!!!

@kamilturek
Copy link
Collaborator

I'll try to pick this up again soon 🤞

@florian-heer
Copy link

Is there any update regarding the estimation of this feature? Currently this is a blocker for our use case to use Terraform :(

@gmx-git
Copy link

gmx-git commented Sep 22, 2022

I see there's a plan and a pull request for moving to sesv2.
Maybe we'll need to vote them up (👍) so they can pick up some traction.
Here are the links:
https://github.com/hashicorp/terraform-provider-aws/issues/26796
https://github.com/hashicorp/terraform-provider-aws/pull/26846

Hope this helps move this one forward as well!

@gmx-git
Copy link

gmx-git commented Oct 26, 2022

Hi there,

@ewbankkit / @kamilturek : This topic reports the issue for both domain and email identities. I think so far only the email identity was covered. Should the whole issue be closed in this case?

Is there maybe a plan to get the aws_sesv2_domain_identity resource implemented? I'd have a ton of uses for it! :)

@rav2040
Copy link

rav2040 commented Oct 26, 2022

Hi there,

@ewbankkit / @kamilturek : This topic reports the issue for both domain and email identities. I think so far only the email identity was covered. Should the whole issue be closed in this case?

Is there maybe a plan to get the aws_sesv2_domain_identity resource implemented? I'd have a ton of uses for it! :)

@gmx-git There's no such thing as a domain identity in SES v2 API. The "email identity" supports both email addresses and domains. API reference: https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_CreateEmailIdentity.html

@gmx-git
Copy link

gmx-git commented Oct 27, 2022

Yeah, looking at the API reference, it makes sense to have a single call to create the SES identity resources.
Thanks guys for the implementation!

@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants