Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cloudformation_stack_set_instance: add support for organizations deployment targets #21193

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Oct 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12425

Output from acceptance testing (commercial):

--- SKIP: TestAccAWSCloudFormationStackSetInstance_DeploymentTargets (0.00s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (102.92s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (104.22s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (105.07s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (145.77s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (200.47s)

Output from acceptance testing (organizations-only account):

--- PASS: TestAccAWSCloudFormationStackSetInstance_DeploymentTargets (201.52s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cloudformation Issues and PRs that pertain to the cloudformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Oct 6, 2021
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch 2 times, most recently from 983868d to 83a6124 Compare October 6, 2021 22:39
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch 2 times, most recently from 863e5a4 to d4ecb50 Compare October 6, 2021 22:49
anGie44 added a commit that referenced this pull request Oct 6, 2021
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch from 6fc77e4 to 9b941b1 Compare October 6, 2021 23:04
anGie44 added a commit that referenced this pull request Oct 6, 2021
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch from 7daa778 to 89f2267 Compare October 7, 2021 01:10
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch from 0a66266 to 8802bf6 Compare October 7, 2021 01:13
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 7, 2021
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch from 8802bf6 to 38ea70d Compare October 7, 2021 01:26
@anGie44 anGie44 force-pushed the f-cloudformation-stack-instance-deployment-target branch from 0b53b1b to e51e82a Compare October 7, 2021 01:40
@anGie44 anGie44 marked this pull request as ready for review October 7, 2021 01:46
@ewbankkit ewbankkit self-assigned this Oct 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSetInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSetInstance_ -timeout 180m
=== RUN   TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN   TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN   TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN   TestAccAWSCloudFormationStackSetInstance_DeploymentTargets
    provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSetInstance_DeploymentTargets (0.00s)
=== CONT  TestAccAWSCloudFormationStackSetInstance_basic
=== CONT  TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT  TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (120.10s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (122.67s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (127.64s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (200.34s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (293.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	305.152s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSetInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSetInstance_ -timeout 180m
=== RUN   TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN   TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN   TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN   TestAccAWSCloudFormationStackSetInstance_DeploymentTargets
    provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSetInstance_DeploymentTargets (0.00s)
=== CONT  TestAccAWSCloudFormationStackSetInstance_basic
=== CONT  TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT  TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (125.31s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (126.00s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (128.12s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (208.62s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (260.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	268.478s

@ewbankkit ewbankkit removed their assignment Oct 7, 2021
@anGie44 anGie44 added this to the v3.62.0 milestone Oct 7, 2021
@anGie44 anGie44 merged commit 63ebe48 into main Oct 7, 2021
@anGie44 anGie44 deleted the f-cloudformation-stack-instance-deployment-target branch October 7, 2021 17:59
github-actions bot pushed a commit that referenced this pull request Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support StackSet instances for StackSets that use the SERVICE_MANAGED permission model
2 participants