Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/dms_replication_task: add support for cdc_start_position #21201

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Oct 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12276

Notes

  • Determining an appropriate start position seems to require some steps outside of terraform per https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Task.CDC.html#CHAP_Task.CDC.StartPoint.Native , depending on the source engine , so a test to validate the new arg has been omitted; a new test can pass the CDC start position via the API, but the value will not be returned as expected, possibly because a valid position can not be readily determined/the source database does not actually exist in the acceptance test

Output from acceptance testing:

 --- PASS: TestAccAWSDmsReplicationTask_basic (502.31s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/databasemigrationservice size/XS Managed by automation to categorize the size of a PR. labels Oct 7, 2021
@anGie44 anGie44 marked this pull request as ready for review October 7, 2021 14:32
@ewbankkit ewbankkit self-assigned this Oct 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSDmsReplicationTask_'                               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDmsReplicationTask_ -timeout 180m
=== RUN   TestAccAWSDmsReplicationTask_basic
=== PAUSE TestAccAWSDmsReplicationTask_basic
=== CONT  TestAccAWSDmsReplicationTask_basic
--- PASS: TestAccAWSDmsReplicationTask_basic (488.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	497.643s

@ewbankkit ewbankkit removed their assignment Oct 7, 2021
@anGie44 anGie44 modified the milestones: v3.61.0, v3.62.0 Oct 7, 2021
@anGie44 anGie44 merged commit 18d4527 into main Oct 7, 2021
@anGie44 anGie44 deleted the f-cdc-start-position branch October 7, 2021 17:57
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cdc_start_position parameter to aws_dms_replication_task resource
2 participants